From 69f321714b9830f3c43c3aa10496c4c5d488e477 Mon Sep 17 00:00:00 2001 From: David Frank Date: Mon, 2 Dec 2024 16:14:31 +0000 Subject: [PATCH 1/2] chore: Format perf diff --- benchmarks/src/btreemap.rs | 4 ++-- canbench_results.yml | 4 ++-- scripts/ci_run_benchmark.sh | 7 ++++++- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/benchmarks/src/btreemap.rs b/benchmarks/src/btreemap.rs index 47d959a9..5075e546 100644 --- a/benchmarks/src/btreemap.rs +++ b/benchmarks/src/btreemap.rs @@ -335,7 +335,7 @@ pub fn btreemap_values_rev_10mib_values() -> BenchResult { #[bench(raw)] pub fn btreemap_iter_count_small_values() -> BenchResult { let mut btree = BTreeMap::new(DefaultMemoryImpl::default()); - let size: u32 = 10_000; + let size: u32 = 15_000; for i in 0..size { btree.insert(i, vec![]); } @@ -351,7 +351,7 @@ pub fn btreemap_iter_count_small_values() -> BenchResult { pub fn btreemap_iter_count_10mib_values() -> BenchResult { let mut btree = BTreeMap::new(DefaultMemoryImpl::default()); - let size: u8 = 200; + let size: u8 = 10; // Insert 200 10MiB values. for i in 0..size { diff --git a/canbench_results.yml b/canbench_results.yml index 7697b660..6bb41d2f 100644 --- a/canbench_results.yml +++ b/canbench_results.yml @@ -397,13 +397,13 @@ benches: scopes: {} btreemap_iter_count_10mib_values: total: - instructions: 475842 + instructions: 21376 heap_increase: 0 stable_memory_increase: 0 scopes: {} btreemap_iter_count_small_values: total: - instructions: 9366511 + instructions: 14049692 heap_increase: 0 stable_memory_increase: 0 scopes: {} diff --git a/scripts/ci_run_benchmark.sh b/scripts/ci_run_benchmark.sh index 94cb5d13..8f462c78 100644 --- a/scripts/ci_run_benchmark.sh +++ b/scripts/ci_run_benchmark.sh @@ -69,12 +69,17 @@ if [ -f "$MAIN_BRANCH_RESULTS_FILE" ]; then fi fi +# Add emojis for visualization (as of December 2024, Github does not support colored text) +FORMATTED_CANBENCH_OUTPUT=$(cat "$CANBENCH_OUTPUT" \ + | sed -E 's/.*improved.*/\0 🟢/g' \ + | sed -E 's/.*regress.*/\0 🔴/g') + ## Add the output of canbench to the file. { echo "$UPDATED_MSG" echo "" echo "\`\`\`" - cat "$CANBENCH_OUTPUT" + echo "$FORMATTED_CANBENCH_OUTPUT" echo "\`\`\`" } >> "$COMMENT_MESSAGE_PATH" From 0612e33949982000cc217035438e5fcd1bce677d Mon Sep 17 00:00:00 2001 From: David Frank Date: Mon, 2 Dec 2024 16:26:32 +0000 Subject: [PATCH 2/2] Revert demo --- benchmarks/src/btreemap.rs | 4 ++-- canbench_results.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/benchmarks/src/btreemap.rs b/benchmarks/src/btreemap.rs index 5075e546..47d959a9 100644 --- a/benchmarks/src/btreemap.rs +++ b/benchmarks/src/btreemap.rs @@ -335,7 +335,7 @@ pub fn btreemap_values_rev_10mib_values() -> BenchResult { #[bench(raw)] pub fn btreemap_iter_count_small_values() -> BenchResult { let mut btree = BTreeMap::new(DefaultMemoryImpl::default()); - let size: u32 = 15_000; + let size: u32 = 10_000; for i in 0..size { btree.insert(i, vec![]); } @@ -351,7 +351,7 @@ pub fn btreemap_iter_count_small_values() -> BenchResult { pub fn btreemap_iter_count_10mib_values() -> BenchResult { let mut btree = BTreeMap::new(DefaultMemoryImpl::default()); - let size: u8 = 10; + let size: u8 = 200; // Insert 200 10MiB values. for i in 0..size { diff --git a/canbench_results.yml b/canbench_results.yml index 6bb41d2f..7697b660 100644 --- a/canbench_results.yml +++ b/canbench_results.yml @@ -397,13 +397,13 @@ benches: scopes: {} btreemap_iter_count_10mib_values: total: - instructions: 21376 + instructions: 475842 heap_increase: 0 stable_memory_increase: 0 scopes: {} btreemap_iter_count_small_values: total: - instructions: 14049692 + instructions: 9366511 heap_increase: 0 stable_memory_increase: 0 scopes: {}