From 31cba6bb2a572624b894eed4f51a1c0c695de720 Mon Sep 17 00:00:00 2001 From: Nathan Phillips Date: Tue, 16 May 2017 17:37:57 +0100 Subject: [PATCH 1/2] Updated Travis to catch warnings in unit tests --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 48c0f9b96b4..bb5f03e72e6 100644 --- a/.travis.yml +++ b/.travis.yml @@ -152,7 +152,7 @@ script: - if [ -e bin/gcc ] ; then export PATH=$PWD/bin:$PATH ; fi ; COMMAND="env UBSAN_OPTIONS=print_stacktrace=1 make -C regression test" && eval ${PRE_COMMAND} ${COMMAND} - - COMMAND="make -C unit CXX=\"$COMPILER\" CXXFLAGS=\"$FLAGS $EXTRA_CXXFLAGS\" -j2" && + - COMMAND="make -C unit CXX=\"$COMPILER\" CXXFLAGS=\"-Wall -Werror -pedantic -O2 -g $EXTRA_CXXFLAGS\" -j2" && eval ${PRE_COMMAND} ${COMMAND} - COMMAND="make -C unit test" && eval ${PRE_COMMAND} ${COMMAND} From f0924454e94b102d8cf46d56b6367d80e394823f Mon Sep 17 00:00:00 2001 From: Nathan Phillips Date: Tue, 16 May 2017 17:38:32 +0100 Subject: [PATCH 2/2] Add brackets to resolve ambiguity caused by use of bitwise instead of logical operators --- unit/miniBDD.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unit/miniBDD.cpp b/unit/miniBDD.cpp index ecda45a4ff1..d0eba414184 100644 --- a/unit/miniBDD.cpp +++ b/unit/miniBDD.cpp @@ -18,7 +18,7 @@ void test1() mini_bddt x=mgr.Var("x"); mini_bddt y=mgr.Var("y"); mini_bddt z=mgr.Var("z"); - mini_bddt f=(x&y&z)|(!x&!y&z); + mini_bddt f=(x&y&z)|((!x)&(!y)&z); y.clear(); x.clear(); z.clear();