From 3d07d63642138d64820b3aa664cd3f97f099740b Mon Sep 17 00:00:00 2001
From: Sebastian Wilzbach <seb@wilzba.ch>
Date: Mon, 12 Jun 2017 10:23:43 +0200
Subject: [PATCH] Revert "fix Issue 14246 - RAII - proper destruction of
 partially constructed objects/structs"

This reverts commit 1e755c648e5142719d50dcf984f10ace5b8f8357.
---
 src/ddmd/aggregate.d  |  1 -
 src/ddmd/aggregate.h  |  1 -
 src/ddmd/clone.d      |  1 -
 src/ddmd/func.d       | 31 +------------------------------
 test/runnable/sdtor.d | 33 ---------------------------------
 5 files changed, 1 insertion(+), 66 deletions(-)

diff --git a/src/ddmd/aggregate.d b/src/ddmd/aggregate.d
index aa569a12f6c6..10161aa1aa6d 100644
--- a/src/ddmd/aggregate.d
+++ b/src/ddmd/aggregate.d
@@ -97,7 +97,6 @@ extern (C++) abstract class AggregateDeclaration : ScopeDsymbol
 
     FuncDeclarations dtors; // Array of destructors
     FuncDeclaration dtor;   // aggregate destructor
-    FuncDeclaration fieldDtor;   // aggregate destructor for just the fields
 
     Expression getRTInfo;   // pointer to GC info generated by object.RTInfo(this)
 
diff --git a/src/ddmd/aggregate.h b/src/ddmd/aggregate.h
index 024c23b6be45..324597370fd6 100644
--- a/src/ddmd/aggregate.h
+++ b/src/ddmd/aggregate.h
@@ -115,7 +115,6 @@ class AggregateDeclaration : public ScopeDsymbol
 
     FuncDeclarations dtors;     // Array of destructors
     FuncDeclaration *dtor;      // aggregate destructor
-    FuncDeclaration *fieldDtor; // aggregate destructor for just the fields
 
     Expression *getRTInfo;      // pointer to GC info generated by object.RTInfo(this)
 
diff --git a/src/ddmd/clone.d b/src/ddmd/clone.d
index 9b22142bf33c..0421d5a602e0 100644
--- a/src/ddmd/clone.d
+++ b/src/ddmd/clone.d
@@ -1081,7 +1081,6 @@ extern (C++) FuncDeclaration buildDtor(AggregateDeclaration ad, Scope* sc)
         ad.dtors.shift(dd);
         ad.members.push(dd);
         dd.semantic(sc);
-        ad.fieldDtor = dd;
     }
 
     FuncDeclaration xdtor = null;
diff --git a/src/ddmd/func.d b/src/ddmd/func.d
index 30d73636020e..b20ab75eb73e 100644
--- a/src/ddmd/func.d
+++ b/src/ddmd/func.d
@@ -1102,7 +1102,7 @@ extern (C++) class FuncDeclaration : Declaration
     }
 
     // Do the semantic analysis on the internals of the function.
-    override void semantic3(Scope* sc)
+    override final void semantic3(Scope* sc)
     {
         VarDeclaration _arguments = null;
 
@@ -4691,35 +4691,6 @@ extern (C++) final class CtorDeclaration : FuncDeclaration
         }
     }
 
-    override final void semantic3(Scope* sc)
-    {
-        if (semanticRun >= PASSsemantic3)
-            return;
-
-        /* If any of the fields of the struct have a destructor, add
-         *   scope (failure) { this.fieldDtor(); }
-         * as the first statement. It is not necessary to add it after
-         * each initialization of a field, because destruction of .init constructed
-         * structs should be benign.
-         */
-        AggregateDeclaration ad = toParent2().isAggregateDeclaration();
-        if (ad && ad.fieldDtor)
-        {
-            /* Generate:
-             *   scope (failure) { this.fieldDtor(); }
-             */
-            Expression e = new ThisExp(loc);
-            e.type = ad.type.mutableOf();
-            e = new DotVarExp(loc, e, ad.fieldDtor, false);
-            e = new CallExp(loc, e);
-            auto sexp = new ExpStatement(loc, e);
-            auto s = new OnScopeStatement(loc, TOKon_scope_failure, sexp);
-
-            fbody = new CompoundStatement(loc, s, fbody);
-        }
-        FuncDeclaration.semantic3(sc);
-    }
-
     override const(char)* kind() const
     {
         return "constructor";
diff --git a/test/runnable/sdtor.d b/test/runnable/sdtor.d
index f01345be9620..fa7874ee45d2 100644
--- a/test/runnable/sdtor.d
+++ b/test/runnable/sdtor.d
@@ -4222,38 +4222,6 @@ int test14860()
 }
 static assert(test14860());
 
-/**********************************/
-// https://issues.dlang.org/show_bug.cgi?id=14246
-
-struct A14246 {
-     int a = 3;
-     static string s;
-     this( int var ) { printf("A()\n"); a += var; s ~= "a"; }
-
-     ~this() { printf("~A()\n"); s ~= "b"; }
-}
-
-struct B14246 {
-     int i;
-     A14246 a;
-
-     this( int var ) {
-         A14246.s ~= "c";
-         a = A14246(var+1);
-         throw new Exception("An exception");
-     }
-}
-
-void test14246() {
-    try {
-         auto b = B14246(2);
-    } catch( Exception ex ) {
-        printf("Caught ex\n");
-        A14246.s ~= "d";
-    }
-    assert(A14246.s == "cabd");
-}
-
 /**********************************/
 // 14696
 
@@ -4675,7 +4643,6 @@ int main()
     test14815();
     test16197();
     test14860();
-    test14246();
     test14696();
     test14838();
     test63();