From b59551911561c3a4032d28672c6119a0d0508d9f Mon Sep 17 00:00:00 2001 From: tqchen Date: Wed, 20 Jun 2018 12:06:56 -0700 Subject: [PATCH 1/2] Fix g++8 warning --- include/dmlc/parameter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/dmlc/parameter.h b/include/dmlc/parameter.h index dd631c39f5..5e5def981b 100644 --- a/include/dmlc/parameter.h +++ b/include/dmlc/parameter.h @@ -994,7 +994,7 @@ class FieldEntry : public FieldEntryNumeric, float> { os << "Invalid Parameter format for " << key_ << " expect " << type_ << " but value=\'" << value << '\''; throw dmlc::ParamError(os.str()); - } catch (const std::out_of_range) { + } catch (const std::out_of_range&) { std::ostringstream os; os << "Out of range value for " << key_ << ", value=\'" << value << '\''; throw dmlc::ParamError(os.str()); From 0fa3b02705deff587074be8025847b413888c80c Mon Sep 17 00:00:00 2001 From: tqchen Date: Wed, 20 Jun 2018 12:09:02 -0700 Subject: [PATCH 2/2] fix g++warning --- include/dmlc/parameter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/dmlc/parameter.h b/include/dmlc/parameter.h index 5e5def981b..0830cb99cd 100644 --- a/include/dmlc/parameter.h +++ b/include/dmlc/parameter.h @@ -1019,7 +1019,7 @@ class FieldEntry os << "Invalid Parameter format for " << key_ << " expect " << type_ << " but value=\'" << value << '\''; throw dmlc::ParamError(os.str()); - } catch (const std::out_of_range) { + } catch (const std::out_of_range&) { std::ostringstream os; os << "Out of range value for " << key_ << ", value=\'" << value << '\''; throw dmlc::ParamError(os.str());