diff --git a/cli/command/builder/prune.go b/cli/command/builder/prune.go index 1c36f358edfa..9eef43216429 100644 --- a/cli/command/builder/prune.go +++ b/cli/command/builder/prune.go @@ -8,7 +8,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/internal/prompt" "github.com/docker/cli/opts" "github.com/docker/docker/api/types/build" @@ -50,7 +49,7 @@ func newPruneCommand(dockerCLI command.Cli) *cobra.Command { return nil }, Annotations: map[string]string{"version": "1.39"}, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/checkpoint/create.go b/cli/command/checkpoint/create.go index 8455e979e64f..aa471bf3b83e 100644 --- a/cli/command/checkpoint/create.go +++ b/cli/command/checkpoint/create.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/docker/api/types/checkpoint" "github.com/spf13/cobra" ) @@ -30,7 +29,7 @@ func newCreateCommand(dockerCli command.Cli) *cobra.Command { opts.checkpoint = args[1] return runCreate(cmd.Context(), dockerCli, opts) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/completion/functions.go b/cli/command/completion/functions.go index b6387c127883..9a7d67b174ec 100644 --- a/cli/command/completion/functions.go +++ b/cli/command/completion/functions.go @@ -141,7 +141,9 @@ func FileNames(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCom return nil, cobra.ShellCompDirectiveDefault } -// NoComplete is used for commands where there's no relevant completion +// NoComplete is used for commands where there's no relevant completion. +// +// Deprecated: use [cobra.NoFileCompletions]. This function will be removed in the next release. func NoComplete(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) { return nil, cobra.ShellCompDirectiveNoFileComp } diff --git a/cli/command/completion/functions_test.go b/cli/command/completion/functions_test.go index 12cd0ce425ee..2c2aa307fa1d 100644 --- a/cli/command/completion/functions_test.go +++ b/cli/command/completion/functions_test.go @@ -288,12 +288,6 @@ func TestCompleteNetworkNames(t *testing.T) { } } -func TestCompleteNoComplete(t *testing.T) { - values, directives := NoComplete(nil, nil, "") - assert.Check(t, is.Equal(directives, cobra.ShellCompDirectiveNoFileComp)) - assert.Check(t, is.Len(values, 0)) -} - func TestCompletePlatforms(t *testing.T) { values, directives := Platforms(nil, nil, "") assert.Check(t, is.Equal(directives&cobra.ShellCompDirectiveNoFileComp, cobra.ShellCompDirectiveNoFileComp), "Should not perform file completion") diff --git a/cli/command/config/create.go b/cli/command/config/create.go index 2bbe1cf61367..e6e2c39b073b 100644 --- a/cli/command/config/create.go +++ b/cli/command/config/create.go @@ -7,7 +7,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/opts" "github.com/docker/docker/api/types/swarm" "github.com/moby/sys/sequential" @@ -47,7 +46,7 @@ func newConfigCreateCommand(dockerCLI command.Cli) *cobra.Command { createOpts.file = args[1] return runCreate(cmd.Context(), dockerCLI, createOpts) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() flags.VarP(&createOpts.labels, "label", "l", "Config labels") diff --git a/cli/command/config/ls.go b/cli/command/config/ls.go index 63ffdae4de48..d7cb10f1c990 100644 --- a/cli/command/config/ls.go +++ b/cli/command/config/ls.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" flagsHelper "github.com/docker/cli/cli/flags" "github.com/docker/cli/opts" @@ -42,7 +41,7 @@ func newConfigListCommand(dockerCLI command.Cli) *cobra.Command { RunE: func(cmd *cobra.Command, args []string) error { return runList(cmd.Context(), dockerCLI, listOpts) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/container/create.go b/cli/command/container/create.go index de635606b8d7..f38746fd3cf6 100644 --- a/cli/command/container/create.go +++ b/cli/command/container/create.go @@ -105,7 +105,7 @@ func newCreateCommand(dockerCLI command.Cli) *cobra.Command { // Set a default completion function if none was set. We don't look // up if it does already have one set, because Cobra does this for // us, and returns an error (which we ignore for this reason). - _ = cmd.RegisterFlagCompletionFunc(flag.Name, completion.NoComplete) + _ = cmd.RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions) }) return cmd diff --git a/cli/command/container/list.go b/cli/command/container/list.go index 5a30291ff224..a76e1ef1468f 100644 --- a/cli/command/container/list.go +++ b/cli/command/container/list.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" flagsHelper "github.com/docker/cli/cli/flags" "github.com/docker/cli/opts" @@ -50,7 +49,7 @@ func newPsCommand(dockerCLI command.Cli) *cobra.Command { "category-top": "3", "aliases": "docker container ls, docker container list, docker container ps, docker ps", }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/container/prune.go b/cli/command/container/prune.go index 5baf040b79fa..2e0439ae070f 100644 --- a/cli/command/container/prune.go +++ b/cli/command/container/prune.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/internal/prompt" "github.com/docker/cli/opts" "github.com/docker/go-units" @@ -45,7 +44,7 @@ func newPruneCommand(dockerCLI command.Cli) *cobra.Command { return nil }, Annotations: map[string]string{"version": "1.25"}, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/container/run.go b/cli/command/container/run.go index 2674e5b11c4b..3cdb71c927d5 100644 --- a/cli/command/container/run.go +++ b/cli/command/container/run.go @@ -84,7 +84,7 @@ func newRunCommand(dockerCLI command.Cli) *cobra.Command { // Set a default completion function if none was set. We don't look // up if it does already have one set, because Cobra does this for // us, and returns an error (which we ignore for this reason). - _ = cmd.RegisterFlagCompletionFunc(flag.Name, completion.NoComplete) + _ = cmd.RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions) }) return cmd diff --git a/cli/command/context/create.go b/cli/command/context/create.go index 308aa8720069..0e1c649c4aa7 100644 --- a/cli/command/context/create.go +++ b/cli/command/context/create.go @@ -11,7 +11,6 @@ import ( "github.com/containerd/errdefs" "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter/tabwriter" "github.com/docker/cli/cli/context/docker" "github.com/docker/cli/cli/context/store" @@ -54,7 +53,7 @@ func newCreateCommand(dockerCLI command.Cli) *cobra.Command { return RunCreate(dockerCLI, opts) }, Long: longCreateDescription(), - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() flags.StringVar(&opts.Description, "description", "", "Description of the context") diff --git a/cli/command/context/list.go b/cli/command/context/list.go index b4258b91a302..88e080cacd27 100644 --- a/cli/command/context/list.go +++ b/cli/command/context/list.go @@ -10,7 +10,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" "github.com/docker/cli/cli/context/docker" flagsHelper "github.com/docker/cli/cli/flags" @@ -34,7 +33,7 @@ func newListCommand(dockerCli command.Cli) *cobra.Command { RunE: func(cmd *cobra.Command, args []string) error { return runList(dockerCli, opts) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/context/show.go b/cli/command/context/show.go index dd33f9e02a84..d5e4a828e35a 100644 --- a/cli/command/context/show.go +++ b/cli/command/context/show.go @@ -5,7 +5,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/spf13/cobra" ) @@ -19,7 +18,7 @@ func newShowCommand(dockerCli command.Cli) *cobra.Command { runShow(dockerCli) return nil }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } return cmd } diff --git a/cli/command/image/load.go b/cli/command/image/load.go index 268c18d2ef77..442178e54a4e 100644 --- a/cli/command/image/load.go +++ b/cli/command/image/load.go @@ -42,7 +42,7 @@ func newLoadCommand(dockerCLI command.Cli) *cobra.Command { Annotations: map[string]string{ "aliases": "docker image load, docker load", }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/image/prune.go b/cli/command/image/prune.go index f9db8761e17e..adc9773c30bd 100644 --- a/cli/command/image/prune.go +++ b/cli/command/image/prune.go @@ -8,7 +8,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/internal/prompt" "github.com/docker/cli/opts" "github.com/docker/go-units" @@ -49,7 +48,7 @@ func newPruneCommand(dockerCLI command.Cli) *cobra.Command { return nil }, Annotations: map[string]string{"version": "1.25"}, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/image/pull.go b/cli/command/image/pull.go index 99ac61951849..668c9cbc8bac 100644 --- a/cli/command/image/pull.go +++ b/cli/command/image/pull.go @@ -46,7 +46,7 @@ func newPullCommand(dockerCLI command.Cli) *cobra.Command { "category-top": "5", "aliases": "docker image pull, docker pull", }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/network/create.go b/cli/command/network/create.go index c8fca4129429..c19444f90def 100644 --- a/cli/command/network/create.go +++ b/cli/command/network/create.go @@ -10,7 +10,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/opts" "github.com/docker/docker/api/types/network" "github.com/docker/docker/client" @@ -69,7 +68,7 @@ func newCreateCommand(dockerCLI command.Cli) *cobra.Command { return runCreate(cmd.Context(), dockerCLI.Client(), dockerCLI.Out(), options) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/network/list.go b/cli/command/network/list.go index b4fd10a7dd43..9ac2367b6180 100644 --- a/cli/command/network/list.go +++ b/cli/command/network/list.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" flagsHelper "github.com/docker/cli/cli/flags" "github.com/docker/cli/opts" @@ -33,7 +32,7 @@ func newListCommand(dockerCli command.Cli) *cobra.Command { RunE: func(cmd *cobra.Command, args []string) error { return runList(cmd.Context(), dockerCli, options) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/node/list.go b/cli/command/node/list.go index 821c1b4f0f94..3364b2daa217 100644 --- a/cli/command/node/list.go +++ b/cli/command/node/list.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" flagsHelper "github.com/docker/cli/cli/flags" "github.com/docker/cli/opts" @@ -34,7 +33,7 @@ func newListCommand(dockerCli command.Cli) *cobra.Command { RunE: func(cmd *cobra.Command, args []string) error { return runList(cmd.Context(), dockerCli, options) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() flags.BoolVarP(&options.quiet, "quiet", "q", false, "Only display IDs") @@ -45,7 +44,7 @@ func newListCommand(dockerCli command.Cli) *cobra.Command { // Set a default completion function if none was set. We don't look // up if it does already have one set, because Cobra does this for // us, and returns an error (which we ignore for this reason). - _ = cmd.RegisterFlagCompletionFunc(flag.Name, completion.NoComplete) + _ = cmd.RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions) }) return cmd } diff --git a/cli/command/node/ps.go b/cli/command/node/ps.go index 3552de76af1b..62b5ee141348 100644 --- a/cli/command/node/ps.go +++ b/cli/command/node/ps.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/idresolver" "github.com/docker/cli/cli/command/task" "github.com/docker/cli/opts" @@ -54,7 +53,7 @@ func newPsCommand(dockerCli command.Cli) *cobra.Command { // Set a default completion function if none was set. We don't look // up if it does already have one set, because Cobra does this for // us, and returns an error (which we ignore for this reason). - _ = cmd.RegisterFlagCompletionFunc(flag.Name, completion.NoComplete) + _ = cmd.RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions) }) return cmd } diff --git a/cli/command/node/update.go b/cli/command/node/update.go index 3d4bc11401d2..9ece2c9599ec 100644 --- a/cli/command/node/update.go +++ b/cli/command/node/update.go @@ -43,7 +43,7 @@ func newUpdateCommand(dockerCli command.Cli) *cobra.Command { // Set a default completion function if none was set. We don't look // up if it does already have one set, because Cobra does this for // us, and returns an error (which we ignore for this reason). - _ = cmd.RegisterFlagCompletionFunc(flag.Name, completion.NoComplete) + _ = cmd.RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions) }) return cmd } diff --git a/cli/command/plugin/create.go b/cli/command/plugin/create.go index b10da8cb29de..2b744c469582 100644 --- a/cli/command/plugin/create.go +++ b/cli/command/plugin/create.go @@ -10,7 +10,6 @@ import ( "github.com/distribution/reference" "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/docker/api/types" "github.com/moby/go-archive" "github.com/moby/go-archive/compression" @@ -76,7 +75,7 @@ func newCreateCommand(dockerCli command.Cli) *cobra.Command { options.context = args[1] return runCreate(cmd.Context(), dockerCli, options) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/plugin/list.go b/cli/command/plugin/list.go index da08a06f955c..85521671465e 100644 --- a/cli/command/plugin/list.go +++ b/cli/command/plugin/list.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" flagsHelper "github.com/docker/cli/cli/flags" "github.com/docker/cli/opts" @@ -32,7 +31,7 @@ func newListCommand(dockerCli command.Cli) *cobra.Command { RunE: func(cmd *cobra.Command, args []string) error { return runList(cmd.Context(), dockerCli, options) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/registry/login.go b/cli/command/registry/login.go index 65e90d0cd679..a94a29e93a1b 100644 --- a/cli/command/registry/login.go +++ b/cli/command/registry/login.go @@ -11,7 +11,6 @@ import ( "github.com/containerd/errdefs" "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/config/configfile" configtypes "github.com/docker/cli/cli/config/types" "github.com/docker/cli/internal/oauth/manager" @@ -59,7 +58,7 @@ func newLoginCommand(dockerCLI command.Cli) *cobra.Command { Annotations: map[string]string{ "category-top": "8", }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/service/create.go b/cli/command/service/create.go index f63f65aefe24..621fc9f36feb 100644 --- a/cli/command/service/create.go +++ b/cli/command/service/create.go @@ -29,7 +29,7 @@ func newCreateCommand(dockerCLI command.Cli) *cobra.Command { } return runCreate(cmd.Context(), dockerCLI, cmd.Flags(), opts) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() flags.StringVar(&opts.mode, flagMode, "replicated", `Service mode ("replicated", "global", "replicated-job", "global-job")`) @@ -94,7 +94,7 @@ func newCreateCommand(dockerCLI command.Cli) *cobra.Command { // Set a default completion function if none was set. We don't look // up if it does already have one set, because Cobra does this for // us, and returns an error (which we ignore for this reason). - _ = cmd.RegisterFlagCompletionFunc(flag.Name, completion.NoComplete) + _ = cmd.RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions) }) return cmd } diff --git a/cli/command/service/inspect.go b/cli/command/service/inspect.go index d94aeceb9c21..aa8cbcbcf667 100644 --- a/cli/command/service/inspect.go +++ b/cli/command/service/inspect.go @@ -10,7 +10,6 @@ import ( "github.com/containerd/errdefs" "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" flagsHelper "github.com/docker/cli/cli/flags" "github.com/docker/docker/api/types/network" @@ -52,7 +51,7 @@ func newInspectCommand(dockerCli command.Cli) *cobra.Command { // Set a default completion function if none was set. We don't look // up if it does already have one set, because Cobra does this for // us, and returns an error (which we ignore for this reason). - _ = cmd.RegisterFlagCompletionFunc(flag.Name, completion.NoComplete) + _ = cmd.RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions) }) return cmd } diff --git a/cli/command/service/list.go b/cli/command/service/list.go index d2768cc0e197..278a7dcc7239 100644 --- a/cli/command/service/list.go +++ b/cli/command/service/list.go @@ -5,7 +5,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" flagsHelper "github.com/docker/cli/cli/flags" "github.com/docker/cli/opts" @@ -33,7 +32,7 @@ func newListCommand(dockerCLI command.Cli) *cobra.Command { RunE: func(cmd *cobra.Command, args []string) error { return runList(cmd.Context(), dockerCLI, options) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() @@ -45,7 +44,7 @@ func newListCommand(dockerCLI command.Cli) *cobra.Command { // Set a default completion function if none was set. We don't look // up if it does already have one set, because Cobra does this for // us, and returns an error (which we ignore for this reason). - _ = cmd.RegisterFlagCompletionFunc(flag.Name, completion.NoComplete) + _ = cmd.RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions) }) return cmd } diff --git a/cli/command/service/logs.go b/cli/command/service/logs.go index a3e29f6b454c..b92f8dcf0fba 100644 --- a/cli/command/service/logs.go +++ b/cli/command/service/logs.go @@ -12,7 +12,6 @@ import ( "github.com/containerd/errdefs" "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" "github.com/docker/cli/cli/command/idresolver" "github.com/docker/cli/internal/logdetails" @@ -73,7 +72,7 @@ func newLogsCommand(dockerCli command.Cli) *cobra.Command { // Set a default completion function if none was set. We don't look // up if it does already have one set, because Cobra does this for // us, and returns an error (which we ignore for this reason). - _ = cmd.RegisterFlagCompletionFunc(flag.Name, completion.NoComplete) + _ = cmd.RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions) }) return cmd } diff --git a/cli/command/service/ps.go b/cli/command/service/ps.go index 601014054d0d..b55db793d29b 100644 --- a/cli/command/service/ps.go +++ b/cli/command/service/ps.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/idresolver" "github.com/docker/cli/cli/command/node" "github.com/docker/cli/cli/command/task" @@ -52,7 +51,7 @@ func newPsCommand(dockerCli command.Cli) *cobra.Command { // Set a default completion function if none was set. We don't look // up if it does already have one set, because Cobra does this for // us, and returns an error (which we ignore for this reason). - _ = cmd.RegisterFlagCompletionFunc(flag.Name, completion.NoComplete) + _ = cmd.RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions) }) return cmd } diff --git a/cli/command/service/rollback.go b/cli/command/service/rollback.go index 3b4a445f2e23..a100c9f0d9fa 100644 --- a/cli/command/service/rollback.go +++ b/cli/command/service/rollback.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/docker/api/types/swarm" "github.com/docker/docker/api/types/versions" "github.com/spf13/cobra" @@ -35,7 +34,7 @@ func newRollbackCommand(dockerCli command.Cli) *cobra.Command { // Set a default completion function if none was set. We don't look // up if it does already have one set, because Cobra does this for // us, and returns an error (which we ignore for this reason). - _ = cmd.RegisterFlagCompletionFunc(flag.Name, completion.NoComplete) + _ = cmd.RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions) }) return cmd } diff --git a/cli/command/service/update.go b/cli/command/service/update.go index 5f9971adf287..7ebcb461b55c 100644 --- a/cli/command/service/update.go +++ b/cli/command/service/update.go @@ -137,7 +137,7 @@ func newUpdateCommand(dockerCLI command.Cli) *cobra.Command { // Set a default completion function if none was set. We don't look // up if it does already have one set, because Cobra does this for // us, and returns an error (which we ignore for this reason). - _ = cmd.RegisterFlagCompletionFunc(flag.Name, completion.NoComplete) + _ = cmd.RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions) }) return cmd diff --git a/cli/command/stack/config.go b/cli/command/stack/config.go index 045db77b5fa6..9af8acf10338 100644 --- a/cli/command/stack/config.go +++ b/cli/command/stack/config.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/stack/loader" "github.com/docker/cli/cli/command/stack/options" composeLoader "github.com/docker/cli/cli/compose/loader" @@ -36,7 +35,7 @@ func newConfigCommand(dockerCli command.Cli) *cobra.Command { _, err = fmt.Fprintf(dockerCli.Out(), "%s", cfg) return err }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/stack/list.go b/cli/command/stack/list.go index 1b4831d43a9e..74a7fd98f8b0 100644 --- a/cli/command/stack/list.go +++ b/cli/command/stack/list.go @@ -7,7 +7,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/stack/formatter" "github.com/docker/cli/cli/command/stack/options" "github.com/docker/cli/cli/command/stack/swarm" @@ -29,7 +28,7 @@ func newListCommand(dockerCli command.Cli) *cobra.Command { RunE: func(cmd *cobra.Command, args []string) error { return runList(cmd.Context(), dockerCli, opts) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/swarm/ca.go b/cli/command/swarm/ca.go index edde543f5a57..7155f7e11e1f 100644 --- a/cli/command/swarm/ca.go +++ b/cli/command/swarm/ca.go @@ -8,7 +8,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/swarm/progress" "github.com/docker/cli/internal/jsonstream" "github.com/docker/docker/api/types/swarm" @@ -40,7 +39,7 @@ func newCACommand(dockerCli command.Cli) *cobra.Command { "version": "1.30", "swarm": "manager", }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/swarm/init.go b/cli/command/swarm/init.go index d61aab755bd0..f779787a02d9 100644 --- a/cli/command/swarm/init.go +++ b/cli/command/swarm/init.go @@ -8,7 +8,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/docker/api/types/swarm" "github.com/pkg/errors" "github.com/spf13/cobra" @@ -44,7 +43,7 @@ func newInitCommand(dockerCli command.Cli) *cobra.Command { "version": "1.24", "swarm": "", // swarm init does not require swarm to be active, and is always available on API 1.24 and up }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/swarm/leave.go b/cli/command/swarm/leave.go index 28c8d603aa60..335dbb0042e5 100644 --- a/cli/command/swarm/leave.go +++ b/cli/command/swarm/leave.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/spf13/cobra" ) @@ -28,7 +27,7 @@ func newLeaveCommand(dockerCli command.Cli) *cobra.Command { "version": "1.24", "swarm": "active", }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/swarm/unlock.go b/cli/command/swarm/unlock.go index e2af459b83b1..8f5980b00932 100644 --- a/cli/command/swarm/unlock.go +++ b/cli/command/swarm/unlock.go @@ -9,7 +9,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/streams" "github.com/docker/docker/api/types/swarm" "github.com/pkg/errors" @@ -29,7 +28,7 @@ func newUnlockCommand(dockerCli command.Cli) *cobra.Command { "version": "1.24", "swarm": "manager", }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } return cmd diff --git a/cli/command/swarm/unlock_key.go b/cli/command/swarm/unlock_key.go index af62e0b09a95..a8cd82c5938c 100644 --- a/cli/command/swarm/unlock_key.go +++ b/cli/command/swarm/unlock_key.go @@ -7,7 +7,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/docker/api/types/swarm" "github.com/pkg/errors" "github.com/spf13/cobra" @@ -32,7 +31,7 @@ func newUnlockKeyCommand(dockerCli command.Cli) *cobra.Command { "version": "1.24", "swarm": "manager", }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/swarm/update.go b/cli/command/swarm/update.go index c356e994a067..f90041d39cc5 100644 --- a/cli/command/swarm/update.go +++ b/cli/command/swarm/update.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/docker/api/types/swarm" "github.com/pkg/errors" "github.com/spf13/cobra" @@ -33,7 +32,7 @@ func newUpdateCommand(dockerCli command.Cli) *cobra.Command { "version": "1.24", "swarm": "manager", }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } cmd.Flags().BoolVar(&opts.autolock, flagAutolock, false, "Change manager autolocking setting (true|false)") diff --git a/cli/command/system/df.go b/cli/command/system/df.go index f6a98a036776..cb040049fa53 100644 --- a/cli/command/system/df.go +++ b/cli/command/system/df.go @@ -5,7 +5,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" flagsHelper "github.com/docker/cli/cli/flags" "github.com/docker/docker/api/types" @@ -29,7 +28,7 @@ func newDiskUsageCommand(dockerCli command.Cli) *cobra.Command { return runDiskUsage(cmd.Context(), dockerCli, opts) }, Annotations: map[string]string{"version": "1.25"}, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/system/dial_stdio.go b/cli/command/system/dial_stdio.go index c8ccd181c794..fc1cbee27a73 100644 --- a/cli/command/system/dial_stdio.go +++ b/cli/command/system/dial_stdio.go @@ -7,7 +7,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/pkg/errors" "github.com/sirupsen/logrus" "github.com/spf13/cobra" @@ -23,7 +22,7 @@ func newDialStdioCommand(dockerCli command.Cli) *cobra.Command { RunE: func(cmd *cobra.Command, args []string) error { return runDialStdio(cmd.Context(), dockerCli) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } return cmd } diff --git a/cli/command/system/events.go b/cli/command/system/events.go index 782f9eff5224..f8d2e69fe11a 100644 --- a/cli/command/system/events.go +++ b/cli/command/system/events.go @@ -11,7 +11,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" flagsHelper "github.com/docker/cli/cli/flags" "github.com/docker/cli/opts" @@ -48,7 +47,7 @@ func newEventsCommand(dockerCLI command.Cli) *cobra.Command { Annotations: map[string]string{ "aliases": "docker system events, docker events", }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/system/info.go b/cli/command/system/info.go index 350431c8386c..b4b6daab6ffd 100644 --- a/cli/command/system/info.go +++ b/cli/command/system/info.go @@ -14,7 +14,6 @@ import ( "github.com/docker/cli/cli" pluginmanager "github.com/docker/cli/cli-plugins/manager" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" "github.com/docker/cli/cli/debug" flagsHelper "github.com/docker/cli/cli/flags" @@ -81,7 +80,7 @@ func newInfoCommand(dockerCLI command.Cli) *cobra.Command { "category-top": "12", "aliases": "docker system info, docker info", }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } cmd.Flags().StringVarP(&opts.format, "format", "f", "", flagsHelper.InspectFormatHelp) diff --git a/cli/command/system/inspect.go b/cli/command/system/inspect.go index aa34169b9f3d..ef79831cd9af 100644 --- a/cli/command/system/inspect.go +++ b/cli/command/system/inspect.go @@ -82,7 +82,7 @@ func newInspectCommand(dockerCLI command.Cli) *cobra.Command { return runInspect(cmd.Context(), dockerCLI, opts) }, // TODO(thaJeztah): should we consider adding completion for common object-types? (images, containers?) - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() @@ -95,7 +95,7 @@ func newInspectCommand(dockerCLI command.Cli) *cobra.Command { // Set a default completion function if none was set. We don't look // up if it does already have one set, because Cobra does this for // us, and returns an error (which we ignore for this reason). - _ = cmd.RegisterFlagCompletionFunc(flag.Name, completion.NoComplete) + _ = cmd.RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions) }) return cmd } diff --git a/cli/command/system/prune.go b/cli/command/system/prune.go index a1bcb5f2241b..a5ddde4a4a0e 100644 --- a/cli/command/system/prune.go +++ b/cli/command/system/prune.go @@ -10,7 +10,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" "github.com/docker/cli/cli/command/builder" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/container" "github.com/docker/cli/cli/command/image" "github.com/docker/cli/cli/command/network" @@ -45,7 +44,7 @@ func newPruneCommand(dockerCli command.Cli) *cobra.Command { return runPrune(cmd.Context(), dockerCli, options) }, Annotations: map[string]string{"version": "1.25"}, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/system/version.go b/cli/command/system/version.go index a1839ff64135..3cf8683d81ca 100644 --- a/cli/command/system/version.go +++ b/cli/command/system/version.go @@ -10,7 +10,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" "github.com/docker/cli/cli/command/formatter/tabwriter" flagsHelper "github.com/docker/cli/cli/flags" @@ -129,7 +128,7 @@ func newVersionCommand(dockerCLI command.Cli) *cobra.Command { Annotations: map[string]string{ "category-top": "10", }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } cmd.Flags().StringVarP(&opts.format, "format", "f", "", flagsHelper.InspectFormatHelp) diff --git a/cli/command/volume/create.go b/cli/command/volume/create.go index 8c13f65a74eb..06679f75c566 100644 --- a/cli/command/volume/create.go +++ b/cli/command/volume/create.go @@ -9,7 +9,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/opts" "github.com/docker/docker/api/types/volume" "github.com/spf13/cobra" @@ -59,7 +58,7 @@ func newCreateCommand(dockerCli command.Cli) *cobra.Command { options.cluster = hasClusterVolumeOptionSet(cmd.Flags()) return runCreate(cmd.Context(), dockerCli, options) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() flags.StringVarP(&options.driver, "driver", "d", "local", "Specify volume driver name") diff --git a/cli/command/volume/list.go b/cli/command/volume/list.go index 297c90b7c987..4286da5b7561 100644 --- a/cli/command/volume/list.go +++ b/cli/command/volume/list.go @@ -6,7 +6,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/cli/command/formatter" flagsHelper "github.com/docker/cli/cli/flags" "github.com/docker/cli/opts" @@ -37,7 +36,7 @@ func newListCommand(dockerCli command.Cli) *cobra.Command { RunE: func(cmd *cobra.Command, args []string) error { return runList(cmd.Context(), dockerCli, options) }, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags() diff --git a/cli/command/volume/prune.go b/cli/command/volume/prune.go index 1f90292d94a6..d8e1aa7508bc 100644 --- a/cli/command/volume/prune.go +++ b/cli/command/volume/prune.go @@ -7,7 +7,6 @@ import ( "github.com/docker/cli/cli" "github.com/docker/cli/cli/command" - "github.com/docker/cli/cli/command/completion" "github.com/docker/cli/internal/prompt" "github.com/docker/cli/opts" "github.com/docker/docker/api/types/versions" @@ -48,7 +47,7 @@ func newPruneCommand(dockerCLI command.Cli) *cobra.Command { return nil }, Annotations: map[string]string{"version": "1.25"}, - ValidArgsFunction: completion.NoComplete, + ValidArgsFunction: cobra.NoFileCompletions, } flags := cmd.Flags()