diff --git a/CHANGELOG.md b/CHANGELOG.md index 035e04b..717ee1c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,9 @@ All notable changes to the Docker Language Server will be documented in this fil ### Fixed +- Dockerfile + - textDocument/hover + - ignore 4XX errors when hovering over images with a non-standard tag ([#371](https://github.com/docker/docker-language-server/issues/371)) - Compose - textDocument/documentLink - stop returning links for alias nodes in included paths ([#439](https://github.com/docker/docker-language-server/issues/439)) diff --git a/internal/scout/languageGatewayClient.go b/internal/scout/languageGatewayClient.go index 98afa3b..674e9a3 100644 --- a/internal/scout/languageGatewayClient.go +++ b/internal/scout/languageGatewayClient.go @@ -67,9 +67,11 @@ func (c LanguageGatewayClientImpl) PostImage(ctx context.Context, jwt, image str } defer func() { _ = res.Body.Close() }() - if res.StatusCode != 200 { + if res.StatusCode >= 500 { err := fmt.Errorf("http request failed (%v status code)", res.StatusCode) return ImageResponse{}, err + } else if res.StatusCode >= 400 { + return ImageResponse{}, nil } var imageResponse ImageResponse diff --git a/internal/scout/languageGatewayClient_test.go b/internal/scout/languageGatewayClient_test.go index 61617f8..6f456a3 100644 --- a/internal/scout/languageGatewayClient_test.go +++ b/internal/scout/languageGatewayClient_test.go @@ -17,8 +17,9 @@ func TestPostImage(t *testing.T) { response ImageResponse }{ { + // this triggers a 400 which is ignored image: "alpine:3.16.1::", - err: errors.New("http request failed (400 status code)"), + err: nil, }, { image: "alpine:3.16.1", diff --git a/internal/scout/service.go b/internal/scout/service.go index 9f9bf0d..f2be6d1 100644 --- a/internal/scout/service.go +++ b/internal/scout/service.go @@ -59,6 +59,7 @@ func (s *ServiceImpl) Hover(ctx context.Context, documentURI protocol.DocumentUr }, }, nil } + return nil, nil } return nil, err }