From 79aac2f53a8f74a5fc7e07d7e82d2b7f5351002a Mon Sep 17 00:00:00 2001 From: Alessandro Lensi Date: Wed, 21 Jan 2015 12:16:56 +0100 Subject: [PATCH 1/3] Update Dockerfile This way should be faster, since we are not going to compile node every time :) --- Dockerfile | 32 ++++++++++++++++++-------------- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/Dockerfile b/Dockerfile index a37154a..5347c63 100644 --- a/Dockerfile +++ b/Dockerfile @@ -4,26 +4,30 @@ # https://github.com/dockerfile/nodejs # +#MAINTAINER Fernando Mayo , Feng Honglin + # Pull base image. -FROM dockerfile/python +FROM dockerfile/ubuntu + +# Select the version you want to use +# e.g.: latest, unstable, 0.11.12, 0.10.2, .. +ENV nodeVersion latest + +#Suppress debian frontend errors +ENV DEBIAN_FRONTEND noninteractive -# Install Node.js RUN \ - cd /tmp && \ - wget http://nodejs.org/dist/node-latest.tar.gz && \ - tar xvzf node-latest.tar.gz && \ - rm -f node-latest.tar.gz && \ - cd node-v* && \ - ./configure && \ - CXX="g++ -Wno-unused-local-typedefs" make && \ - CXX="g++ -Wno-unused-local-typedefs" make install && \ - cd /tmp && \ - rm -rf /tmp/node-v* && \ - npm install -g npm && \ + apt-get update && \ + apt-get install -y npm && \ + ln -sf /usr/bin/nodejs /usr/local/bin/node && \ + apt-get install -y curl && \ + rm -rf /var/lib/apt/lists/* && \ + npm install -g n && \ + n ${nodeVersion} && \ echo -e '\n# Node.js\nexport PATH="node_modules/.bin:$PATH"' >> /root/.bashrc # Define working directory. WORKDIR /data # Define default command. -CMD ["bash"] +CMD ["node", "-v"] From e5a80e703bea505bedc4a3580f0984726cad0155 Mon Sep 17 00:00:00 2001 From: Alessandro Lensi Date: Wed, 21 Jan 2015 12:38:56 +0100 Subject: [PATCH 2/3] Update Dockerfile removed MAINTAINER which was copy-pasted from another dockerfile (should be reintroduced with correct values) removed -e in echo since seems to create problems --- Dockerfile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Dockerfile b/Dockerfile index 5347c63..f78cca8 100644 --- a/Dockerfile +++ b/Dockerfile @@ -4,8 +4,6 @@ # https://github.com/dockerfile/nodejs # -#MAINTAINER Fernando Mayo , Feng Honglin - # Pull base image. FROM dockerfile/ubuntu @@ -24,7 +22,7 @@ RUN \ rm -rf /var/lib/apt/lists/* && \ npm install -g n && \ n ${nodeVersion} && \ - echo -e '\n# Node.js\nexport PATH="node_modules/.bin:$PATH"' >> /root/.bashrc + echo '\n# Node.js\nexport PATH="node_modules/.bin:$PATH"' >> /root/.bashrc # Define working directory. WORKDIR /data From 6476d28978926fa14710b827ed6b915ef317cd2b Mon Sep 17 00:00:00 2001 From: Alessandro Lensi Date: Wed, 21 Jan 2015 17:15:54 +0100 Subject: [PATCH 3/3] Update README.md Modified BaseDockerImage --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 9bfea57..2906625 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ This repository contains **Dockerfile** of [Node.js](http://nodejs.org/) for [Do ### Base Docker Image -* [dockerfile/python](http://dockerfile.github.io/#/python) +* [dockerfile/ubuntu](http://dockerfile.github.io/#/ubuntu) ### Installation