From 92c9ec16f8770b334078957cd03e01de71a20384 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Mon, 25 Mar 2019 22:23:30 +0100 Subject: [PATCH] Make phpdoc comments accurate This fixes the phpstan job of the build. Refs #255 --- lib/Doctrine/Annotations/DocParser.php | 3 --- lib/Doctrine/Annotations/Metadata/AnnotationMetadata.php | 3 --- .../Metadata/Builder/PropertyMetadataBuilder.php | 4 ++-- lib/Doctrine/Annotations/Metadata/PropertyMetadata.php | 6 +++--- 4 files changed, 5 insertions(+), 11 deletions(-) diff --git a/lib/Doctrine/Annotations/DocParser.php b/lib/Doctrine/Annotations/DocParser.php index 49affa6a8..dc7804b81 100644 --- a/lib/Doctrine/Annotations/DocParser.php +++ b/lib/Doctrine/Annotations/DocParser.php @@ -493,9 +493,6 @@ private function collectAnnotationMetadata($name) /** * Collects parsing metadata for a given attribute. - * - * @param array $metadata - * @param Attribute $attribute */ private function collectAttributeTypeMetadata( PropertyMetadataBuilder $metadata, diff --git a/lib/Doctrine/Annotations/Metadata/AnnotationMetadata.php b/lib/Doctrine/Annotations/Metadata/AnnotationMetadata.php index ceae9f8bf..3c1c16a22 100644 --- a/lib/Doctrine/Annotations/Metadata/AnnotationMetadata.php +++ b/lib/Doctrine/Annotations/Metadata/AnnotationMetadata.php @@ -32,9 +32,6 @@ final class AnnotationMetadata /** @var PropertyMetadata|null */ private $defaultProperty; - /** - * @param PropertyMetadata[] $properties - */ public function __construct( string $name, AnnotationTarget $target, diff --git a/lib/Doctrine/Annotations/Metadata/Builder/PropertyMetadataBuilder.php b/lib/Doctrine/Annotations/Metadata/Builder/PropertyMetadataBuilder.php index a0df6c6ec..b237ad571 100644 --- a/lib/Doctrine/Annotations/Metadata/Builder/PropertyMetadataBuilder.php +++ b/lib/Doctrine/Annotations/Metadata/Builder/PropertyMetadataBuilder.php @@ -23,7 +23,7 @@ final class PropertyMetadataBuilder /** @var bool */ private $default = false; - /** @var array|null */ + /** @var array|string>|null */ private $enum; public function __construct(string $name) @@ -56,7 +56,7 @@ public function withBeingDefault() : self } /** - * @param array|null $enum + * @param array|string> $enum */ public function withEnum(array $enum) : self { diff --git a/lib/Doctrine/Annotations/Metadata/PropertyMetadata.php b/lib/Doctrine/Annotations/Metadata/PropertyMetadata.php index c17023151..90259766c 100644 --- a/lib/Doctrine/Annotations/Metadata/PropertyMetadata.php +++ b/lib/Doctrine/Annotations/Metadata/PropertyMetadata.php @@ -22,12 +22,12 @@ final class PropertyMetadata /** @var bool */ private $default; - /** @var array|null */ + /** @var array|string>|null */ private $enum; /** * @param array $type - * @param array|null $enum + * @param array|string>|null $enum */ public function __construct( string $name, @@ -67,7 +67,7 @@ public function isDefault() : bool } /** - * @return array|null + * @return array|string>|null */ public function getEnum() : ?array {