From 41d11763e586a58ea7a47fc7cfae8a8f01d95756 Mon Sep 17 00:00:00 2001 From: Tom Dykstra Date: Tue, 22 Nov 2022 12:37:38 -0800 Subject: [PATCH 1/8] draft --- aspnetcore/diagnostics/asp0015.md | 32 +++++++++++++++++++++++++ aspnetcore/diagnostics/asp0016.md | 32 +++++++++++++++++++++++++ aspnetcore/diagnostics/asp0017.md | 32 +++++++++++++++++++++++++ aspnetcore/diagnostics/asp0018.md | 32 +++++++++++++++++++++++++ aspnetcore/diagnostics/asp0019.md | 32 +++++++++++++++++++++++++ aspnetcore/diagnostics/code-analysis.md | 7 +++++- 6 files changed, 166 insertions(+), 1 deletion(-) create mode 100644 aspnetcore/diagnostics/asp0015.md create mode 100644 aspnetcore/diagnostics/asp0016.md create mode 100644 aspnetcore/diagnostics/asp0017.md create mode 100644 aspnetcore/diagnostics/asp0018.md create mode 100644 aspnetcore/diagnostics/asp0019.md diff --git a/aspnetcore/diagnostics/asp0015.md b/aspnetcore/diagnostics/asp0015.md new file mode 100644 index 000000000000..149fd68ce36b --- /dev/null +++ b/aspnetcore/diagnostics/asp0015.md @@ -0,0 +1,32 @@ +--- +title: "ASP0015: Suggest using IHeaderDictionary properties" +description: "Learn about analysis rule ASP0015: Suggest using IHeaderDictionary properties" +author: tdykstra +monikerRange: '>= aspnetcore-7.0' +ms.author: tdykstra +ms.date: 11/22/2022 +uid: diagnostics/asp0015 +--- +# ASP0015: Suggest using IHeaderDictionary properties + +| | Value | +|-|-| +| **Rule ID** |ASP0015| +| **Category** |Usage| +| **Fix is breaking or non-breaking** |Non-breaking| + +## Cause + +`IHeaderDictionary` is the recommended strategy for accessing headers. + +## Rule description + +`IHeaderDictionary` is the recommended strategy for accessing headers. + +## How to fix violations + +To fix a violation of this rule, use the property specified in the analyzer message to access the header specified in the message. + +## When to suppress warnings + +Do ***not*** suppress a warning from this rule. diff --git a/aspnetcore/diagnostics/asp0016.md b/aspnetcore/diagnostics/asp0016.md new file mode 100644 index 000000000000..931ad5c3abeb --- /dev/null +++ b/aspnetcore/diagnostics/asp0016.md @@ -0,0 +1,32 @@ +--- +title: "ASP0016: Do not return a value from RequestDelegate" +description: "Learn about analysis rule ASP0016: Do not return a value from RequestDelegate" +author: tdykstra +monikerRange: '>= aspnetcore-7.0' +ms.author: tdykstra +ms.date: 11/22/2022 +uid: diagnostics/asp0016 +--- +# ASP0016: Do not return a value from RequestDelegate + +| | Value | +|-|-| +| **Rule ID** |ASP0016| +| **Category** |Usage| +| **Fix is breaking or non-breaking** |Non-breaking| + +## Cause + +The method used to create a `RequestDelegate` returns `Task`. `RequestDelegate` discards this value. + +## Rule description + +Do not return a value from `RequestDelegate`. + +## How to fix violations + +To fix a violation of this rule, change the return type to non-generic `Task` or, if the delegate is a route handler, cast it to `Delegate` so the return value is written to the response. + +## When to suppress warnings + +Suppress a warning from this rule if the intention is for `RequestDelegate` to discard the `Task` value. diff --git a/aspnetcore/diagnostics/asp0017.md b/aspnetcore/diagnostics/asp0017.md new file mode 100644 index 000000000000..f93b38a595aa --- /dev/null +++ b/aspnetcore/diagnostics/asp0017.md @@ -0,0 +1,32 @@ +--- +title: "ASP0017: Invalid route pattern" +description: "Learn about analysis rule ASP0017: Invalid route pattern" +author: tdykstra +monikerRange: '>= aspnetcore-7.0' +ms.author: tdykstra +ms.date: 11/22/2022 +uid: diagnostics/asp0017 +--- +# ASP0017: Invalid route pattern + +| | Value | +|-|-| +| **Rule ID** |ASP0017| +| **Category** |Usage| +| **Fix is breaking or non-breaking** |Non-breaking| + +## Cause + +The route pattern is invalid. + +## Rule description + +The route pattern is invalid. + +## How to fix violations + +To fix a violation of this rule, correct the error identified in the analyzer message. + +## When to suppress warnings + +Do ***not*** suppress a warning from this rule. diff --git a/aspnetcore/diagnostics/asp0018.md b/aspnetcore/diagnostics/asp0018.md new file mode 100644 index 000000000000..b85fd75f732e --- /dev/null +++ b/aspnetcore/diagnostics/asp0018.md @@ -0,0 +1,32 @@ +--- +title: "ASP0018: Unused route parameter" +description: "Learn about analysis rule ASP0018: Unused route parameter" +author: tdykstra +monikerRange: '>= aspnetcore-7.0' +ms.author: tdykstra +ms.date: 11/22/2022 +uid: diagnostics/asp0018 +--- +# ASP0018: Unused route parameter + +| | Value | +|-|-| +| **Rule ID** |ASP0018| +| **Category** |Usage| +| **Fix is breaking or non-breaking** |Non-breaking| + +## Cause + +A route parameter is specified but not used. + +## Rule description + +A route parameter is specified but not used. + +## How to fix violations + +To fix a violation of this rule, remove the route parameter or add code that uses the parameter. + +## When to suppress warnings + +Do ***not*** suppress a warning from this rule. diff --git a/aspnetcore/diagnostics/asp0019.md b/aspnetcore/diagnostics/asp0019.md new file mode 100644 index 000000000000..ab39f2fc12b3 --- /dev/null +++ b/aspnetcore/diagnostics/asp0019.md @@ -0,0 +1,32 @@ +--- +title: "asp0019: Suggest using IHeaderDictionary.Append or the indexer" +description: "Learn about analysis rule asp0019: Suggest using IHeaderDictionary.Append or the indexer" +author: tdykstra +monikerRange: '>= aspnetcore-7.0' +ms.author: tdykstra +ms.date: 11/22/2022 +uid: diagnostics/asp0019 +--- +# asp0019: Suggest using IHeaderDictionary.Append or the indexer + +| | Value | +|-|-| +| **Rule ID** |asp0019| +| **Category** |Usage| +| **Fix is breaking or non-breaking** |Non-breaking| + +## Cause + +`IDictionary.Add` isn't recommended for setting or appending headers. + +## Rule description + +`IDictionary.Add` isn't recommended for setting or appending headers. `IDictionary.Add` will throw an `ArgumentException` when attempting to add a duplicate key. + +## How to fix violations + +To fix a violation of this rule, use `IHeaderDictionary.Append` or the indexer to append or set headers. + +## When to suppress warnings + +Do ***not*** suppress a warning from this rule. diff --git a/aspnetcore/diagnostics/code-analysis.md b/aspnetcore/diagnostics/code-analysis.md index 7b25368f0f7e..466aca623e20 100644 --- a/aspnetcore/diagnostics/code-analysis.md +++ b/aspnetcore/diagnostics/code-analysis.md @@ -4,7 +4,7 @@ author: rick-anderson description: Learn about source code analysis in ASP.NET Core monikerRange: '>= aspnetcore-3.1' ms.author: riande -ms.date: 12/17/2021 +ms.date: 11/22/2022 uid: diagnostics/code-analysis --- # Code analysis in ASP.NET Core apps @@ -27,6 +27,11 @@ uid: diagnostics/code-analysis | [ASP0012](xref:diagnostics/asp0012) | Non-breaking | Suggest using builder.Services over Host.ConfigureServices or WebHost.ConfigureServices | | [ASP0013](xref:diagnostics/asp0013) | Non-breaking | Suggest switching from using Configure methods to WebApplicationBuilder.Configuration | | [ASP0014](xref:diagnostics/asp0014) | Non-breaking | Suggest using top level route registrations | +| [ASP0015](xref:diagnostics/asp0015) | Non-breaking | Suggest using IHeaderDictionary properties | +| [ASP0016](xref:diagnostics/asp0016) | Non-breaking | Do not return a value from RequestDelegate | +| [ASP0017](xref:diagnostics/asp0017) | Non-breaking | Invalid route pattern | +| [ASP0018](xref:diagnostics/asp0018) | Non-breaking | Unused route parameter | +| [ASP0019](xref:diagnostics/asp0019) | Non-breaking | Suggest using IHeaderDictionary.Append or the indexer | | [BL0001](xref:diagnostics/bl0001) | Breaking | Component parameter should have public setters | | [BL0002](xref:diagnostics/bl0002) | Non-breaking | Component has multiple CaptureUnmatchedValues parameters | | [BL0003](xref:diagnostics/bl0003) | Breaking | Component parameter with CaptureUnmatchedValues has the wrong type | From 1973ad60c26f581f65aff1c092c606044768256b Mon Sep 17 00:00:00 2001 From: Tom Dykstra Date: Tue, 22 Nov 2022 17:08:00 -0800 Subject: [PATCH 2/8] draft --- aspnetcore/diagnostics/asp0015.md | 6 +++--- aspnetcore/diagnostics/asp0016.md | 4 ++-- aspnetcore/diagnostics/asp0017.md | 6 +++--- aspnetcore/diagnostics/asp0018.md | 2 +- aspnetcore/diagnostics/asp0019.md | 6 +++--- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/aspnetcore/diagnostics/asp0015.md b/aspnetcore/diagnostics/asp0015.md index 149fd68ce36b..ba262503772d 100644 --- a/aspnetcore/diagnostics/asp0015.md +++ b/aspnetcore/diagnostics/asp0015.md @@ -17,11 +17,11 @@ uid: diagnostics/asp0015 ## Cause -`IHeaderDictionary` is the recommended strategy for accessing headers. +`IHeaderDictionary` properties are the recommended strategy for accessing headers. ## Rule description -`IHeaderDictionary` is the recommended strategy for accessing headers. +`IHeaderDictionary` properties are the recommended strategy for accessing headers. ## How to fix violations @@ -29,4 +29,4 @@ To fix a violation of this rule, use the property specified in the analyzer mess ## When to suppress warnings -Do ***not*** suppress a warning from this rule. +Do not suppress a warning from this rule. diff --git a/aspnetcore/diagnostics/asp0016.md b/aspnetcore/diagnostics/asp0016.md index 931ad5c3abeb..8c794c7b40c0 100644 --- a/aspnetcore/diagnostics/asp0016.md +++ b/aspnetcore/diagnostics/asp0016.md @@ -17,7 +17,7 @@ uid: diagnostics/asp0016 ## Cause -The method used to create a `RequestDelegate` returns `Task`. `RequestDelegate` discards this value. +A method used to create a `RequestDelegate` returns `Task`. `RequestDelegate` discards this value. ## Rule description @@ -29,4 +29,4 @@ To fix a violation of this rule, change the return type to non-generic `Task` or ## When to suppress warnings -Suppress a warning from this rule if the intention is for `RequestDelegate` to discard the `Task` value. +Do not suppress a warning from this rule. diff --git a/aspnetcore/diagnostics/asp0017.md b/aspnetcore/diagnostics/asp0017.md index f93b38a595aa..f514bac1f761 100644 --- a/aspnetcore/diagnostics/asp0017.md +++ b/aspnetcore/diagnostics/asp0017.md @@ -17,11 +17,11 @@ uid: diagnostics/asp0017 ## Cause -The route pattern is invalid. +A route pattern is invalid. ## Rule description -The route pattern is invalid. +A route pattern is invalid. ## How to fix violations @@ -29,4 +29,4 @@ To fix a violation of this rule, correct the error identified in the analyzer me ## When to suppress warnings -Do ***not*** suppress a warning from this rule. +Do not suppress a warning from this rule. diff --git a/aspnetcore/diagnostics/asp0018.md b/aspnetcore/diagnostics/asp0018.md index b85fd75f732e..9f62126b6ebf 100644 --- a/aspnetcore/diagnostics/asp0018.md +++ b/aspnetcore/diagnostics/asp0018.md @@ -29,4 +29,4 @@ To fix a violation of this rule, remove the route parameter or add code that use ## When to suppress warnings -Do ***not*** suppress a warning from this rule. +Do not suppress a warning from this rule. diff --git a/aspnetcore/diagnostics/asp0019.md b/aspnetcore/diagnostics/asp0019.md index ab39f2fc12b3..05c3311039ff 100644 --- a/aspnetcore/diagnostics/asp0019.md +++ b/aspnetcore/diagnostics/asp0019.md @@ -17,11 +17,11 @@ uid: diagnostics/asp0019 ## Cause -`IDictionary.Add` isn't recommended for setting or appending headers. +`IDictionary.Add` isn't recommended for setting or appending headers. `IDictionary.Add` will throw an `ArgumentException` when attempting to add a duplicate key. ## Rule description -`IDictionary.Add` isn't recommended for setting or appending headers. `IDictionary.Add` will throw an `ArgumentException` when attempting to add a duplicate key. +`IDictionary.Add` isn't recommended for setting or appending headers. ## How to fix violations @@ -29,4 +29,4 @@ To fix a violation of this rule, use `IHeaderDictionary.Append` or the indexer t ## When to suppress warnings -Do ***not*** suppress a warning from this rule. +Do not suppress a warning from this rule. From 656f2c1734ec237285bbf88ab2f4f2a0d64f026f Mon Sep 17 00:00:00 2001 From: Tom Dykstra Date: Tue, 22 Nov 2022 17:24:31 -0800 Subject: [PATCH 3/8] add to toc --- aspnetcore/toc.yml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/aspnetcore/toc.yml b/aspnetcore/toc.yml index 4a73bf2a64be..da6c1d7d92bf 100644 --- a/aspnetcore/toc.yml +++ b/aspnetcore/toc.yml @@ -974,6 +974,30 @@ items: uid: diagnostics/asp0006 - name: ASP0007 uid: diagnostics/asp0007 + - name: ASP0008 + uid: diagnostics/asp0008 + - name: ASP0009 + uid: diagnostics/asp0009 + - name: ASP0010 + uid: diagnostics/asp0010 + - name: ASP0011 + uid: diagnostics/asp0011 + - name: ASP0012 + uid: diagnostics/asp0012 + - name: ASP0013 + uid: diagnostics/asp0013 + - name: ASP0014 + uid: diagnostics/asp0014 + - name: ASP0015 + uid: diagnostics/asp0015 + - name: ASP0016 + uid: diagnostics/asp0016 + - name: ASP0017 + uid: diagnostics/asp0017 + - name: ASP0018 + uid: diagnostics/asp0018 + - name: ASP0019 + uid: diagnostics/asp0019 - name: BL0001 uid: diagnostics/bl0001 - name: BL0002 From 82f36f6620595fa5674760139195ab563005fd5a Mon Sep 17 00:00:00 2001 From: Tom Dykstra Date: Tue, 22 Nov 2022 17:34:29 -0800 Subject: [PATCH 4/8] fix capitalization --- aspnetcore/diagnostics/asp0019.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/aspnetcore/diagnostics/asp0019.md b/aspnetcore/diagnostics/asp0019.md index 05c3311039ff..609822c8d6ce 100644 --- a/aspnetcore/diagnostics/asp0019.md +++ b/aspnetcore/diagnostics/asp0019.md @@ -1,17 +1,17 @@ --- -title: "asp0019: Suggest using IHeaderDictionary.Append or the indexer" -description: "Learn about analysis rule asp0019: Suggest using IHeaderDictionary.Append or the indexer" +title: "ASP0019: Suggest using IHeaderDictionary.Append or the indexer" +description: "Learn about analysis rule ASP0019: Suggest using IHeaderDictionary.Append or the indexer" author: tdykstra monikerRange: '>= aspnetcore-7.0' ms.author: tdykstra ms.date: 11/22/2022 -uid: diagnostics/asp0019 +uid: diagnostics/ASP0019 --- -# asp0019: Suggest using IHeaderDictionary.Append or the indexer +# ASP0019: Suggest using IHeaderDictionary.Append or the indexer | | Value | |-|-| -| **Rule ID** |asp0019| +| **Rule ID** |ASP0019| | **Category** |Usage| | **Fix is breaking or non-breaking** |Non-breaking| From 190812fe4bfcb10dafccee250b680f57392596f2 Mon Sep 17 00:00:00 2001 From: Tom Dykstra Date: Tue, 22 Nov 2022 17:52:07 -0800 Subject: [PATCH 5/8] fix capitalization --- aspnetcore/diagnostics/asp0019.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aspnetcore/diagnostics/asp0019.md b/aspnetcore/diagnostics/asp0019.md index 609822c8d6ce..8e499f355c8d 100644 --- a/aspnetcore/diagnostics/asp0019.md +++ b/aspnetcore/diagnostics/asp0019.md @@ -5,7 +5,7 @@ author: tdykstra monikerRange: '>= aspnetcore-7.0' ms.author: tdykstra ms.date: 11/22/2022 -uid: diagnostics/ASP0019 +uid: diagnostics/asp0019 --- # ASP0019: Suggest using IHeaderDictionary.Append or the indexer From 7c65a612d5d188a798d464b71016ff141caeec16 Mon Sep 17 00:00:00 2001 From: Tom Dykstra Date: Wed, 23 Nov 2022 08:48:19 -0800 Subject: [PATCH 6/8] Apply suggestions from code review Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com> --- aspnetcore/diagnostics/asp0015.md | 4 ++-- aspnetcore/diagnostics/asp0016.md | 2 +- aspnetcore/diagnostics/asp0019.md | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/aspnetcore/diagnostics/asp0015.md b/aspnetcore/diagnostics/asp0015.md index ba262503772d..3df5292e839b 100644 --- a/aspnetcore/diagnostics/asp0015.md +++ b/aspnetcore/diagnostics/asp0015.md @@ -17,11 +17,11 @@ uid: diagnostics/asp0015 ## Cause -`IHeaderDictionary` properties are the recommended strategy for accessing headers. +[IHeaderDictionary](xref:System.Collections.IDictionary) properties are the recommended strategy for accessing headers. ## Rule description -`IHeaderDictionary` properties are the recommended strategy for accessing headers. +`IHeaderDictionary` properties are recommended for accessing headers. ## How to fix violations diff --git a/aspnetcore/diagnostics/asp0016.md b/aspnetcore/diagnostics/asp0016.md index 8c794c7b40c0..ba439937e542 100644 --- a/aspnetcore/diagnostics/asp0016.md +++ b/aspnetcore/diagnostics/asp0016.md @@ -17,7 +17,7 @@ uid: diagnostics/asp0016 ## Cause -A method used to create a `RequestDelegate` returns `Task`. `RequestDelegate` discards this value. +A method used to create a returns `Task`. `RequestDelegate` discards this value. ## Rule description diff --git a/aspnetcore/diagnostics/asp0019.md b/aspnetcore/diagnostics/asp0019.md index 8e499f355c8d..d72e44432642 100644 --- a/aspnetcore/diagnostics/asp0019.md +++ b/aspnetcore/diagnostics/asp0019.md @@ -17,7 +17,7 @@ uid: diagnostics/asp0019 ## Cause -`IDictionary.Add` isn't recommended for setting or appending headers. `IDictionary.Add` will throw an `ArgumentException` when attempting to add a duplicate key. +`IDictionary.Add` isn't recommended for setting or appending headers. [`IDictionary.Add`](xref:System.Collections.IDictionary.Add%2A) throws an `ArgumentException` when attempting to add a duplicate key. ## Rule description From 1a3f0a9e12ab28c015e112c74fd1cd4ed62fb1e3 Mon Sep 17 00:00:00 2001 From: Tom Dykstra Date: Wed, 23 Nov 2022 13:01:06 -0800 Subject: [PATCH 7/8] Apply suggestions from code review Co-authored-by: Safia Abdalla --- aspnetcore/diagnostics/asp0015.md | 18 ++++++++++++++++-- aspnetcore/diagnostics/asp0016.md | 13 ++++++++++++- aspnetcore/diagnostics/asp0017.md | 8 +++++++- aspnetcore/diagnostics/asp0018.md | 8 +++++++- 4 files changed, 42 insertions(+), 5 deletions(-) diff --git a/aspnetcore/diagnostics/asp0015.md b/aspnetcore/diagnostics/asp0015.md index 3df5292e839b..4028415a00ee 100644 --- a/aspnetcore/diagnostics/asp0015.md +++ b/aspnetcore/diagnostics/asp0015.md @@ -21,11 +21,25 @@ uid: diagnostics/asp0015 ## Rule description -`IHeaderDictionary` properties are recommended for accessing headers. +`IHeaderDictionary` properties are recommended for accessing headers. Accessing headers using an indexer as in the example below is not recommended. + +```csharp +var app = WebApplication.Create(); + +app.MapGet("/", (HttpContext context) => context.Request.Headers[""content-type""]); + +app.Run(); +``` ## How to fix violations -To fix a violation of this rule, use the property specified in the analyzer message to access the header specified in the message. +To fix a violation of this rule, use the property specified in the analyzer message to access the header specified in the message or apply the associated codefix. + +```csharp +var app = WebApplication.Create(); +app.MapGet("/", (HttpContext context) => context.Request.Headers.ContentType); +app.Run(); +``` ## When to suppress warnings diff --git a/aspnetcore/diagnostics/asp0016.md b/aspnetcore/diagnostics/asp0016.md index ba439937e542..d4de46a05db4 100644 --- a/aspnetcore/diagnostics/asp0016.md +++ b/aspnetcore/diagnostics/asp0016.md @@ -21,7 +21,18 @@ A method used to create a retur ## Rule description -Do not return a value from `RequestDelegate`. +Do not return a value `Delegate`s provided to APIs that expect `RequestDelegate`. For example, the following sample returns a `Task` where the `string` value of the `Task` will be discarded. + +```csharp +var app = WebApplication.Create(); +app.Use(next => +{ + return new RequestDelegate((HttpContext context) => + { + return Task.FromResult(""hello world""); + }); +}); +``` ## How to fix violations diff --git a/aspnetcore/diagnostics/asp0017.md b/aspnetcore/diagnostics/asp0017.md index f514bac1f761..e231000fdabf 100644 --- a/aspnetcore/diagnostics/asp0017.md +++ b/aspnetcore/diagnostics/asp0017.md @@ -21,7 +21,13 @@ A route pattern is invalid. ## Rule description -A route pattern is invalid. +This diagnostic is emitted when a route pattern is invalid. In the example below, the route pattern contains an invalid token. + +```csharp +var app = WebApplication.Create(); + +app.MapGet("/{id", (int id) => ...); +``` ## How to fix violations diff --git a/aspnetcore/diagnostics/asp0018.md b/aspnetcore/diagnostics/asp0018.md index 9f62126b6ebf..0d644e10c54e 100644 --- a/aspnetcore/diagnostics/asp0018.md +++ b/aspnetcore/diagnostics/asp0018.md @@ -21,7 +21,13 @@ A route parameter is specified but not used. ## Rule description -A route parameter is specified but not used. +A route parameter is specified but not used. In the example below, the `name` parameter is defined in the route but not in the route handler. + +```csharp +var app = WebApplication.Create(); + +app.MapGet("/{id}", () => ...); +``` ## How to fix violations From d5982fb2b40b03e46e3176b15ee8c6b3ccf972f9 Mon Sep 17 00:00:00 2001 From: Tom Dykstra Date: Wed, 23 Nov 2022 16:09:41 -0800 Subject: [PATCH 8/8] update moniker range --- aspnetcore/diagnostics/asp0015.md | 4 ++-- aspnetcore/diagnostics/asp0016.md | 2 +- aspnetcore/diagnostics/asp0017.md | 2 +- aspnetcore/diagnostics/asp0018.md | 2 +- aspnetcore/diagnostics/asp0019.md | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/aspnetcore/diagnostics/asp0015.md b/aspnetcore/diagnostics/asp0015.md index 4028415a00ee..5d15e522e6cb 100644 --- a/aspnetcore/diagnostics/asp0015.md +++ b/aspnetcore/diagnostics/asp0015.md @@ -2,9 +2,9 @@ title: "ASP0015: Suggest using IHeaderDictionary properties" description: "Learn about analysis rule ASP0015: Suggest using IHeaderDictionary properties" author: tdykstra -monikerRange: '>= aspnetcore-7.0' +monikerRange: '>= aspnetcore-8.0' ms.author: tdykstra -ms.date: 11/22/2022 +ms.date: 11/23/2022 uid: diagnostics/asp0015 --- # ASP0015: Suggest using IHeaderDictionary properties diff --git a/aspnetcore/diagnostics/asp0016.md b/aspnetcore/diagnostics/asp0016.md index d4de46a05db4..30d9f47d4715 100644 --- a/aspnetcore/diagnostics/asp0016.md +++ b/aspnetcore/diagnostics/asp0016.md @@ -2,7 +2,7 @@ title: "ASP0016: Do not return a value from RequestDelegate" description: "Learn about analysis rule ASP0016: Do not return a value from RequestDelegate" author: tdykstra -monikerRange: '>= aspnetcore-7.0' +monikerRange: '>= aspnetcore-8.0' ms.author: tdykstra ms.date: 11/22/2022 uid: diagnostics/asp0016 diff --git a/aspnetcore/diagnostics/asp0017.md b/aspnetcore/diagnostics/asp0017.md index e231000fdabf..147e4fbecbfd 100644 --- a/aspnetcore/diagnostics/asp0017.md +++ b/aspnetcore/diagnostics/asp0017.md @@ -2,7 +2,7 @@ title: "ASP0017: Invalid route pattern" description: "Learn about analysis rule ASP0017: Invalid route pattern" author: tdykstra -monikerRange: '>= aspnetcore-7.0' +monikerRange: '>= aspnetcore-8.0' ms.author: tdykstra ms.date: 11/22/2022 uid: diagnostics/asp0017 diff --git a/aspnetcore/diagnostics/asp0018.md b/aspnetcore/diagnostics/asp0018.md index 0d644e10c54e..471bb9a50147 100644 --- a/aspnetcore/diagnostics/asp0018.md +++ b/aspnetcore/diagnostics/asp0018.md @@ -2,7 +2,7 @@ title: "ASP0018: Unused route parameter" description: "Learn about analysis rule ASP0018: Unused route parameter" author: tdykstra -monikerRange: '>= aspnetcore-7.0' +monikerRange: '>= aspnetcore-8.0' ms.author: tdykstra ms.date: 11/22/2022 uid: diagnostics/asp0018 diff --git a/aspnetcore/diagnostics/asp0019.md b/aspnetcore/diagnostics/asp0019.md index d72e44432642..f4e03c28ad82 100644 --- a/aspnetcore/diagnostics/asp0019.md +++ b/aspnetcore/diagnostics/asp0019.md @@ -2,7 +2,7 @@ title: "ASP0019: Suggest using IHeaderDictionary.Append or the indexer" description: "Learn about analysis rule ASP0019: Suggest using IHeaderDictionary.Append or the indexer" author: tdykstra -monikerRange: '>= aspnetcore-7.0' +monikerRange: '>= aspnetcore-8.0' ms.author: tdykstra ms.date: 11/22/2022 uid: diagnostics/asp0019