From 98f5389f8250fd8d80ee8d21aa6a649c5a5e3888 Mon Sep 17 00:00:00 2001 From: jrahnama Date: Wed, 5 Jun 2024 06:38:39 -0700 Subject: [PATCH 1/2] Add Targetgramework to obj folder path --- src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props | 2 +- .../netcore/src/Microsoft.Data.SqlClient.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props b/src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props index 4ec39ed694..4bafa69046 100644 --- a/src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props +++ b/src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props @@ -11,7 +11,7 @@ Project $(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb true - $([System.IO.Path]::Combine('$(IntermediateOutputPath)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)')) + $([System.IO.Path]::Combine('$(IntermediateOutputPath)/$(TargetFramework)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)')) diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj index 2cd3537ea7..63513b4034 100644 --- a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj @@ -20,7 +20,7 @@ $(NoWarn);IL2026;IL2057;IL2072;IL2075 - $([System.IO.Path]::Combine('$(IntermediateOutputPath)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)')) + $([System.IO.Path]::Combine('$(IntermediateOutputPath)/$(TargetFramework)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)')) From cd9bed180b8cb74ae04c871db55bdb6aed729292 Mon Sep 17 00:00:00 2001 From: Javad Rahnama Date: Wed, 5 Jun 2024 09:54:59 -0700 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: campersau --- src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props | 2 +- .../netcore/src/Microsoft.Data.SqlClient.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props b/src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props index 4bafa69046..d0bf4f7757 100644 --- a/src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props +++ b/src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props @@ -11,7 +11,7 @@ Project $(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb true - $([System.IO.Path]::Combine('$(IntermediateOutputPath)/$(TargetFramework)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)')) + $([System.IO.Path]::Combine('$(IntermediateOutputPath)','$(TargetFramework)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)')) diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj index 63513b4034..7cf0b1e619 100644 --- a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj @@ -20,7 +20,7 @@ $(NoWarn);IL2026;IL2057;IL2072;IL2075 - $([System.IO.Path]::Combine('$(IntermediateOutputPath)/$(TargetFramework)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)')) + $([System.IO.Path]::Combine('$(IntermediateOutputPath)','$(TargetFramework)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)'))