From 541300e58dded5fc4e49666922166dfd7b5ed453 Mon Sep 17 00:00:00 2001
From: Paul Medynski <31868385+paulmedynski@users.noreply.github.com>
Date: Mon, 9 Jun 2025 06:29:01 -0300
Subject: [PATCH 1/3] User Story 37675: Fix Wave Analysis issues
- Updated .NET to explicitly use System.Text.Json 8.0.5 or 9.0.5 to avoid transitive vulnerabilities.
- Sorted PackageReference entries alphabetically by package name.
- Updated test tools to use Microsoft.SqlServer.SqlManagementObjects 172.76.0 to avoid transitive vulnerabilities.
- Updated .NET Framework project to build on Linux.
---
.../ref/Microsoft.Data.SqlClient.csproj | 11 ++++---
.../src/Microsoft.Data.SqlClient.csproj | 18 +++++-----
.../netfx/ref/Microsoft.Data.SqlClient.csproj | 12 +++----
.../netfx/src/Microsoft.Data.SqlClient.csproj | 33 +++++++------------
...tadataFactory.cs => SqlMetaDataFactory.cs} | 0
...crosoft.Data.SqlClient.ExtUtilities.csproj | 1 +
tools/specs/Microsoft.Data.SqlClient.nuspec | 3 ++
7 files changed, 38 insertions(+), 40 deletions(-)
rename src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/{SqlMetadataFactory.cs => SqlMetaDataFactory.cs} (100%)
diff --git a/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj
index 8da5503146..60eff24c1c 100644
--- a/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj
+++ b/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj
@@ -32,15 +32,18 @@
+
+
-
-
-
+
+
-
+
+
+
diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
index e05ea74f8b..00fee9bef7 100644
--- a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
+++ b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
@@ -663,8 +663,8 @@
Microsoft\Data\SqlClient\SqlInternalTransaction.cs
-
- Microsoft\Data\SqlClient\SqlMetadataFactory.cs
+
+ Microsoft\Data\SqlClient\SqlMetaDataFactory.cs
Microsoft\Data\SqlClient\SqlNotificationEventArgs.cs
@@ -1036,18 +1036,20 @@
+
+
-
-
-
-
-
+
+
-
+
+
+
+
diff --git a/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj
index 8a52093f11..6b507b5a0a 100644
--- a/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj
+++ b/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj
@@ -32,20 +32,20 @@
-
-
+
+
All
runtime; build; native; contentfiles; analyzers; buildtransitive
-
-
+
+
-
-
+
+
diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
index ba5bd6b3d3..d439386b1f 100644
--- a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
+++ b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
@@ -1,4 +1,4 @@
-
+
{407890AC-9876-4FEF-A6F1-F36A876BAADE}
@@ -12,9 +12,6 @@
$(OutputPath)\Microsoft.Data.SqlClient.xml
$(ObjPath)$(AssemblyName)\netfx\
Framework $(BaseProduct)
-
- True
false
false
@@ -61,7 +58,10 @@
True
True
None
- MinimumRecommendedRules.ruleset
+
+
+ MinimumRecommendedRules.ruleset
+
True
True
$(DefineConstants);USEOFFSET;CODE_ANALYSIS_BASELINE;FEATURE_LEGACYSURFACEAREA;FEATURE_UTF32;FEATURE_UTF7;TRACE;
@@ -951,7 +951,7 @@
-
+
@@ -1000,29 +1000,18 @@
-
- {5477469E-83B1-11D2-8B49-00A0C9B7C9C4}
- 2
- 4
- 0
- tlbimp
- False
- True
-
-
-
-
-
+
+
All
runtime; build; native; contentfiles; analyzers; buildtransitive
-
-
-
+
+
+
diff --git a/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlMetadataFactory.cs b/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlMetaDataFactory.cs
similarity index 100%
rename from src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlMetadataFactory.cs
rename to src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlMetaDataFactory.cs
diff --git a/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj b/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj
index a49eef85b1..dd31f7531e 100644
--- a/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj
+++ b/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj
@@ -6,6 +6,7 @@
+
diff --git a/tools/specs/Microsoft.Data.SqlClient.nuspec b/tools/specs/Microsoft.Data.SqlClient.nuspec
index 803d13bc91..0f029b4c19 100644
--- a/tools/specs/Microsoft.Data.SqlClient.nuspec
+++ b/tools/specs/Microsoft.Data.SqlClient.nuspec
@@ -51,6 +51,7 @@
+
@@ -62,6 +63,7 @@
+
@@ -73,6 +75,7 @@
+
From df89296b1fb4c1c4c45092509005373f6d44e232 Mon Sep 17 00:00:00 2001
From: Paul Medynski <31868385+paulmedynski@users.noreply.github.com>
Date: Tue, 10 Jun 2025 11:54:52 -0300
Subject: [PATCH 2/3] User Story 37675: Fix Wave Analysis issues
- Added System.Text.Json 9.0.5 to .NET 9.0.
- Fixed System.Formats.Asn1 transitive vulnerability.
---
src/Directory.Packages.props | 13 +++++++------
.../tests/Directory.Packages.props | 14 +++++++++++++-
.../Microsoft.Data.SqlClient.ExtUtilities.csproj | 7 +++++++
3 files changed, 27 insertions(+), 7 deletions(-)
diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props
index 4fff27edae..7d94425123 100644
--- a/src/Directory.Packages.props
+++ b/src/Directory.Packages.props
@@ -8,9 +8,8 @@
-
-
+
@@ -54,15 +53,17 @@
-
-
+
+
+
-
-
+
+
+
diff --git a/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props b/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props
index e470bb6dee..db17cb1e48 100644
--- a/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props
+++ b/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props
@@ -1,9 +1,21 @@
-
+
+
+
+
+
+
+
+
+
+
diff --git a/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj b/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj
index dd31f7531e..cd3ffeb61f 100644
--- a/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj
+++ b/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj
@@ -7,6 +7,13 @@
+
+
+
+
From e82dd8bf2a5b96abd2cfcd98403092dea5d954c9 Mon Sep 17 00:00:00 2001
From: Paul Medynski <31868385+paulmedynski@users.noreply.github.com>
Date: Tue, 10 Jun 2025 11:59:04 -0300
Subject: [PATCH 3/3] User Story 37675: Fix Wave Analysis issues
- Removed unnecessary PackageReference Version attributes.
---
.../netcore/src/Microsoft.Data.SqlClient.csproj | 2 +-
.../netfx/src/Microsoft.Data.SqlClient.csproj | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
index 00fee9bef7..71fde92ffc 100644
--- a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
+++ b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
@@ -1047,7 +1047,7 @@
-
+
diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
index d439386b1f..b301449186 100644
--- a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
+++ b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
@@ -1000,8 +1000,8 @@
-
-
+
+
All
runtime; build; native; contentfiles; analyzers; buildtransitive