From 3c3b293eba59ecffee01f7a5ef0354a2b96aa7b2 Mon Sep 17 00:00:00 2001 From: Daniel Cazzulino Date: Tue, 4 Jun 2019 12:31:12 -0300 Subject: [PATCH 1/4] Code that runs in VS needs to target net472 in dev16+ This makes it fully compatible with NS2. Otherwise, an SDK targeting pack needs to be installed and a whole bunch of facade assemblies are included as part of the build which aren't needed and can cause issues when running inside the IDE. --- .../Xamarin.Android.Tools.AndroidSdk.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj b/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj index a71b39b..929d948 100644 --- a/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj +++ b/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj @@ -7,7 +7,7 @@ Library Xamarin.Android.Tools Xamarin.Android.Tools.AndroidSdk - v4.7.1 + v4.7.2 8.0.30703 2.0 true From 5cc45e6a3818aae6ecd1516f5823290e29030b2a Mon Sep 17 00:00:00 2001 From: Daniel Cazzulino Date: Tue, 4 Jun 2019 13:02:29 -0300 Subject: [PATCH 2/4] Code that runs in VS needs to target net472 in dev16+ --- .../Tests/Xamarin.Android.Tools.AndroidSdk-Tests.csproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Xamarin.Android.Tools.AndroidSdk/Tests/Xamarin.Android.Tools.AndroidSdk-Tests.csproj b/src/Xamarin.Android.Tools.AndroidSdk/Tests/Xamarin.Android.Tools.AndroidSdk-Tests.csproj index 5bef2b2..4a4b7e9 100644 --- a/src/Xamarin.Android.Tools.AndroidSdk/Tests/Xamarin.Android.Tools.AndroidSdk-Tests.csproj +++ b/src/Xamarin.Android.Tools.AndroidSdk/Tests/Xamarin.Android.Tools.AndroidSdk-Tests.csproj @@ -11,7 +11,7 @@ Properties Xamarin.Android.Tools.Tests Xamarin.Android.Tools.AndroidSdk-Tests - v4.7.1 + v4.7.2 512 @@ -68,4 +68,4 @@ - \ No newline at end of file + From da1cd30fb904cb8306f7e90e6e62c5cfd7874c7e Mon Sep 17 00:00:00 2001 From: Daniel Cazzulino Date: Tue, 4 Jun 2019 13:41:14 -0300 Subject: [PATCH 3/4] Downgrade to net46 which is compatible with VS Under VS2017+, code must either target net46 or net472 and nothing in between. Otherwise, run-time errors might happen if the wrong assemblies (facades for NS2 support) are inadvertently bound at compile time and loaded at run-time. --- .../Xamarin.Android.Tools.AndroidSdk.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj b/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj index 929d948..cec95b3 100644 --- a/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj +++ b/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj @@ -7,7 +7,7 @@ Library Xamarin.Android.Tools Xamarin.Android.Tools.AndroidSdk - v4.7.2 + v4.6 8.0.30703 2.0 true From 835fb772ea69a48b13f84416a720ffce4b068c6b Mon Sep 17 00:00:00 2001 From: Daniel Cazzulino Date: Tue, 4 Jun 2019 13:41:36 -0300 Subject: [PATCH 4/4] Downgrade to net46 --- .../Tests/Xamarin.Android.Tools.AndroidSdk-Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Xamarin.Android.Tools.AndroidSdk/Tests/Xamarin.Android.Tools.AndroidSdk-Tests.csproj b/src/Xamarin.Android.Tools.AndroidSdk/Tests/Xamarin.Android.Tools.AndroidSdk-Tests.csproj index 4a4b7e9..58d66d2 100644 --- a/src/Xamarin.Android.Tools.AndroidSdk/Tests/Xamarin.Android.Tools.AndroidSdk-Tests.csproj +++ b/src/Xamarin.Android.Tools.AndroidSdk/Tests/Xamarin.Android.Tools.AndroidSdk-Tests.csproj @@ -11,7 +11,7 @@ Properties Xamarin.Android.Tools.Tests Xamarin.Android.Tools.AndroidSdk-Tests - v4.7.2 + v4.6 512