diff --git a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.Application.targets b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.Application.targets index b28e987017f..c3bd094ab59 100644 --- a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.Application.targets +++ b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.Application.targets @@ -14,11 +14,11 @@ This file contains targets specific for Android application projects. - <_RunDependsOn Condition=" '$(_XASupportsFastDev)' == 'true' "> + <_RunDependsOn Condition=" '$(_AndroidFastDeploymentSupported)' == 'true' "> Install; _Run; - <_RunDependsOn Condition=" '$(_XASupportsFastDev)' != 'true' "> + <_RunDependsOn Condition=" '$(_AndroidFastDeploymentSupported)' != 'true' "> Install; StartAndroidActivity; diff --git a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.BuildOrder.targets b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.BuildOrder.targets index 01f6959aed2..039bc54f78a 100644 --- a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.BuildOrder.targets +++ b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.BuildOrder.targets @@ -125,11 +125,11 @@ properties that determine build ordering. $(_MinimalSignAndroidPackageDependsOn); - + $(_MinimalSignAndroidPackageDependsOn); _Upload; - + $(_MinimalSignAndroidPackageDependsOn); _DeployApk; _DeployAppBundle; diff --git a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets index 09c1e4f87b3..d6a904396ac 100644 --- a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets +++ b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets @@ -17,6 +17,9 @@ false false false + <_AndroidFastDeploymentSupported Condition=" Exists ('$(MSBuildThisFileDirectory)../tools/Xamarin.Android.Common.Debugging.targets') ">true + <_AndroidFastDeploymentSupported Condition=" '$(_AndroidFastDeploymentSupported)' == '' ">False + <_XAMajorVersionNumber>1 - <_XASupportsFastDev Condition=" Exists ('$(MSBuildThisFileDirectory)Xamarin.Android.Common.Debugging.targets') ">True - <_XASupportsFastDev Condition=" '$(_XASupportsFastDev)' == '' ">False $(UseInterpreter) False false @@ -165,8 +163,8 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved. MonoAndroid v$(_XAMajorVersionNumber).0 True - False - True + False + True True False False diff --git a/tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs b/tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs index 90f8258ccf4..b0a1594b404 100644 --- a/tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs +++ b/tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs @@ -68,6 +68,17 @@ public void DeployToDevice (bool isRelease) Assert.IsTrue (dotnet.Build (), "`dotnet build` should succeed"); Assert.IsTrue (dotnet.Build ("DeployToDevice"), "`dotnet build -t:DeployToDevice` should succeed"); + // Verify correct targets ran based on FastDev support + if (TestEnvironment.CommercialBuildAvailable) { + dotnet.AssertTargetIsNotSkipped ("_Upload"); + dotnet.AssertTargetIsSkipped ("_DeployApk", defaultIfNotUsed: true); + dotnet.AssertTargetIsSkipped ("_DeployAppBundle", defaultIfNotUsed: true); + } else { + dotnet.AssertTargetIsSkipped ("_Upload", defaultIfNotUsed: true); + dotnet.AssertTargetIsNotSkipped ("_DeployApk"); + dotnet.AssertTargetIsNotSkipped ("_DeployAppBundle"); + } + // Launch the app using adb ClearAdbLogcat (); var result = AdbStartActivity ($"{proj.PackageName}/{proj.JavaPackageName}.MainActivity");