From f1db04abdbda053fc4c4f93e32585e7db0f1380e Mon Sep 17 00:00:00 2001 From: Thays Date: Wed, 30 Jun 2021 17:42:37 -0300 Subject: [PATCH 1/2] Componentize the debugger, only link debugger when it's a debug app. --- .../targets/Microsoft.Android.Sdk.AssemblyResolution.targets | 1 + .../targets/Microsoft.Android.Sdk.DefaultProperties.targets | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.AssemblyResolution.targets b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.AssemblyResolution.targets index 8df3a12fa3a..24396286d03 100644 --- a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.AssemblyResolution.targets +++ b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.AssemblyResolution.targets @@ -178,6 +178,7 @@ _ResolveAssemblies MSBuild target. <_MonoComponent Condition=" '$(AndroidEnableProfiler)' == 'true' " Include="diagnostics_tracing" /> <_MonoComponent Condition=" '$(AndroidUseInterpreter)' == 'true' " Include="hot_reload" /> + <_MonoComponent Condition=" '$(AndroidEnableDebugger)' == 'true' " Include="debugger" /> + true None + false true true From 187ccd2b0e0e31cb08716b9ddc9bf73de243647b Mon Sep 17 00:00:00 2001 From: Thays Date: Wed, 30 Jun 2021 18:12:36 -0300 Subject: [PATCH 2/2] Reusing AndroidIncludeDebugSymbols --- .../targets/Microsoft.Android.Sdk.AssemblyResolution.targets | 2 +- .../targets/Microsoft.Android.Sdk.DefaultProperties.targets | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.AssemblyResolution.targets b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.AssemblyResolution.targets index 24396286d03..ad39e5f3823 100644 --- a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.AssemblyResolution.targets +++ b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.AssemblyResolution.targets @@ -178,7 +178,7 @@ _ResolveAssemblies MSBuild target. <_MonoComponent Condition=" '$(AndroidEnableProfiler)' == 'true' " Include="diagnostics_tracing" /> <_MonoComponent Condition=" '$(AndroidUseInterpreter)' == 'true' " Include="hot_reload" /> - <_MonoComponent Condition=" '$(AndroidEnableDebugger)' == 'true' " Include="debugger" /> + <_MonoComponent Condition=" '$(AndroidIncludeDebugSymbols)' == 'true' " Include="debugger" /> - true None - false true true