From f982615b161344376a2d9a2ee24632d8f801ab31 Mon Sep 17 00:00:00 2001 From: Jonathan Peppers Date: Wed, 24 Aug 2022 09:22:54 -0500 Subject: [PATCH] [tests] disable `$(_FastDeploymentDiagnosticLogging)` in PerformanceTest Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6595850&view=ms.vss-test-web.build-test-results-tab&runId=51752272&resultId=100026&paneView=debug Frequently `Install_CSharp_Change` fails with: Exceeded expected time of 4500ms, actual 4671.203ms Reviewing the `.binlog` the `` task shows up: Top 10 most expensive tasks GenerateJavaStubs = 1.304 s _GenerateJavaStubs = 1.304 s FastDeploy = 498 ms _Upload = 498 ms `` is logging "lots of stuff" due to `$(_FastDeploymentDiagnosticLogging)`: FastDeploy Parameters DiagnosticLogging = True ... // Hundreds of lines of: xamarin.find: Ignoring line 'DEBUG: ./UnnamedProject.dll size:1661286176390 mtime:6144 tv_sec:1661286176 tv_nsec:390000'. Line is incorrectly formatted. This was added in 7b51fd1b, to help debug other issues. Let's turn off this setting on `PerformanceTest`, as we're looking to measure how fast build & deploy is. Less log messages should help. --- tests/MSBuildDeviceIntegration/Tests/PerformanceTest.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/MSBuildDeviceIntegration/Tests/PerformanceTest.cs b/tests/MSBuildDeviceIntegration/Tests/PerformanceTest.cs index c3712c86869..4c4dea9ead0 100644 --- a/tests/MSBuildDeviceIntegration/Tests/PerformanceTest.cs +++ b/tests/MSBuildDeviceIntegration/Tests/PerformanceTest.cs @@ -93,6 +93,7 @@ XamarinAndroidApplicationProject CreateApplicationProject () var proj = new XamarinAndroidApplicationProject () { }; proj.SetAndroidSupportedAbis (DeviceAbi); // Use a single ABI + proj.SetProperty ("_FastDeploymentDiagnosticLogging", "False"); return proj; }