From 9e4ecce4f761d0869c1658c5a0676880524a2394 Mon Sep 17 00:00:00 2001 From: Dean Ellis Date: Wed, 1 Nov 2017 14:56:12 +0000 Subject: [PATCH] [Xamarin.Android.Build.Tasks] Handle lint.bat not returning version info. Turns out lint.bat does not always return a version number. It returns stuff like lint: version unknown lint: unknown version not very helpful. So we need to handle that case and return a empty verison. --- src/Xamarin.Android.Build.Tasks/Tasks/Lint.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Xamarin.Android.Build.Tasks/Tasks/Lint.cs b/src/Xamarin.Android.Build.Tasks/Tasks/Lint.cs index 548b81999b4..9a95ac139f6 100644 --- a/src/Xamarin.Android.Build.Tasks/Tasks/Lint.cs +++ b/src/Xamarin.Android.Build.Tasks/Tasks/Lint.cs @@ -326,11 +326,11 @@ Version GetLintVersion (string tool) sb.AppendLine (e.Data); } ); - if (result != 0) { + var versionInfo = sb.ToString (); + if (result != 0 || versionInfo.Contains ("unknown")) { Log.LogWarning ($"Could not get version from '{tool}'"); return new Version (); } - var versionInfo = sb.ToString (); // lint: version 26.0.2 var versionNumberMatch = lintVersionRegex.Match (versionInfo); Version versionNumber;