From bbccadc51b9afbd2cbd47cb88695bd4e0b053ea0 Mon Sep 17 00:00:00 2001
From: Alireza Baloochi <dev.alirezabaloochi@gmail.com>
Date: Tue, 13 May 2025 17:57:40 +0330
Subject: [PATCH] API review: WithHostPort should accept null for port param

---
 src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs         | 2 +-
 src/Aspire.Hosting.SqlServer/SqlServerBuilderExtensions.cs | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs b/src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs
index 60e1d65fe98..e6b71478e3f 100644
--- a/src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs
+++ b/src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs
@@ -433,7 +433,7 @@ public static IResourceBuilder<RedisResource> WithPassword(this IResourceBuilder
     /// <param name="builder">The resource builder.</param>
     /// <param name="port">The port to bind on the host. If <see langword="null"/> is used random port will be assigned.</param>
     /// <returns>The <see cref="IResourceBuilder{T}"/>.</returns>
-    public static IResourceBuilder<RedisResource> WithHostPort(this IResourceBuilder<RedisResource> builder, int port)
+    public static IResourceBuilder<RedisResource> WithHostPort(this IResourceBuilder<RedisResource> builder, int? port)
     {
         ArgumentNullException.ThrowIfNull(builder);
         return builder.WithEndpoint(RedisResource.PrimaryEndpointName, endpoint =>
diff --git a/src/Aspire.Hosting.SqlServer/SqlServerBuilderExtensions.cs b/src/Aspire.Hosting.SqlServer/SqlServerBuilderExtensions.cs
index f7345700e7d..563511f9932 100644
--- a/src/Aspire.Hosting.SqlServer/SqlServerBuilderExtensions.cs
+++ b/src/Aspire.Hosting.SqlServer/SqlServerBuilderExtensions.cs
@@ -221,7 +221,7 @@ public static IResourceBuilder<SqlServerServerResource> WithPassword(this IResou
     /// <param name="builder">The resource builder.</param>
     /// <param name="port">The port to bind on the host. If <see langword="null"/> is used random port will be assigned.</param>
     /// <returns>The <see cref="IResourceBuilder{T}"/>.</returns>
-    public static IResourceBuilder<SqlServerServerResource> WithHostPort(this IResourceBuilder<SqlServerServerResource> builder, int port)
+    public static IResourceBuilder<SqlServerServerResource> WithHostPort(this IResourceBuilder<SqlServerServerResource> builder, int? port)
     {
         ArgumentNullException.ThrowIfNull(builder);
         return builder.WithEndpoint(SqlServerServerResource.PrimaryEndpointName, endpoint =>