From dc624d873922c7fb39db14f4b2afb201713a97f0 Mon Sep 17 00:00:00 2001 From: Sebastien Ros Date: Thu, 15 May 2025 12:04:59 -0700 Subject: [PATCH 1/2] Update telemetry doc for AzureAppConfiguration --- .../AspireAppConfigurationExtensions.cs | 2 +- src/Components/Telemetry.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/AspireAppConfigurationExtensions.cs b/src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/AspireAppConfigurationExtensions.cs index da292eaba69..fa34aa0bdca 100644 --- a/src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/AspireAppConfigurationExtensions.cs +++ b/src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/AspireAppConfigurationExtensions.cs @@ -66,7 +66,7 @@ public static void AddAzureAppConfiguration( { builder.Services.AddOpenTelemetry() .WithTracing(traceBuilder => - traceBuilder.AddSource(["Microsoft.Extensions.Configuration.AzureAppConfiguration"])); + traceBuilder.AddSource("Microsoft.Extensions.Configuration.AzureAppConfiguration")); } } } diff --git a/src/Components/Telemetry.md b/src/Components/Telemetry.md index f7b2106bdc3..3fe9e7777f0 100644 --- a/src/Components/Telemetry.md +++ b/src/Components/Telemetry.md @@ -194,7 +194,7 @@ Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration - Log categories: "Microsoft.Extensions.Configuration.AzureAppConfiguration.Refresh" - Activity source names: - - none + - "Microsoft.Extensions.Configuration.AzureAppConfiguration" - Metric names: - none From 5752a6231eff149070aaf0b0ee67fd11081f35a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Ros?= Date: Fri, 16 May 2025 11:57:15 -0700 Subject: [PATCH 2/2] Use constant --- .../AspireAppConfigurationExtensions.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/AspireAppConfigurationExtensions.cs b/src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/AspireAppConfigurationExtensions.cs index fa34aa0bdca..21942866bad 100644 --- a/src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/AspireAppConfigurationExtensions.cs +++ b/src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/AspireAppConfigurationExtensions.cs @@ -16,7 +16,8 @@ namespace Microsoft.Extensions.Hosting; public static class AspireAppConfigurationExtensions { internal const string DefaultConfigSectionName = "Aspire:Microsoft:Extensions:Configuration:AzureAppConfiguration"; - + internal const string ActivitySourceName = "Microsoft.Extensions.Configuration.AzureAppConfiguration"; + /// /// Adds the Azure App Configuration to be configuration in the . /// @@ -66,7 +67,7 @@ public static void AddAzureAppConfiguration( { builder.Services.AddOpenTelemetry() .WithTracing(traceBuilder => - traceBuilder.AddSource("Microsoft.Extensions.Configuration.AzureAppConfiguration")); + traceBuilder.AddSource(ActivitySourceName)); } } }