From 0d94eadcf0855ce6105c9f04926a66e9fc0d5e99 Mon Sep 17 00:00:00 2001 From: Safia Abdalla Date: Fri, 15 Jul 2022 18:57:32 +0000 Subject: [PATCH 1/2] Rename ConfigureRouteHandlerJsonOptions to ConfigureHttpJsonOptions --- src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs | 4 ++-- src/Http/Http.Extensions/src/PublicAPI.Unshipped.txt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs b/src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs index 75ceafdb0ac7..44bd166c96eb 100644 --- a/src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs +++ b/src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs @@ -8,7 +8,7 @@ namespace Microsoft.Extensions.DependencyInjection; /// /// Extension methods to configure JSON serialization behavior. /// -public static class RouteHandlerJsonServiceExtensions +public static class HttpJsonServiceExtensions { /// /// Configures options used for reading and writing JSON by route handlers. @@ -22,7 +22,7 @@ public static class RouteHandlerJsonServiceExtensions /// The to configure the /// . /// The modified . - public static IServiceCollection ConfigureRouteHandlerJsonOptions(this IServiceCollection services, Action configureOptions) + public static IServiceCollection ConfigureHttpJsonOptions(this IServiceCollection services, Action configureOptions) { services.Configure(configureOptions); return services; diff --git a/src/Http/Http.Extensions/src/PublicAPI.Unshipped.txt b/src/Http/Http.Extensions/src/PublicAPI.Unshipped.txt index 4a1707193af5..4b8eccfa6afb 100644 --- a/src/Http/Http.Extensions/src/PublicAPI.Unshipped.txt +++ b/src/Http/Http.Extensions/src/PublicAPI.Unshipped.txt @@ -56,14 +56,14 @@ Microsoft.AspNetCore.Http.RequestDelegateFactoryOptions.EndpointFilterFactories. Microsoft.AspNetCore.Http.RequestDelegateFactoryOptions.EndpointFilterFactories.init -> void Microsoft.AspNetCore.Http.RequestDelegateFactoryOptions.EndpointMetadata.get -> System.Collections.Generic.IList? Microsoft.AspNetCore.Http.RequestDelegateFactoryOptions.EndpointMetadata.init -> void -Microsoft.Extensions.DependencyInjection.RouteHandlerJsonServiceExtensions +Microsoft.Extensions.DependencyInjection.HttpJsonServiceExtensions static Microsoft.AspNetCore.Http.HttpRequestJsonExtensions.ReadFromJsonAsync(this Microsoft.AspNetCore.Http.HttpRequest! request, System.Type! type, System.Text.Json.Serialization.JsonSerializerContext! context, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask static Microsoft.AspNetCore.Http.HttpRequestJsonExtensions.ReadFromJsonAsync(this Microsoft.AspNetCore.Http.HttpRequest! request, System.Text.Json.Serialization.Metadata.JsonTypeInfo! jsonTypeInfo, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask static Microsoft.AspNetCore.Http.HttpResponseJsonExtensions.WriteAsJsonAsync(this Microsoft.AspNetCore.Http.HttpResponse! response, object? value, System.Type! type, System.Text.Json.Serialization.JsonSerializerContext! context, string? contentType = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task! static Microsoft.AspNetCore.Http.HttpResponseJsonExtensions.WriteAsJsonAsync(this Microsoft.AspNetCore.Http.HttpResponse! response, TValue value, System.Text.Json.Serialization.Metadata.JsonTypeInfo! jsonTypeInfo, string? contentType = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task! static Microsoft.Extensions.DependencyInjection.ProblemDetailsServiceCollectionExtensions.AddProblemDetails(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services) -> Microsoft.Extensions.DependencyInjection.IServiceCollection! static Microsoft.Extensions.DependencyInjection.ProblemDetailsServiceCollectionExtensions.AddProblemDetails(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services, System.Action? configure) -> Microsoft.Extensions.DependencyInjection.IServiceCollection! -static Microsoft.Extensions.DependencyInjection.RouteHandlerJsonServiceExtensions.ConfigureRouteHandlerJsonOptions(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services, System.Action! configureOptions) -> Microsoft.Extensions.DependencyInjection.IServiceCollection! +static Microsoft.Extensions.DependencyInjection.HttpJsonServiceExtensions.ConfigureHttpJsonOptions(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services, System.Action! configureOptions) -> Microsoft.Extensions.DependencyInjection.IServiceCollection! Microsoft.AspNetCore.Http.EndpointDescriptionAttribute Microsoft.AspNetCore.Http.EndpointDescriptionAttribute.EndpointDescriptionAttribute(string! description) -> void Microsoft.AspNetCore.Http.EndpointDescriptionAttribute.Description.get -> string! From 56693416dbe02c785bd46b9016b8e191ac65a189 Mon Sep 17 00:00:00 2001 From: Safia Abdalla Date: Tue, 19 Jul 2022 10:02:30 -0700 Subject: [PATCH 2/2] Update doc comment --- .../Http.Extensions/src/HttpJsonServiceExtensions.cs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs b/src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs index 44bd166c96eb..6a099c8307d3 100644 --- a/src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs +++ b/src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs @@ -11,13 +11,10 @@ namespace Microsoft.Extensions.DependencyInjection; public static class HttpJsonServiceExtensions { /// - /// Configures options used for reading and writing JSON by route handlers. - /// - /// - /// The options configured here will only affect JSON returned and processed - /// from route handlers, not controllers, when using + /// Configures options used for reading and writing JSON when using + /// /// and . - /// + /// /// The to configure options on. /// The to configure the /// .