From 5acedae1f9c3dba451b01033c00bc69765255f4f Mon Sep 17 00:00:00 2001 From: Mike Kistler Date: Mon, 6 Apr 2026 10:57:03 -0500 Subject: [PATCH 1/4] Clarify StatusCodePages ProblemDetails docs --- .../src/StatusCodePage/StatusCodePagesExtensions.cs | 6 ++++-- .../src/StatusCodePage/StatusCodePagesOptions.cs | 10 +++++++--- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs index b6d760efcdd4..dec0ffe8927f 100644 --- a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs +++ b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs @@ -33,8 +33,10 @@ public static IApplicationBuilder UseStatusCodePages(this IApplicationBuilder ap } /// - /// Adds a StatusCodePages middleware with a default response handler that checks for responses with status codes - /// between 400 and 599 that do not have a body. + /// Adds a with the default response handler. + /// The middleware checks for responses with status codes between 400 and 599 that do not have a body and, + /// when an is available, generates a + /// response. Otherwise, it generates a plain text response that includes the status code. /// /// /// diff --git a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesOptions.cs b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesOptions.cs index 9e91cbdef915..30d7078872b7 100644 --- a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesOptions.cs +++ b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesOptions.cs @@ -15,8 +15,10 @@ namespace Microsoft.AspNetCore.Builder; public class StatusCodePagesOptions { /// - /// Creates a default which produces a plaintext response - /// containing the status code and the reason phrase. + /// Creates a default whose handler attempts to generate a + /// response by using , and falls back + /// to a plaintext response containing the status code and reason phrase when that service is unavailable + /// or cannot write a response. /// public StatusCodePagesOptions() { @@ -52,7 +54,9 @@ private static string BuildResponseBody(int httpStatusCode) } /// - /// The handler that generates the response body for the given . By default this produces a plain text response that includes the status code. + /// The handler that generates the response body for the given . + /// By default this attempts to generate a response and falls back to a + /// plain text response that includes the status code. /// public Func HandleAsync { get; set; } From 4200e325156303e3119b21cfb80d58654e2b5e7a Mon Sep 17 00:00:00 2001 From: Mike Kistler Date: Mon, 13 Apr 2026 09:22:30 -0500 Subject: [PATCH 2/4] Address StatusCodePages doc review feedback Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../src/StatusCodePage/StatusCodePagesExtensions.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs index dec0ffe8927f..917e74c0d4fb 100644 --- a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs +++ b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs @@ -35,8 +35,9 @@ public static IApplicationBuilder UseStatusCodePages(this IApplicationBuilder ap /// /// Adds a with the default response handler. /// The middleware checks for responses with status codes between 400 and 599 that do not have a body and, - /// when an is available, generates a - /// response. Otherwise, it generates a plain text response that includes the status code. + /// when an is available, attempts to generate a + /// response. If the service is unavailable or cannot write the response, + /// it generates a plain text response that includes the status code. /// /// /// From a61a5467b0ed3351bac3f1e2cc84bd27e5407cd8 Mon Sep 17 00:00:00 2001 From: Mike Kistler Date: Mon, 13 Apr 2026 13:05:03 -0500 Subject: [PATCH 3/4] Fix StatusCodePages XML doc cref Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../src/StatusCodePage/StatusCodePagesExtensions.cs | 2 +- .../Diagnostics/src/StatusCodePage/StatusCodePagesOptions.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs index 917e74c0d4fb..14e3c206774c 100644 --- a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs +++ b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs @@ -36,7 +36,7 @@ public static IApplicationBuilder UseStatusCodePages(this IApplicationBuilder ap /// Adds a with the default response handler. /// The middleware checks for responses with status codes between 400 and 599 that do not have a body and, /// when an is available, attempts to generate a - /// response. If the service is unavailable or cannot write the response, + /// response. If the service is unavailable or cannot write the response, /// it generates a plain text response that includes the status code. /// /// diff --git a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesOptions.cs b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesOptions.cs index 30d7078872b7..a98bdd145488 100644 --- a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesOptions.cs +++ b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesOptions.cs @@ -16,7 +16,7 @@ public class StatusCodePagesOptions { /// /// Creates a default whose handler attempts to generate a - /// response by using , and falls back + /// response by using , and falls back /// to a plaintext response containing the status code and reason phrase when that service is unavailable /// or cannot write a response. /// @@ -55,7 +55,7 @@ private static string BuildResponseBody(int httpStatusCode) /// /// The handler that generates the response body for the given . - /// By default this attempts to generate a response and falls back to a + /// By default this attempts to generate a response and falls back to a /// plain text response that includes the status code. /// public Func HandleAsync { get; set; } From e85bab17e0b20bea94787bb52fd3d6c6dbb39cc4 Mon Sep 17 00:00:00 2001 From: Mike Kistler Date: Wed, 15 Apr 2026 19:09:26 -0500 Subject: [PATCH 4/4] Clarify StatusCodePages docs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../src/StatusCodePage/StatusCodePagesExtensions.cs | 3 +++ .../src/StatusCodePage/StatusCodePagesOptions.cs | 7 ++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs index 14e3c206774c..be1fbc332a34 100644 --- a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs +++ b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesExtensions.cs @@ -20,6 +20,9 @@ public static class StatusCodePagesExtensions /// /// Adds a StatusCodePages middleware with the given options that checks for responses with status codes /// between 400 and 599 that do not have a body. + /// If uses its default value, it attempts to generate a + /// response using + /// and falls back to a plain text response that includes the status code. /// /// /// diff --git a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesOptions.cs b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesOptions.cs index a98bdd145488..0256e454d51e 100644 --- a/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesOptions.cs +++ b/src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesOptions.cs @@ -16,7 +16,7 @@ public class StatusCodePagesOptions { /// /// Creates a default whose handler attempts to generate a - /// response by using , and falls back + /// response using , and falls back /// to a plaintext response containing the status code and reason phrase when that service is unavailable /// or cannot write a response. /// @@ -55,8 +55,9 @@ private static string BuildResponseBody(int httpStatusCode) /// /// The handler that generates the response body for the given . - /// By default this attempts to generate a response and falls back to a - /// plain text response that includes the status code. + /// By default this attempts to generate a response + /// using and falls back to a plain text response that includes the + /// status code. /// public Func HandleAsync { get; set; }