Add new build.cmd/sh options for suppressing restore, NodeJS, setting target arch and OS name, and more#7137
Merged
Merged
Conversation
added 2 commits
January 30, 2019 10:10
… target arch and OS name, and more Add new command line parameters for working with the project: * `-NoBuild`, `-NoRestore` - these already existed, but users found it hard to discover this powershell syntax: '-build:$false' *` -Arch`/`--arch` - set the target CPU architecture to build. Defaults to x64 * `--os-name` - on non-Windows builds, manually specify if the build should target Alpine. generic Linux, or MacOS * Rename flags used to build specific project types. The pattern now is `--build-$(group)` or `--no-build-$(group)` (In PowerShell its `-Build$(Group)` or `-NoBuild$(Group). Example: -NoBuildJava Changes to build definitions: * Update the ci build definition to build all supported architectures * Support publishing multiple artifacts per job Other changes: * -NoBuild implies -NoRestore * Add new properties, `TargetArchitecture`, `TargetOsName`, and `TargetRuntimeIdentifier` * Replace usages of `SharedFxRid` with these new properties * To make `--no-build-nodejs` actually work, replaced Components.Browser.JS.csproj with Components.Browser.JS.npmproj * Fix errors when building for win-arm on a clean machine * Fix a few other project errors, like using the wrong syntax for DefaultItemExcludes, or using the wrong Platform value for x86
natemcmaster
requested review from
SteveSandersonMS,
Tratcher and
jkotalik
as code owners
natemcmaster
commented
Jan 30, 2019
added 4 commits
January 30, 2019 10:23
Eilon
added
the
area-infrastructure
dougbu
suggested changes
Jan 30, 2019
| [switch]$NoBuildNative, | ||
| [switch]$NoBuildNodeJS, | ||
| [switch]$NoBuildJava, | ||
| [switch]$NoBuildInstallers, |
Contributor
There was a problem hiding this comment.
Could we make the true and false cases mutually exclusive e.g. put $BuildManaged and $NoBuildManaged in a parameter group?
Contributor
Author
There was a problem hiding this comment.
I considered that, but then you wouldn't be able to mix a "yes" with a "no" flag, like -BuildManaged -NoBuildJava
Contributor
There was a problem hiding this comment.
I was thinking about smaller parameter groups e.g. one containing just $BuildManaged and $NoBuildManaged. But, this wasn't a show-stopper -- more a potential usability enhancement.
Contributor
Author
There was a problem hiding this comment.
I'd like to make it more usable too, but I don't see a good way to do that without specifying a lengthy list of valid combinations.. If there is a better way to tell powershell about mutually exclusive parameters, I'm all for it.
added 11 commits
January 30, 2019 21:54
Contributor
Author
|
All PR checks are passing now. |
dougbu
approved these changes
Jan 31, 2019
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Minor requests but overall looks great
Contributor
Author
|
Thanks @dougbu. Updated with a few minor tweaks. I'll merge once the PR check is green again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This almost completes work to convert this repo to build in Azure Pipelines. We're still blocked on either installing .NET 3.5 https://github.com/dotnet/core-eng/issues/5119 or getting a newer version of Wix (wixtoolset/issues#5523)
Add new command line parameters for working with the project:
-NoBuild,-NoRestore- these already existed, but users found it hard to discover this powershell syntax: '-build:$false'-Arch/--arch- set the target CPU architecture to build. Defaults to x64--os-name- on non-Windows builds, manually specify if the build should target Alpine. generic Linux, or MacOS--build-$(group)or--no-build-$(group)(In PowerShell its-Build$(Group)or `-NoBuild$(Group). Example: -NoBuildJavaChanges to build definitions:
Other changes:
-NoBuildimplies-NoRestoreTargetArchitecture,TargetOsName, andTargetRuntimeIdentifierSharedFxRidwith these new properties--no-build-nodejsactually work, replaced Components.Browser.JS.csproj with Components.Browser.JS.npmproj