From d86d37b7b2add99b51a4319a7584b060219cb431 Mon Sep 17 00:00:00 2001
From: Drew Scoggins <anscoggi@microsoft.com>
Date: Fri, 21 Apr 2017 09:32:51 -0700
Subject: [PATCH] Remove Benchview calls when not uploading

We did not have calls to measurement.py behind the LogToBenchview flag
and so when people would do local runs without the Benchview tooling
their runs would fail.  This should be fixed.  I also removed an out of
date comment.
---
 .../PackageFiles/PerfTesting.targets                         | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/Microsoft.DotNet.Build.Tasks/PackageFiles/PerfTesting.targets b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/PerfTesting.targets
index 4e154f96e4..a1a6838b41 100644
--- a/src/Microsoft.DotNet.Build.Tasks/PackageFiles/PerfTesting.targets
+++ b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/PerfTesting.targets
@@ -25,14 +25,13 @@
   </PropertyGroup>
   <ItemGroup>
     <PerfTestCommandLines Include="$(PerfTestCommand)" />
-    <!-- We use the 20* syntax as the XML file created starts with the year and 20xx will be good for a while -->
   </ItemGroup>
-  <ItemGroup Condition="'$(TargetOS)'=='Windows_NT'">
+  <ItemGroup Condition="'$(TargetOS)'=='Windows_NT' and '$(LogToBenchview)' == 'true'">
     <PerfTestCommandLines Include="if exist Perf-$(AssemblyName).xml (" />
     <PerfTestCommandLines Include="py $(BenchviewDir)\measurement.py xunit Perf-$(AssemblyName).xml --better desc --drop-first-value --append -o $(ProjectDir)measurement.json" />
     <PerfTestCommandLines Include=")" />
   </ItemGroup>
-  <ItemGroup Condition="'$(TargetOS)'=='Linux'">
+  <ItemGroup Condition="'$(TargetOS)'=='Linux' and '$(LogToBenchview)' == 'true'">
     <PerfTestCommandLines Include="if [ -a Perf-$(AssemblyName).xml ]" />
     <PerfTestCommandLines Include="then" />
     <PerfTestCommandLines Include="python3.5 $(BenchviewDir)\measurement.py xunit Perf-$(AssemblyName).xml --better desc --drop-first-value --append -o $(ProjectDir)measurement.json" />