From 5016cf1ee509365a1a9e9a21fcfebc70a0c4c18d Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Thu, 16 May 2019 14:30:03 -0700 Subject: [PATCH] Fix ListenerWithFilter test It's searching the output to ensure the id doesn't get written out, so it can't match other IDs that are written out. --- .../tests/XmlWriterTraceListenerTests.cs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/System.Diagnostics.TextWriterTraceListener/tests/XmlWriterTraceListenerTests.cs b/src/System.Diagnostics.TextWriterTraceListener/tests/XmlWriterTraceListenerTests.cs index e00f0830ba51..b88356802a09 100644 --- a/src/System.Diagnostics.TextWriterTraceListener/tests/XmlWriterTraceListenerTests.cs +++ b/src/System.Diagnostics.TextWriterTraceListener/tests/XmlWriterTraceListenerTests.cs @@ -103,15 +103,16 @@ public void Close_AfterXPathNavigatorTraced() [Fact] public void ListenerWithFilter() { - int processId; + // Ensure we use an arbitrary ID that doesn't match the process ID or thread ID. + int traceTransferId = 1; using (Process p = Process.GetCurrentProcess()) { - processId = p.Id; + while (traceTransferId == p.Id || traceTransferId == Environment.CurrentManagedThreadId) + { + traceTransferId++; + } } - // Ensure we use an arbitrary ID that doesn't match the process ID. - int traceTransferId = processId + 1; - string file = GetTestFilePath(); Guid guid = Guid.NewGuid(); using (var listener = new XmlWriterTraceListener(file))