From 16806441c116b05940e539eda8a637b0d2d43585 Mon Sep 17 00:00:00 2001 From: Maira Wenzel Date: Tue, 22 Oct 2019 12:48:29 -0700 Subject: [PATCH 1/7] Update default reviewers --- .github/CODEOWNERS | 109 +++++++++++++++++++++++++++++++++++---------- 1 file changed, 85 insertions(+), 24 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 94c90a5bdce51..3d904d590701d 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -14,16 +14,21 @@ # . .NET Core sections are next # . .NET Framework sections # . .NET Standard -# . samples +# . Architecture e-books # In each subsection folders are order first by depth, then alphabetically. # This should make it easy to add new rules without breaking existing ones. - ############ GUIDES ################ # .NET Core /docs/core/** @mairaw +# .NET Framework +/docs/framework/** @mairaw + +# .NET Standard +/docs/standard/** @gewarren + # The C# Guide: /docs/csharp/** @BillWagner @@ -47,21 +52,47 @@ ############### .NET Core ######################## # What's New -/docs/core/whats-new/** @rpetrusha +/docs/core/whats-new/** @Thraka # Deployment -/docs/core/deploying/** @rpetrusha +/docs/core/deploying/** @Thraka # Breaking changes -/docs/core/compatibility/** @rpetrusha +/docs/core/compatibility/** @gewarren +# Tools +/docs/core/tools/** @tdykstra +# Tools - CLI ref +/docs/core/tools/dotnet-** @mairaw +# Tutorials +/docs/core/tools/dotnet-** @gewarren ################### .NET FRAMEWORK ################## -# .NET Framework migration guide -/docs/framework/migration-guide/** @rpetrusha -# .NET Framework Security +# App domains +/docs/framework/app-domains/** @gewarren +# Config - WinForms +/docs/framework/configure-apps/file-schema/winforms/** @Thraka +# Deployment +/docs/framework/deployment/** @Thraka +# Installation +/docs/framework/install/** @Thraka +# Migration guide +/docs/framework/migration-guide/** @gewarren +# Reflection +/docs/framework/reflection-and-codedom/** @Thraka +# Resources +/docs/framework/resources/** @Thraka +# Security /docs/framework/security/** @mairaw -# .NET Framework unmanaged API -/docs/framework/unmanaged-api/** @rpetrusha +# Tools +/docs/framework/tools/** @tdykstra +# UI Automation +/docs/framework/ui-automation/** @Thraka # What's New -/docs/framework/whats-new/** @rpetrusha +/docs/framework/whats-new/** @gewarren +# WPF +/docs/framework/wpf/** @Thraka +# Winforms +/docs/framework/winforms/** @Thraka +# XAML Services +/docs/framework/xaml-services/** @Thraka # ADO.NET /docs/framework/data/adonet/** @stevestein # NCL @@ -71,22 +102,52 @@ /docs/framework/configure-apps/file-schema/wcf/** @HongGit /docs/framework/data/wcf/** @HongGit /docs/framework/wcf/** @HongGit -# WPF -/docs/framework/wpf/** @Thraka -# Winforms -/docs/framework/winforms/** @Thraka ################## .NET STANDARD ################## -# Analyzers: -/docs/standard/analyzers/** @BillWagner +# Analyzers +/docs/standard/analyzers/** @mairaw +# Assembly +/docs/standard/assembly/** @gewarren +# Asynchronous Programming Patterns +/docs/standard/asynchronous-programming-patterns/** @gewarren +# Attributes +/docs/standard/attributes/** @tdykstra +# Base types +/docs/standard/base-types/** @Thraka +# Collections +/docs/standard/base-types/** @BillWagner +# Base types +/docs/standard/base-types/** @Thraka +# Data XML +/docs/standard/data-xml/** @gewarren +# Datetime +/docs/standard/datetime/** @Thraka +# Events +/docs/standard/exceptions/** @gewarren +# Exceptions +/docs/standard/exceptions/** @tdykstra +# GC +/docs/standard/garbage-collection/** @BillWagner +# Generics +/docs/standard/generics/** @Thraka +# Globalization +/docs/standard/globalization-localization/** @mairaw +# I/O +/docs/standard/io/** @Thraka +# LINQ +/docs/standard/linq/** @mairaw +# Memory and spans +/docs/standard/memory-and-spans/** @tdykstra +# Parallel programming +/docs/standard/parallel-programming/** @BillWagner +# Security +/docs/standard/security/** @gewarren +# Serialization +/docs/standard/Serialization/** @tdykstra +# Threading +/docs/standard/threading/** @BillWagner # What's New -/docs/standard/whats-new/** @rpetrusha -# .NET I/O -/docs/standard/io/** @mairaw -# .NET base types - Formatting -/docs/standard/base-types/formatting-types/** @rpetrusha -# .NET threading -/docs/standard/threading/** @rpetrusha +/docs/standard/whats-new/** @mairaw ################## E-BOOKS ################## # Blazor: From 37fb00a09c008db3d24bf5455a341570ef3aceb4 Mon Sep 17 00:00:00 2001 From: Maira Wenzel Date: Tue, 22 Oct 2019 12:52:17 -0700 Subject: [PATCH 2/7] add includes files folder --- .github/CODEOWNERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 3d904d590701d..340922c47165e 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -50,6 +50,9 @@ # The Desktop WPF Guide: /docs/desktop-wpf/** @Thraka +# Includes files +/includes/** @tdykstra + ############### .NET Core ######################## # What's New /docs/core/whats-new/** @Thraka From 677049df6edb0a40a4dc998aa1b52aefce6cbdaf Mon Sep 17 00:00:00 2001 From: Maira Wenzel Date: Tue, 22 Oct 2019 13:16:19 -0700 Subject: [PATCH 3/7] feedback --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 340922c47165e..63a581132f6f7 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -65,7 +65,7 @@ # Tools - CLI ref /docs/core/tools/dotnet-** @mairaw # Tutorials -/docs/core/tools/dotnet-** @gewarren +/docs/core/tutorials/** @tdykstra ################### .NET FRAMEWORK ################## # App domains From 5f6f5b1a99d83872952fe1c8fdf0603097bd8b6d Mon Sep 17 00:00:00 2001 From: Maira Wenzel Date: Tue, 22 Oct 2019 13:17:17 -0700 Subject: [PATCH 4/7] more feedback --- .github/CODEOWNERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 63a581132f6f7..53f5e41805338 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -90,10 +90,10 @@ /docs/framework/ui-automation/** @Thraka # What's New /docs/framework/whats-new/** @gewarren -# WPF -/docs/framework/wpf/** @Thraka # Winforms /docs/framework/winforms/** @Thraka +# WPF +/docs/framework/wpf/** @Thraka # XAML Services /docs/framework/xaml-services/** @Thraka # ADO.NET From d9c137240032fa2c70beb967286f981b560c9e3c Mon Sep 17 00:00:00 2001 From: Maira Wenzel Date: Tue, 22 Oct 2019 13:20:12 -0700 Subject: [PATCH 5/7] Apply suggestions from docs review Co-Authored-By: Genevieve Warren --- .github/CODEOWNERS | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 53f5e41805338..6d7468e738976 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -118,15 +118,15 @@ # Base types /docs/standard/base-types/** @Thraka # Collections -/docs/standard/base-types/** @BillWagner +/docs/standard/collections/** @BillWagner # Base types /docs/standard/base-types/** @Thraka -# Data XML -/docs/standard/data-xml/** @gewarren +# Data +/docs/standard/data/** @gewarren # Datetime /docs/standard/datetime/** @Thraka # Events -/docs/standard/exceptions/** @gewarren +/docs/standard/events/** @gewarren # Exceptions /docs/standard/exceptions/** @tdykstra # GC @@ -146,7 +146,7 @@ # Security /docs/standard/security/** @gewarren # Serialization -/docs/standard/Serialization/** @tdykstra +/docs/standard/serialization/** @tdykstra # Threading /docs/standard/threading/** @BillWagner # What's New From a315cd93ac09e332e1b4f13f6eeffa62b32005fe Mon Sep 17 00:00:00 2001 From: Maira Wenzel Date: Tue, 22 Oct 2019 13:25:36 -0700 Subject: [PATCH 6/7] add self-serve owners under standard --- .github/CODEOWNERS | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 6d7468e738976..e34f9d5e736c3 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -119,12 +119,12 @@ /docs/standard/base-types/** @Thraka # Collections /docs/standard/collections/** @BillWagner -# Base types -/docs/standard/base-types/** @Thraka # Data /docs/standard/data/** @gewarren # Datetime /docs/standard/datetime/** @Thraka +# Design guidelines +/docs/standard/design-guidelines/** @mairaw # Events /docs/standard/events/** @gewarren # Exceptions @@ -137,10 +137,14 @@ /docs/standard/globalization-localization/** @mairaw # I/O /docs/standard/io/** @Thraka +# Library guidance +/docs/standard/library-guidance/** @jamesnk # LINQ /docs/standard/linq/** @mairaw # Memory and spans /docs/standard/memory-and-spans/** @tdykstra +# Native Interop +/docs/standard/native-interop/** @jkoritzinsky # Parallel programming /docs/standard/parallel-programming/** @BillWagner # Security From a8715267e9d21e800719fc38b16a8deae411dace Mon Sep 17 00:00:00 2001 From: Maira Wenzel Date: Wed, 23 Oct 2019 10:17:47 -0700 Subject: [PATCH 7/7] Update .github/CODEOWNERS --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index e34f9d5e736c3..1462b7a1e0c5b 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -112,7 +112,7 @@ # Assembly /docs/standard/assembly/** @gewarren # Asynchronous Programming Patterns -/docs/standard/asynchronous-programming-patterns/** @gewarren +/docs/standard/asynchronous-programming-patterns/** @BillWagner # Attributes /docs/standard/attributes/** @tdykstra # Base types