From b7bbe83ed25c62a1ea4dad2da4ada7dd1233834a Mon Sep 17 00:00:00 2001 From: "Brett V. Forsgren" Date: Thu, 20 May 2021 11:56:35 -0600 Subject: [PATCH] skip flaky tests --- .../Microsoft.FSharp.Control/AsyncModule.fs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncModule.fs b/tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncModule.fs index ca1d1917067..303df51ecb8 100644 --- a/tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncModule.fs +++ b/tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncModule.fs @@ -272,8 +272,9 @@ type AsyncModule() = | e -> Assert.Fail(sprintf "Unexpected error %A" e) } Async.RunSynchronously test - - [] + + // test is flaky: https://github.com/dotnet/fsharp/issues/11586 + //[] member this.``OnCancel.RaceBetweenCancellationHandlerAndDisposingHandlerRegistration``() = let test() = use flag = new ManualResetEvent(false) @@ -296,7 +297,8 @@ type AsyncModule() = for _i = 1 to 300 do test() - [] + // test is flaky: https://github.com/dotnet/fsharp/issues/11586 + //[] member this.``OnCancel.RaceBetweenCancellationAndDispose``() = let flag = ref 0 let cts = new System.Threading.CancellationTokenSource() @@ -314,7 +316,8 @@ type AsyncModule() = :? System.OperationCanceledException -> () Assert.AreEqual(1, !flag) - [] + // test is flaky: https://github.com/dotnet/fsharp/issues/11586 + //[] member this.``OnCancel.CancelThatWasSignalledBeforeRunningTheComputation``() = let test() = let cts = new System.Threading.CancellationTokenSource()