From 3c260464693613d1f2d558d8b3dec37c2f39b1d2 Mon Sep 17 00:00:00 2001 From: janusz Date: Fri, 20 Jan 2023 22:19:09 +0000 Subject: [PATCH 1/2] Disable two failing ExprTests in DEBUG mode --- tests/service/ExprTests.fs | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/service/ExprTests.fs b/tests/service/ExprTests.fs index 02a62ba5b9..91fa687644 100644 --- a/tests/service/ExprTests.fs +++ b/tests/service/ExprTests.fs @@ -722,6 +722,13 @@ let test{0}ToStringOperator (e1:{1}) = string e1 """ +let ignoreTestInDebug () = +#if DEBUG + Assert.Ignore("Test is known to fail in DEBUG. Use RELEASE configuration to run it.") +#else + () +#endif + /// This test is run in unison with its optimized counterpart below [] let ``Test Unoptimized Declarations Project1`` () = @@ -3191,6 +3198,7 @@ let BigSequenceExpression(outFileOpt,docFileOpt,baseAddressOpt) = [] let ``Test expressions of declarations stress big expressions`` () = + ignoreTestInDebug () let cleanup, options = ProjectStressBigExpressions.createOptions() use _holder = cleanup let exprChecker = FSharpChecker.Create(keepAssemblyContents=true) @@ -3207,6 +3215,7 @@ let ``Test expressions of declarations stress big expressions`` () = [] let ``Test expressions of optimized declarations stress big expressions`` () = + ignoreTestInDebug () let cleanup, options = ProjectStressBigExpressions.createOptions() use _holder = cleanup let exprChecker = FSharpChecker.Create(keepAssemblyContents=true) From b8d232205e9cff59b087fa48901c073853f701fb Mon Sep 17 00:00:00 2001 From: janusz Date: Sat, 21 Jan 2023 11:35:11 +0000 Subject: [PATCH 2/2] Do not ignore the tests in DEBUG+NETFRAMEWORK configuration. --- tests/service/ExprTests.fs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/service/ExprTests.fs b/tests/service/ExprTests.fs index 91fa687644..6363622eb1 100644 --- a/tests/service/ExprTests.fs +++ b/tests/service/ExprTests.fs @@ -722,9 +722,9 @@ let test{0}ToStringOperator (e1:{1}) = string e1 """ -let ignoreTestInDebug () = -#if DEBUG - Assert.Ignore("Test is known to fail in DEBUG. Use RELEASE configuration to run it.") +let ignoreTestIfStackOverflowExpected () = +#if !NETFRAMEWORK && DEBUG + Assert.Ignore("Test is known to fail in DEBUG when not using NetFramework. Use RELEASE configuration or NetFramework to run it.") #else () #endif @@ -3198,7 +3198,7 @@ let BigSequenceExpression(outFileOpt,docFileOpt,baseAddressOpt) = [] let ``Test expressions of declarations stress big expressions`` () = - ignoreTestInDebug () + ignoreTestIfStackOverflowExpected () let cleanup, options = ProjectStressBigExpressions.createOptions() use _holder = cleanup let exprChecker = FSharpChecker.Create(keepAssemblyContents=true) @@ -3215,7 +3215,7 @@ let ``Test expressions of declarations stress big expressions`` () = [] let ``Test expressions of optimized declarations stress big expressions`` () = - ignoreTestInDebug () + ignoreTestIfStackOverflowExpected () let cleanup, options = ProjectStressBigExpressions.createOptions() use _holder = cleanup let exprChecker = FSharpChecker.Create(keepAssemblyContents=true)