From 838f1641fe1c51f4d3cc3c3b920216a8ab393427 Mon Sep 17 00:00:00 2001
From: Don Syme <donsyme@fastmail.fm>
Date: Wed, 19 Oct 2016 17:11:14 +0100
Subject: [PATCH] Fix fsc task to check for nulls,
 https://github.com/fsharp/fsharp/issues/628

---
 src/fsharp/FSharp.Build/Fsc.fs | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/src/fsharp/FSharp.Build/Fsc.fs b/src/fsharp/FSharp.Build/Fsc.fs
index df5a6826a6..04fe494e4b 100644
--- a/src/fsharp/FSharp.Build/Fsc.fs
+++ b/src/fsharp/FSharp.Build/Fsc.fs
@@ -196,8 +196,9 @@ type [<Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1704:Iden
         // BaseAddress
         builder.AppendSwitchIfNotNull("--baseaddress:", baseAddress)
         // DefineConstants
-        for item in defineConstants do
-            builder.AppendSwitchIfNotNull("--define:", item.ItemSpec)          
+        if defineConstants <> null then 
+            for item in defineConstants do
+                builder.AppendSwitchIfNotNull("--define:", item.ItemSpec)          
         // DocumentationFile
         builder.AppendSwitchIfNotNull("--doc:", documentationFile)
         // GenerateInterfaceFile
@@ -225,13 +226,15 @@ type [<Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1704:Iden
                 | "ITANIUM", _, _  -> "Itanium"
                 | _         -> null)
         // Resources
-        for item in resources do
-            builder.AppendSwitchIfNotNull("--resource:", item.ItemSpec)
+        if resources <> null then 
+            for item in resources do
+                builder.AppendSwitchIfNotNull("--resource:", item.ItemSpec)
         // VersionFile
         builder.AppendSwitchIfNotNull("--versionfile:", versionFile)
         // References
-        for item in references do
-            builder.AppendSwitchIfNotNull("-r:", item.ItemSpec)
+        if references <> null then 
+            for item in references do
+                builder.AppendSwitchIfNotNull("-r:", item.ItemSpec)
         // ReferencePath
         let referencePathArray = // create a array of strings
             match referencePath with