From 3d625adb919a4df84c52e1eadc94d5dd1e3c153c Mon Sep 17 00:00:00 2001 From: Kevin Ransom Date: Thu, 18 Apr 2024 16:46:14 -0700 Subject: [PATCH 1/2] root embed -files --- src/Compiler/Driver/fsc.fs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Compiler/Driver/fsc.fs b/src/Compiler/Driver/fsc.fs index 3cebc51d10f..190dbfcd806 100644 --- a/src/Compiler/Driver/fsc.fs +++ b/src/Compiler/Driver/fsc.fs @@ -204,6 +204,7 @@ let AdjustForScriptCompile (tcConfigB: TcConfigBuilder, commandLineSourceFiles, error (Error(FSComp.SR.pathIsInvalid file, rangeStartup)) let commandLineSourceFiles = commandLineSourceFiles |> List.map combineFilePath + tcConfigB.embedSourceList <- tcConfigB.embedSourceList |> List.map combineFilePath // Script compilation is active if the last item being compiled is a script and --noframework has not been specified let mutable allSources = [] From 12cca4e11a8f2263d058091e70d2f89b61813c0b Mon Sep 17 00:00:00 2001 From: Kevin Ransom Date: Thu, 18 Apr 2024 18:18:14 -0700 Subject: [PATCH 2/2] Release notes --- docs/release-notes/.FSharp.Compiler.Service/8.0.400.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/release-notes/.FSharp.Compiler.Service/8.0.400.md b/docs/release-notes/.FSharp.Compiler.Service/8.0.400.md index b24a17b85fb..de6790c0650 100644 --- a/docs/release-notes/.FSharp.Compiler.Service/8.0.400.md +++ b/docs/release-notes/.FSharp.Compiler.Service/8.0.400.md @@ -3,5 +3,7 @@ * Static abstract method on classes no longer yields internal error. ([Issue #17044](https://github.com/dotnet/fsharp/issues/17044), [PR #17055](https://github.com/dotnet/fsharp/pull/17055)) * Disallow calling abstract methods directly on interfaces. ([Issue #14012](https://github.com/dotnet/fsharp/issues/14012), [Issue #16299](https://github.com/dotnet/fsharp/issues/16299), [PR #17021](https://github.com/dotnet/fsharp/pull/17021)) * Various parenthesization API fixes. ([PR #16977](https://github.com/dotnet/fsharp/pull/16977)) +* Files passed with -embed:relative/path/to/file are not embedded. ([Issue #16768](https://github.com/dotnet/fsharp/pull/17068)) * Fix bug in optimization of for-loops over integral ranges with steps and units of measure. ([Issue #17025](https://github.com/dotnet/fsharp/issues/17025), [PR #17040](https://github.com/dotnet/fsharp/pull/17040), [PR #17048](https://github.com/dotnet/fsharp/pull/17048)) * Fix calling an overridden virtual static method via the interface ([PR #17013](https://github.com/dotnet/fsharp/pull/17013)) +