From 74a36139c9fe5cd0e9572aa605f663435b7fe750 Mon Sep 17 00:00:00 2001 From: Vasily Kirichenko Date: Tue, 3 Jan 2017 11:38:24 +0300 Subject: [PATCH 1/2] fix Language and Product names in F1 help context --- .../src/FSharp.Editor/Commands/HelpContextService.fs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vsintegration/src/FSharp.Editor/Commands/HelpContextService.fs b/vsintegration/src/FSharp.Editor/Commands/HelpContextService.fs index 2d836c66aa2..0c3d7148742 100644 --- a/vsintegration/src/FSharp.Editor/Commands/HelpContextService.fs +++ b/vsintegration/src/FSharp.Editor/Commands/HelpContextService.fs @@ -95,8 +95,8 @@ type internal FSharpHelpContextService } interface IHelpContextService with - member this.Language = FSharpCommonConstants.FSharpLanguageName - member this.Product = FSharpCommonConstants.FSharpLanguageName + member this.Language = "fsharp" + member this.Product = "fsharp" member this.GetHelpTermAsync(document, textSpan, cancellationToken) = asyncMaybe { From 282f2edaf2d7f81425ab5ae58f8d9d6568aa09ee Mon Sep 17 00:00:00 2001 From: Vasily Kirichenko Date: Tue, 3 Jan 2017 23:29:17 +0300 Subject: [PATCH 2/2] make "FSharp" a common constant --- .../src/FSharp.Editor/Commands/HelpContextService.fs | 4 ++-- vsintegration/src/FSharp.Editor/Common/CommonConstants.fs | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/vsintegration/src/FSharp.Editor/Commands/HelpContextService.fs b/vsintegration/src/FSharp.Editor/Commands/HelpContextService.fs index 0c3d7148742..0105aaa9abe 100644 --- a/vsintegration/src/FSharp.Editor/Commands/HelpContextService.fs +++ b/vsintegration/src/FSharp.Editor/Commands/HelpContextService.fs @@ -95,8 +95,8 @@ type internal FSharpHelpContextService } interface IHelpContextService with - member this.Language = "fsharp" - member this.Product = "fsharp" + member this.Language = FSharpCommonConstants.FSharpLanguageLongName + member this.Product = FSharpCommonConstants.FSharpLanguageLongName member this.GetHelpTermAsync(document, textSpan, cancellationToken) = asyncMaybe { diff --git a/vsintegration/src/FSharp.Editor/Common/CommonConstants.fs b/vsintegration/src/FSharp.Editor/Common/CommonConstants.fs index 8640bdca211..82b5ec35a4a 100644 --- a/vsintegration/src/FSharp.Editor/Common/CommonConstants.fs +++ b/vsintegration/src/FSharp.Editor/Common/CommonConstants.fs @@ -23,3 +23,5 @@ module internal FSharpCommonConstants = let FSharpSignatureHelpContentTypeName = "F# Signature Help" [] let FSharpLanguageServiceCallbackName = "F# Language Service" + [] + let FSharpLanguageLongName = "FSharp" \ No newline at end of file