From d31e16f0ab17ed8a579b54cf1585f18f472bd873 Mon Sep 17 00:00:00 2001 From: "Kevin Ransom (msft)" Date: Thu, 16 Aug 2018 21:43:46 -0700 Subject: [PATCH 1/4] Fix ngen of compiler (#5525) --- .../Swix/Microsoft.FSharp.Compiler/Files.swr | 36 ++++++++------ .../VisualFSharpFull/VisualFSharpFull.csproj | 49 +++++++++++++++++++ 2 files changed, 71 insertions(+), 14 deletions(-) diff --git a/setup/Swix/Microsoft.FSharp.Compiler/Files.swr b/setup/Swix/Microsoft.FSharp.Compiler/Files.swr index daa7eae6d65..46855bd5f64 100644 --- a/setup/Swix/Microsoft.FSharp.Compiler/Files.swr +++ b/setup/Swix/Microsoft.FSharp.Compiler/Files.swr @@ -4,30 +4,38 @@ package name=Microsoft.FSharp.Compiler version=$(FSharpPackageVersion) folder "InstallDir:Common7\IDE\CommonExtensions\Microsoft\FSharp" - file source="$(BinariesFolder)\net40\bin\fsc.exe" vs.file.ngen=yes + + file source=$(BinariesFolder)\net40\bin\fsc.exe vs.file.ngen=yes vs.file.ngenArchitecture=All vs.file.ngenPriority=2 vs.file.ngenApplication="[installDir]\Common7\IDE\CommonExtensions\Microsoft\FSharp\fsc.exe" file source="$(BinariesFolder)\net40\bin\fsc.exe.config" - file source="$(BinariesFolder)\net40\bin\FSharp.Build.dll" vs.file.ngen=yes - file source="$(BinariesFolder)\net40\bin\FSharp.Compiler.Interactive.Settings.dll" vs.file.ngen=yes - file source="$(BinariesFolder)\net40\bin\FSharp.Compiler.Private.dll" vs.file.ngen=yes - file source="$(BinariesFolder)\net40\bin\FSharp.Compiler.Server.Shared.dll" vs.file.ngen=yes - file source="$(BinariesFolder)\net40\bin\FSharp.Core.dll" vs.file.ngen=yes - file source="$(BinariesFolder)\net40\bin\FSharp.Core.optdata" - file source="$(BinariesFolder)\net40\bin\FSharp.Core.sigdata" - file source="$(PackagesFolder)\Microsoft.VisualFSharp.Type.Providers.Redist.$(MicrosoftVisualFSharpTypeProvidersRedistPackageVersion)\content\4.3.0.0\FSharp.Data.TypeProviders.dll" vs.file.ngen=yes - file source="$(BinariesFolder)\net40\bin\fsi.exe" vs.file.ngen=yes + + file source=$(BinariesFolder)\net40\bin\fsi.exe vs.file.ngen=yes vs.file.ngenArchitecture=X86 vs.file.ngenPriority=2 vs.file.ngenApplication="[installDir]\Common7\IDE\CommonExtensions\Microsoft\FSharp\fsi.exe" file source="$(BinariesFolder)\net40\bin\fsi.exe.config" - file source="$(BinariesFolder)\net40\bin\fsiAnyCpu.exe" vs.file.ngen=yes + + file source="$(BinariesFolder)\net40\bin\fsiAnyCpu.exe" vs.file.ngen=yes vs.file.ngenArchitecture=X64 vs.file.ngenPriority=2 vs.file.ngenApplication="[installDir]\Common7\IDE\CommonExtensions\Microsoft\FSharp\fsiAnyCpu.exe" file source="$(BinariesFolder)\net40\bin\fsiAnyCpu.exe.config" + + file source="$(BinariesFolder)\net40\bin\FSharp.Compiler.Interactive.Settings.dll" vs.file.ngen=yes vs.file.ngenArchitecture=All vs.file.ngenPriority=2 + file source="$(BinariesFolder)\net40\bin\FSharp.Compiler.Private.dll" vs.file.ngen=yes vs.file.ngenArchitecture=All vs.file.ngenPriority=2 + file source="$(BinariesFolder)\net40\bin\FSharp.Compiler.Server.Shared.dll" vs.file.ngen=yes vs.file.ngenArchitecture=All vs.file.ngenPriority=2 + + file source="$(BinariesFolder)\net40\bin\FSharp.Core.dll" vs.file.ngen=yes vs.file.ngenArchitecture=All vs.file.ngenPriority=2 + file source="$(BinariesFolder)\net40\bin\FSharp.Core.optdata" + file source="$(BinariesFolder)\net40\bin\FSharp.Core.sigdata" + + file source="$(BinariesFolder)\net40\bin\FSharp.Build.dll" vs.file.ngen=yes vs.file.ngenArchitecture=All vs.file.ngenPriority=2 + + file source="$(PackagesFolder)\Microsoft.VisualFSharp.Type.Providers.Redist.$(MicrosoftVisualFSharpTypeProvidersRedistPackageVersion)\content\4.3.0.0\FSharp.Data.TypeProviders.dll" file source="$(BinariesFolder)\net40\bin\Microsoft.Build.Conversion.Core.dll" file source="$(BinariesFolder)\net40\bin\Microsoft.Build.dll" file source="$(BinariesFolder)\net40\bin\Microsoft.Build.Engine.dll" file source="$(BinariesFolder)\net40\bin\Microsoft.Build.Framework.dll" file source="$(BinariesFolder)\net40\bin\Microsoft.Build.Tasks.Core.dll" file source="$(BinariesFolder)\net40\bin\Microsoft.Build.Utilities.Core.dll" - file source="$(BinariesFolder)\net40\bin\Microsoft.FSharp.NetSdk.props" - file source="$(BinariesFolder)\net40\bin\Microsoft.FSharp.NetSdk.targets" - file source="$(BinariesFolder)\net40\bin\Microsoft.FSharp.Targets" file source="$(BinariesFolder)\net40\bin\Microsoft.Portable.FSharp.Targets" file source="$(BinariesFolder)\net40\bin\System.Collections.Immutable.dll" file source="$(BinariesFolder)\net40\bin\System.Reflection.Metadata.dll" file source="$(BinariesFolder)\net40\bin\System.ValueTuple.dll" + file source="$(BinariesFolder)\net40\bin\Microsoft.FSharp.NetSdk.props" + file source="$(BinariesFolder)\net40\bin\Microsoft.FSharp.NetSdk.targets" + file source="$(BinariesFolder)\net40\bin\Microsoft.FSharp.Overrides.NetSdk.targets" + file source="$(BinariesFolder)\net40\bin\Microsoft.FSharp.Targets" diff --git a/vsintegration/Vsix/VisualFSharpFull/VisualFSharpFull.csproj b/vsintegration/Vsix/VisualFSharpFull/VisualFSharpFull.csproj index 71c698df422..e38a8f8cabe 100644 --- a/vsintegration/Vsix/VisualFSharpFull/VisualFSharpFull.csproj +++ b/vsintegration/Vsix/VisualFSharpFull/VisualFSharpFull.csproj @@ -36,6 +36,9 @@ FSharp.Build BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3b DebugSymbolsProjectOutputGroup%3b + true + All + 2 True @@ -43,6 +46,9 @@ FSharp.Compiler.Interactive.Settings BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3b DebugSymbolsProjectOutputGroup%3b + true + All + 2 True @@ -50,6 +56,9 @@ FSharp.Compiler.Server.Shared BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3b DebugSymbolsProjectOutputGroup%3b + true + All + 2 True @@ -57,6 +66,9 @@ FSharp.Compiler.Private BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3b DebugSymbolsProjectOutputGroup%3b + true + All + 2 True @@ -64,6 +76,9 @@ FSharp.Core BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3b DebugSymbolsProjectOutputGroup%3b + true + All + 2 True @@ -71,6 +86,10 @@ FsiAnyCPU BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3b DebugSymbolsProjectOutputGroup%3b + true + [installDir]\Common7\IDE\CommonExtensions\Microsoft\FSharp\fsiAnyCpu.exe + X64 + 2 True @@ -78,6 +97,10 @@ Fsi BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3b DebugSymbolsProjectOutputGroup%3b + true + [installDir]\Common7\IDE\CommonExtensions\Microsoft\FSharp\fsi.exe + X86 + 2 True @@ -85,6 +108,10 @@ fsc BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3b DebugSymbolsProjectOutputGroup%3b + true + [installDir]\Common7\IDE\CommonExtensions\Microsoft\FSharp\fsc.exe + All + 2 True @@ -92,6 +119,9 @@ FSharp.Editor BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3bPkgDefProjectOutputGroup%3b DebugSymbolsProjectOutputGroup%3b + true + All + 2 True @@ -106,6 +136,9 @@ FSharp.LanguageService.Base BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3bPkgDefProjectOutputGroup%3b DebugSymbolsProjectOutputGroup%3b + true + All + 2 True @@ -113,6 +146,9 @@ FSharp.LanguageService BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3bPkgDefProjectOutputGroup%3b DebugSymbolsProjectOutputGroup%3b + true + All + 2 True @@ -120,6 +156,9 @@ ProjectSystem.Base BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3bPkgDefProjectOutputGroup%3b DebugSymbolsProjectOutputGroup%3b + true + All + 2 True @@ -127,6 +166,9 @@ ProjectSystem BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3bPkgDefProjectOutputGroup%3b DebugSymbolsProjectOutputGroup%3b + true + All + 2 True @@ -134,6 +176,9 @@ FSharp.PropertiesPages BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3bPkgDefProjectOutputGroup%3b DebugSymbolsProjectOutputGroup%3b + true + All + 2 True @@ -141,8 +186,12 @@ FSharp.VS.FSI BuiltProjectOutputGroup%3bGetCopyToOutputDirectoryItems%3bPkgDefProjectOutputGroup%3b DebugSymbolsProjectOutputGroup%3b + true + All + 2 True + {6ba13aa4-c25f-480f-856b-8e8000299a72} AppConfig From 12df32249cca8c00826d639a8403e13d53860ac1 Mon Sep 17 00:00:00 2001 From: "Brett V. Forsgren" Date: Wed, 22 Aug 2018 15:42:46 -0700 Subject: [PATCH 2/4] create the F# SDK package from all existing NuGet packages Also fix a bug where we were mis-packing the current FSharp.Core 4.5 as 4.4.3. --- setup/Swix/Microsoft.FSharp.SDK/Files.swr | 48 +++++++++---------- .../Microsoft.FSharp.SDK.swixproj | 1 - setup/packages.config | 2 + 3 files changed, 26 insertions(+), 25 deletions(-) diff --git a/setup/Swix/Microsoft.FSharp.SDK/Files.swr b/setup/Swix/Microsoft.FSharp.SDK/Files.swr index 271db6961cd..228bc933437 100644 --- a/setup/Swix/Microsoft.FSharp.SDK/Files.swr +++ b/setup/Swix/Microsoft.FSharp.SDK/Files.swr @@ -17,10 +17,10 @@ folder "InstallDir:Common7\IDE\CommonExtensions\Microsoft\FSharpSdk" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETCore\3.7.4.0\FSharp.Core.sigdata" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETCore\3.7.4.0\FSharp.Core.xml" folder "3.7.41.0" - file source="$(BinariesFolder)\profiles\portable-net45+netcore45\FSharp.Core.dll" - file source="$(BinariesFolder)\profiles\portable-net45+netcore45\FSharp.Core.optdata" - file source="$(BinariesFolder)\profiles\portable-net45+netcore45\FSharp.Core.sigdata" - file source="$(BinariesFolder)\profiles\portable-net45+netcore45\FSharp.Core.xml" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+netcore45\FSharp.Core.dll" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+netcore45\FSharp.Core.optdata" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+netcore45\FSharp.Core.sigdata" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+netcore45\FSharp.Core.xml" folder "3.78.3.1" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETCore\3.78.3.1\FSharp.Core.dll" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETCore\3.78.3.1\FSharp.Core.optdata" @@ -32,10 +32,10 @@ folder "InstallDir:Common7\IDE\CommonExtensions\Microsoft\FSharpSdk" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETCore\3.78.4.0\FSharp.Core.sigdata" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETCore\3.78.4.0\FSharp.Core.xml" folder "3.78.41.0" - file source="$(BinariesFolder)\profiles\portable-net45+netcore45+wp8\FSharp.Core.dll" - file source="$(BinariesFolder)\profiles\portable-net45+netcore45+wp8\FSharp.Core.optdata" - file source="$(BinariesFolder)\profiles\portable-net45+netcore45+wp8\FSharp.Core.sigdata" - file source="$(BinariesFolder)\profiles\portable-net45+netcore45+wp8\FSharp.Core.xml" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+netcore45+wp8\FSharp.Core.dll" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+netcore45+wp8\FSharp.Core.optdata" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+netcore45+wp8\FSharp.Core.sigdata" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+netcore45+wp8\FSharp.Core.xml" folder "3.259.3.1" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETCore\3.259.3.1\FSharp.Core.dll" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETCore\3.259.3.1\FSharp.Core.optdata" @@ -47,10 +47,10 @@ folder "InstallDir:Common7\IDE\CommonExtensions\Microsoft\FSharpSdk" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETCore\3.259.4.0\FSharp.Core.sigdata" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETCore\3.259.4.0\FSharp.Core.xml" folder "3.259.41.0" - file source="$(BinariesFolder)\profiles\portable-net45+netcore45+wpa81+wp8\FSharp.Core.dll" - file source="$(BinariesFolder)\profiles\portable-net45+netcore45+wpa81+wp8\FSharp.Core.optdata" - file source="$(BinariesFolder)\profiles\portable-net45+netcore45+wpa81+wp8\FSharp.Core.sigdata" - file source="$(BinariesFolder)\profiles\portable-net45+netcore45+wpa81+wp8\FSharp.Core.xml" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+netcore45+wpa81+wp8\FSharp.Core.dll" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+netcore45+wpa81+wp8\FSharp.Core.optdata" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+netcore45+wpa81+wp8\FSharp.Core.sigdata" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+netcore45+wpa81+wp8\FSharp.Core.xml" folder ".NETFramework\v4.0" folder "4.3.0.0" @@ -69,15 +69,15 @@ folder "InstallDir:Common7\IDE\CommonExtensions\Microsoft\FSharpSdk" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETFramework\v4.0\4.4.0.0\FSharp.Core.sigdata" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETFramework\v4.0\4.4.0.0\FSharp.Core.xml" folder "4.4.1.0" - file source="$(BinariesFolder)\versions\4.4.1.0\FSharp.Core.dll" - file source="$(BinariesFolder)\versions\4.4.1.0\FSharp.Core.optdata" - file source="$(BinariesFolder)\versions\4.4.1.0\FSharp.Core.sigdata" - file source="$(BinariesFolder)\versions\4.4.1.0\FSharp.Core.xml" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\versions\4.4.1.0\FSharp.Core.dll" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\versions\4.4.1.0\FSharp.Core.optdata" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\versions\4.4.1.0\FSharp.Core.sigdata" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\versions\4.4.1.0\FSharp.Core.xml" folder "4.4.3.0" - file source="$(BinariesFolder)\net40\bin\FSharp.Core.dll" - file source="$(BinariesFolder)\net40\bin\FSharp.Core.optdata" - file source="$(BinariesFolder)\net40\bin\FSharp.Core.sigdata" - file source="$(BinariesFolder)\net40\bin\FSharp.Core.xml" + file source="$(PackagesFolder)\FSharp.Core.4.3.4\lib\net45\FSharp.Core.dll" + file source="$(PackagesFolder)\FSharp.Core.4.3.4\lib\net45\FSharp.Core.optdata" + file source="$(PackagesFolder)\FSharp.Core.4.3.4\lib\net45\FSharp.Core.sigdata" + file source="$(PackagesFolder)\FSharp.Core.4.3.4\lib\net45\FSharp.Core.xml" folder ".NETPortable" folder "2.3.5.0" @@ -96,7 +96,7 @@ folder "InstallDir:Common7\IDE\CommonExtensions\Microsoft\FSharpSdk" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETPortable\3.47.4.0\FSharp.Core.sigdata" file source="$(PackagesFolder)\Microsoft.VisualFSharp.Core.Redist.1.0.0\content\.NETPortable\3.47.4.0\FSharp.Core.xml" folder "3.47.41.0" - file source="$(BinariesFolder)\profiles\portable-net45+sl5+netcore45\FSharp.Core.dll" - file source="$(BinariesFolder)\profiles\portable-net45+sl5+netcore45\FSharp.Core.optdata" - file source="$(BinariesFolder)\profiles\portable-net45+sl5+netcore45\FSharp.Core.sigdata" - file source="$(BinariesFolder)\profiles\portable-net45+sl5+netcore45\FSharp.Core.xml" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+sl5+netcore45\FSharp.Core.dll" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+sl5+netcore45\FSharp.Core.optdata" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+sl5+netcore45\FSharp.Core.sigdata" + file source="$(PackagesFolder)\Microsoft.Portable.FSharp.Core.10.1.0\lib\profiles\portable-net45+sl5+netcore45\FSharp.Core.xml" diff --git a/setup/Swix/Microsoft.FSharp.SDK/Microsoft.FSharp.SDK.swixproj b/setup/Swix/Microsoft.FSharp.SDK/Microsoft.FSharp.SDK.swixproj index bde4a368d4f..9256eadc32f 100644 --- a/setup/Swix/Microsoft.FSharp.SDK/Microsoft.FSharp.SDK.swixproj +++ b/setup/Swix/Microsoft.FSharp.SDK/Microsoft.FSharp.SDK.swixproj @@ -18,7 +18,6 @@ - $(PackagePreprocessorDefinitions);BinariesFolder=$(BinariesFolder) $(PackagePreprocessorDefinitions);PackagesFolder=$(PackagesFolder) $(PackagePreprocessorDefinitions);FSharpPackageVersion=$(FSharpPackageVersion) diff --git a/setup/packages.config b/setup/packages.config index 930e870e4bf..938236f7d99 100644 --- a/setup/packages.config +++ b/setup/packages.config @@ -11,4 +11,6 @@ + + From 07c50ae4320a5ee1a805e85df275fd22f0c286c5 Mon Sep 17 00:00:00 2001 From: "Kevin Ransom (msft)" Date: Wed, 5 Sep 2018 20:47:07 -0700 Subject: [PATCH 3/4] Fixes #5504 - 15.8 Internal MSBuild Error (#5557) --- .../src/FSharp.ProjectSystem.Base/Project/ProjectNode.cs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectNode.cs b/vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectNode.cs index c69c4a12295..47aa6d184ec 100644 --- a/vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectNode.cs +++ b/vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectNode.cs @@ -3235,12 +3235,9 @@ internal virtual BuildSubmission DoMSBuildSubmission(BuildKind buildKind, string this.SetHostObject("CoreCompile", "Fsc", this); // Do the actual Build - var loggerList = new System.Collections.Generic.List(this.buildEngine.Loggers); - if (buildLogger != null) - loggerList.Add(buildLogger); - if (myDebugLogger != null) - loggerList.Add(myDebugLogger); - + var loggerList = new System.Collections.Generic.List(); + if (buildLogger != null) loggerList.Add(buildLogger); + if (myDebugLogger != null) loggerList.Add(myDebugLogger); loggers = loggerList.ToArray(); var ba = new BuildAccessorAccess(buildKind, accessor); From 78654a12e1e0cad9acd9557d24049f14b33bd927 Mon Sep 17 00:00:00 2001 From: "Brett V. Forsgren" Date: Fri, 10 Aug 2018 17:25:20 -0700 Subject: [PATCH 4/4] remove unnecessary build step --- .vsts-signed.yaml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.vsts-signed.yaml b/.vsts-signed.yaml index 6d5193b38c0..83973b32d27 100644 --- a/.vsts-signed.yaml +++ b/.vsts-signed.yaml @@ -44,13 +44,6 @@ steps: msbuildArguments: '/t:Build /p:ExpectedFeedUrl=$(PB_PublishBlobFeedUrl) /p:AccountKey=$(PB_PublishBlobFeedKey) /p:ManifestBranch=$(SourceBranch) /p:ManifestCommit=$(SourceVersion) /p:ManifestBuildId=$(OfficialBuildId)' condition: and(succeeded(), contains(variables['PB_PublishType'], 'blob')) -# Run BinSkim -- task: securedevelopmentteam.vss-secure-development-tools.build-task-binskim.BinSkim@3 - displayName: Run BinSkim - inputs: - arguments: 'analyze "$(MSBuildConfiguration)\*.dll" "$(MSBuildConfiguration)\*.exe" --recurse --output "$(MSBuildConfiguration)\artifacts"' - continueOnError: true - # Create static drop - task: PublishBuildArtifacts@1 displayName: Create static drop