From 1330fa0dd7d32a7e13f0b05d2b6765c01f0d7251 Mon Sep 17 00:00:00 2001 From: Jonathan Pryor Date: Thu, 20 Apr 2017 16:47:38 -0400 Subject: [PATCH] [Xamarin.Android.Tools.Bytecode-Tests] Update for API-24 docs The `ParameterFixupTests.XmlDeclaration_FixedUpFromDocumentation()` and `ParameterFixupTests.XmlDeclaration_FixedUpFromApiXmlDocumentation()` tests read a `java.util.Collection.class` file that contains no parameter name information, and uses XML and/or "JavaDoc" HTML documentation to ascertain the correct parameter names. For better or worse, parameter names are *not* part of any Java ABI, and thus can change over time. Which is what happened here: these tests were originally written against the Android documentation for API-18. Since then, the docs for API-24 have *changed the parameter names* for the `Collection.add(E)` method, changing the parameter name from `object` to `e`. Update the expected paramater names when reading docs from `$ANDROID_SDK_PATH` so that the API-24 names are expected. --- .../Tests/ParameterFixupApiXmlDocs.xml | 2 +- .../Tests/ParameterFixupFromDocs.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Xamarin.Android.Tools.Bytecode/Tests/ParameterFixupApiXmlDocs.xml b/src/Xamarin.Android.Tools.Bytecode/Tests/ParameterFixupApiXmlDocs.xml index 81696912a..e79117970 100644 --- a/src/Xamarin.Android.Tools.Bytecode/Tests/ParameterFixupApiXmlDocs.xml +++ b/src/Xamarin.Android.Tools.Bytecode/Tests/ParameterFixupApiXmlDocs.xml @@ -3,7 +3,7 @@ - + diff --git a/src/Xamarin.Android.Tools.Bytecode/Tests/ParameterFixupFromDocs.xml b/src/Xamarin.Android.Tools.Bytecode/Tests/ParameterFixupFromDocs.xml index e15928a07..d654e9602 100644 --- a/src/Xamarin.Android.Tools.Bytecode/Tests/ParameterFixupFromDocs.xml +++ b/src/Xamarin.Android.Tools.Bytecode/Tests/ParameterFixupFromDocs.xml @@ -38,7 +38,7 @@ synthetic="false" jni-signature="(Ljava/lang/Object;)Z">