From f91514b320baba31c55fc840e83bef9000c2c9f9 Mon Sep 17 00:00:00 2001 From: Rolf Bjarne Kvinge Date: Fri, 24 Apr 2026 09:28:22 +0200 Subject: [PATCH 1/3] [devops] Make the API diff pipeline use a pr: trigger. Unfortunately Azure DevOps doesn't properly report GitHub checks for pipelines triggered by another pipeline, when that other pipeline was triggered from a pr trigger. So go back to triggering the API diff pipeline using a pr: trigger. This effectively reverts #21880 ("[CI] Make the API diff be triggered as soon as the config of the build is done.") References: * https://stackoverflow.com/questions/78443654/reporting-stage-statuses-to-github-for-pipeline-triggered-by-another-pipeline --- tools/devops/automation/run-ci-api-diff.yml | 33 ++++++++++++++------- tools/devops/automation/run-pr-api-diff.yml | 26 +++++++++++----- 2 files changed, 40 insertions(+), 19 deletions(-) diff --git a/tools/devops/automation/run-ci-api-diff.yml b/tools/devops/automation/run-ci-api-diff.yml index 8ccd511ab0c3..98a813647f23 100644 --- a/tools/devops/automation/run-ci-api-diff.yml +++ b/tools/devops/automation/run-ci-api-diff.yml @@ -1,16 +1,27 @@ # Pipeline that will calculate the api diff on a ci commit. -trigger: none -pr: none - -# we cannot use a template in a pipeline context -resources: - pipelines: - - pipeline: macios - source: \Xamarin\Mac-iOS\ci pipelines\xamarin-macios-ci - trigger: - stages: - - configure_build +trigger: + branches: + include: + - '*' + exclude: + - refs/heads/locfiles/* + - refs/heads/dev/* + - refs/heads/darc-* + - refs/heads/backport-pr-* + paths: + exclude: + - .github + - docs + - CODEOWNERS + - ISSUE_TEMPLATE.md + - LICENSE + - NOTICE.txt + - SECURITY.MD + - README.md + - src/README.md + - tools/mtouch/README.md + - msbuild/Xamarin.Localization.MSBuild/README.md extends: template: templates/pipelines/api-diff-pipeline.yml diff --git a/tools/devops/automation/run-pr-api-diff.yml b/tools/devops/automation/run-pr-api-diff.yml index 42924ca932a9..07401bdf077c 100644 --- a/tools/devops/automation/run-pr-api-diff.yml +++ b/tools/devops/automation/run-pr-api-diff.yml @@ -1,15 +1,25 @@ # Pipeline that will calculate the api diff on a pr commit. trigger: none -pr: none -resources: - pipelines: - - pipeline: macios - source: \Xamarin\Mac-iOS\pr pipelines\xamarin-macios-pr - trigger: - stages: - - configure_build +pr: + autoCancel: true + branches: + include: + - '*' # yes, you do need the quote, * has meaning in yamls + paths: + exclude: + - .github + - docs + - CODEOWNERS + - ISSUE_TEMPLATE.md + - LICENSE + - NOTICE.txt + - SECURITY.MD + - README.md + - src/README.md + - tools/mtouch/README.md + - msbuild/Xamarin.Localization.MSBuild/README.md extends: template: templates/pipelines/api-diff-pipeline.yml From 7e5639dcb948bbfe426c39fd054022101f3133de Mon Sep 17 00:00:00 2001 From: Rolf Bjarne Kvinge Date: Fri, 24 Apr 2026 09:33:42 +0200 Subject: [PATCH 2/3] Only the PR trigger. --- tools/devops/automation/run-ci-api-diff.yml | 33 +++++++-------------- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/tools/devops/automation/run-ci-api-diff.yml b/tools/devops/automation/run-ci-api-diff.yml index 98a813647f23..8ccd511ab0c3 100644 --- a/tools/devops/automation/run-ci-api-diff.yml +++ b/tools/devops/automation/run-ci-api-diff.yml @@ -1,27 +1,16 @@ # Pipeline that will calculate the api diff on a ci commit. -trigger: - branches: - include: - - '*' - exclude: - - refs/heads/locfiles/* - - refs/heads/dev/* - - refs/heads/darc-* - - refs/heads/backport-pr-* - paths: - exclude: - - .github - - docs - - CODEOWNERS - - ISSUE_TEMPLATE.md - - LICENSE - - NOTICE.txt - - SECURITY.MD - - README.md - - src/README.md - - tools/mtouch/README.md - - msbuild/Xamarin.Localization.MSBuild/README.md +trigger: none +pr: none + +# we cannot use a template in a pipeline context +resources: + pipelines: + - pipeline: macios + source: \Xamarin\Mac-iOS\ci pipelines\xamarin-macios-ci + trigger: + stages: + - configure_build extends: template: templates/pipelines/api-diff-pipeline.yml From eff2331741872cedb8793b41cee4b127a46c289e Mon Sep 17 00:00:00 2001 From: Rolf Bjarne Kvinge Date: Fri, 24 Apr 2026 17:25:52 +0200 Subject: [PATCH 3/3] Trigger build --- Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile b/Makefile index 0dcd1bcd2fa1..f60d19b26180 100644 --- a/Makefile +++ b/Makefile @@ -98,4 +98,3 @@ git-clean-all: @echo "Done" SUBDIRS += tests -