From 741afffc2311e217edb4110717123b0228623cbc Mon Sep 17 00:00:00 2001 From: Vincent Dondain Date: Wed, 27 Mar 2019 18:51:54 -0400 Subject: [PATCH] [xharness] Fix BuildOnly logic https://github.com/xamarin/xamarin-macios/pull/4884 introduced the logic of only building certain `RunTestTask`. This was meant to disable iOS Extensions as part of a fix to https://github.com/xamarin/maccore/issues/1008. However this didn't quite work and iOS extensions were still running (and failing). The reason being that `BuildOnly` was set to a `RunDeviceTask` that's added to a list which is then given to `CreateTestVariations` which creates new instances of `RunDeviceTask`. We now propagate `BuildOnly` to the new variation instance. --- tests/xharness/Jenkins.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/xharness/Jenkins.cs b/tests/xharness/Jenkins.cs index 930bc3d22f7e..4388bff177aa 100644 --- a/tests/xharness/Jenkins.cs +++ b/tests/xharness/Jenkins.cs @@ -374,6 +374,7 @@ IEnumerable CreateTestVariations (IEnumerable tests, Func