From 7195db6bf53d0858d7419f4abf7e06d07bc23174 Mon Sep 17 00:00:00 2001 From: Mariana Dematte Date: Tue, 1 Apr 2025 13:55:07 +0200 Subject: [PATCH 1/3] [17.14] Final branding (#11652) * final branding * restore version bump check * Updated Package Baseline Version --- .vsts-dotnet-ci.yml | 66 ++++++++++++++++++++++----------------------- eng/Versions.props | 4 +-- 2 files changed, 35 insertions(+), 35 deletions(-) diff --git a/.vsts-dotnet-ci.yml b/.vsts-dotnet-ci.yml index 8b1834e9b25..624666c9360 100644 --- a/.vsts-dotnet-ci.yml +++ b/.vsts-dotnet-ci.yml @@ -14,40 +14,40 @@ variables: value: none jobs: -# - job: CheckVersionBumpOnReleaseBranches -# displayName: "Check Version Bump On Release Branches" -# steps: -# - powershell: | -# $versionsFile = "eng/Versions.props" -# $changedFiles = git diff --name-only HEAD HEAD~1 -# $changedVersionsFile = $changedFiles | Where-Object { $_ -eq $versionsFile } -# $isInitialCommit = $false -# $isVersionBumped = $false -# if ($changedVersionsFile -ne $null) { -# $difference = git diff HEAD~1 $versionsFile -# $changedContent = $difference -join "%" -# # 'DotNetFinalVersionKind' is expected to be added only during the initial setup of the release branch -# $initialCommitPattern = '-\s*\d+\.\d+\.\d+<\/VersionPrefix>%.*\+\s*\d+\.\d+\.\d+<\/VersionPrefix>release<\/DotNetFinalVersionKind>' -# $isInitialCommit = $changedContent -match $initialCommitPattern -# $pattern = '-\s*\d+\.\d+\.(?\d+)<\/VersionPrefix>.*%\+\s*\d+\.\d+\.(?\d+)<\/VersionPrefix>' -# if (!($isInitialCommit) -and ($changedContent -match $pattern)) { -# try { -# $previousPatch = [Convert]::ToInt32($Matches.previous) -# $currentPatch = [Convert]::ToInt32($Matches.current) -# if ($currentPatch -gt $previousPatch) { -# $isVersionBumped = $true -# } -# } catch { -# Write-Host "An error occurred during conversion: $_" -# } -# } -# } +- job: CheckVersionBumpOnReleaseBranches + displayName: "Check Version Bump On Release Branches" + steps: + - powershell: | + $versionsFile = "eng/Versions.props" + $changedFiles = git diff --name-only HEAD HEAD~1 + $changedVersionsFile = $changedFiles | Where-Object { $_ -eq $versionsFile } + $isInitialCommit = $false + $isVersionBumped = $false + if ($changedVersionsFile -ne $null) { + $difference = git diff HEAD~1 $versionsFile + $changedContent = $difference -join "%" + # 'DotNetFinalVersionKind' is expected to be added only during the initial setup of the release branch + $initialCommitPattern = '-\s*\d+\.\d+\.\d+<\/VersionPrefix>%.*\+\s*\d+\.\d+\.\d+<\/VersionPrefix>release<\/DotNetFinalVersionKind>' + $isInitialCommit = $changedContent -match $initialCommitPattern + $pattern = '-\s*\d+\.\d+\.(?\d+)<\/VersionPrefix>.*%\+\s*\d+\.\d+\.(?\d+)<\/VersionPrefix>' + if (!($isInitialCommit) -and ($changedContent -match $pattern)) { + try { + $previousPatch = [Convert]::ToInt32($Matches.previous) + $currentPatch = [Convert]::ToInt32($Matches.current) + if ($currentPatch -gt $previousPatch) { + $isVersionBumped = $true + } + } catch { + Write-Host "An error occurred during conversion: $_" + } + } + } -# if (!($isInitialCommit -or $isVersionBumped)) { -# throw "Hello! I noticed that you're targeting one of our servicing branches. You need to increase the revision version number (the last part) of 'VersionPrefix' in eng/Versions.props." -# } -# condition: startsWith(variables['System.PullRequest.TargetBranch'], 'vs') -# displayName: "Check if patch version is bumped up" + if (!($isInitialCommit -or $isVersionBumped)) { + throw "Hello! I noticed that you're targeting one of our servicing branches. You need to increase the revision version number (the last part) of 'VersionPrefix' in eng/Versions.props." + } + condition: startsWith(variables['System.PullRequest.TargetBranch'], 'vs') + displayName: "Check if patch version is bumped up" - job: IfOnlyDocumentionChanged displayName: "Check whether Test Results need to be executed" diff --git a/eng/Versions.props b/eng/Versions.props index 93c2ade44a8..ef0f1aea5db 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -2,8 +2,8 @@ - 17.14.0 - 17.13.0-preview-24611-01 + 17.14.0release + 17.13.9 15.1.0.0 preview true From 026c880a6ea3020d5b88790f685541dce8a7ad7c Mon Sep 17 00:00:00 2001 From: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com> Date: Tue, 1 Apr 2025 16:53:11 +0200 Subject: [PATCH 2/3] Revert "Update assembly versions to latest for packages that recently shipped" (#11659) Reverts #11038 It causes versioning issues. --- eng/Packages.props | 1 - eng/Versions.props | 24 +++++++++++++++++------- src/MSBuild/app.amd64.config | 24 ++++++++++++------------ src/MSBuild/app.config | 12 ++++++------ 4 files changed, 35 insertions(+), 26 deletions(-) diff --git a/eng/Packages.props b/eng/Packages.props index 456f037819e..6afcad00799 100644 --- a/eng/Packages.props +++ b/eng/Packages.props @@ -34,7 +34,6 @@ - diff --git a/eng/Versions.props b/eng/Versions.props index ef0f1aea5db..161311613a2 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -2,7 +2,7 @@ - 17.14.0release + 17.14.1release 17.13.9 15.1.0.0 preview @@ -20,18 +20,28 @@ true - - + + + + 4.6.0 + 6.1.0 + + + - 4.6.0 - 4.6.0 - 6.1.0 + 4.5.5 + 6.0.0 + + + + 6.0.1 0.2.104-beta - 6.1.0 5.0.0 diff --git a/src/MSBuild/app.amd64.config b/src/MSBuild/app.amd64.config index dea6d8dbc9c..ca919c51e3f 100644 --- a/src/MSBuild/app.amd64.config +++ b/src/MSBuild/app.amd64.config @@ -39,8 +39,8 @@ - - + + @@ -94,8 +94,8 @@ - - + + @@ -190,13 +190,13 @@ - - + + - - + + @@ -215,8 +215,8 @@ - - + + @@ -240,8 +240,8 @@ - - + + diff --git a/src/MSBuild/app.config b/src/MSBuild/app.config index cd0059bd3db..f1bb2ea9f69 100644 --- a/src/MSBuild/app.config +++ b/src/MSBuild/app.config @@ -45,7 +45,7 @@ - + @@ -57,7 +57,7 @@ - + @@ -78,11 +78,11 @@ - + - + @@ -98,7 +98,7 @@ - + @@ -114,7 +114,7 @@ - + From 1827b1afdbbe5dc673d075d3bf60e66289202236 Mon Sep 17 00:00:00 2001 From: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com> Date: Wed, 2 Apr 2025 10:28:28 +0200 Subject: [PATCH 3/3] disable version bump check step --- .vsts-dotnet-ci.yml | 66 ++++++++++++++++++++++----------------------- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/.vsts-dotnet-ci.yml b/.vsts-dotnet-ci.yml index e9d523568a1..3ea490a61af 100644 --- a/.vsts-dotnet-ci.yml +++ b/.vsts-dotnet-ci.yml @@ -14,40 +14,40 @@ variables: value: none jobs: -- job: CheckVersionBumpOnReleaseBranches - displayName: "Check Version Bump On Release Branches" - steps: - - powershell: | - $versionsFile = "eng/Versions.props" - $changedFiles = git diff --name-only HEAD HEAD~1 - $changedVersionsFile = $changedFiles | Where-Object { $_ -eq $versionsFile } - $isInitialCommit = $false - $isVersionBumped = $false - if ($changedVersionsFile -ne $null) { - $difference = git diff HEAD~1 $versionsFile - $changedContent = $difference -join "%" - # 'DotNetFinalVersionKind' is expected to be added only during the initial setup of the release branch - $initialCommitPattern = '-\s*\d+\.\d+\.\d+<\/VersionPrefix>%.*\+\s*\d+\.\d+\.\d+<\/VersionPrefix>release<\/DotNetFinalVersionKind>' - $isInitialCommit = $changedContent -match $initialCommitPattern - $pattern = '-\s*\d+\.\d+\.(?\d+)<\/VersionPrefix>.*%\+\s*\d+\.\d+\.(?\d+)<\/VersionPrefix>' - if (!($isInitialCommit) -and ($changedContent -match $pattern)) { - try { - $previousPatch = [Convert]::ToInt32($Matches.previous) - $currentPatch = [Convert]::ToInt32($Matches.current) - if ($currentPatch -gt $previousPatch) { - $isVersionBumped = $true - } - } catch { - Write-Host "An error occurred during conversion: $_" - } - } - } +# - job: CheckVersionBumpOnReleaseBranches +# displayName: "Check Version Bump On Release Branches" +# steps: +# - powershell: | +# $versionsFile = "eng/Versions.props" +# $changedFiles = git diff --name-only HEAD HEAD~1 +# $changedVersionsFile = $changedFiles | Where-Object { $_ -eq $versionsFile } +# $isInitialCommit = $false +# $isVersionBumped = $false +# if ($changedVersionsFile -ne $null) { +# $difference = git diff HEAD~1 $versionsFile +# $changedContent = $difference -join "%" +# # 'DotNetFinalVersionKind' is expected to be added only during the initial setup of the release branch +# $initialCommitPattern = '-\s*\d+\.\d+\.\d+<\/VersionPrefix>%.*\+\s*\d+\.\d+\.\d+<\/VersionPrefix>release<\/DotNetFinalVersionKind>' +# $isInitialCommit = $changedContent -match $initialCommitPattern +# $pattern = '-\s*\d+\.\d+\.(?\d+)<\/VersionPrefix>.*%\+\s*\d+\.\d+\.(?\d+)<\/VersionPrefix>' +# if (!($isInitialCommit) -and ($changedContent -match $pattern)) { +# try { +# $previousPatch = [Convert]::ToInt32($Matches.previous) +# $currentPatch = [Convert]::ToInt32($Matches.current) +# if ($currentPatch -gt $previousPatch) { +# $isVersionBumped = $true +# } +# } catch { +# Write-Host "An error occurred during conversion: $_" +# } +# } +# } - if (!($isInitialCommit -or $isVersionBumped)) { - throw "Hello! I noticed that you're targeting one of our servicing branches. You need to increase the revision version number (the last part) of 'VersionPrefix' in eng/Versions.props." - } - condition: startsWith(variables['System.PullRequest.TargetBranch'], 'vs') - displayName: "Check if patch version is bumped up" +# if (!($isInitialCommit -or $isVersionBumped)) { +# throw "Hello! I noticed that you're targeting one of our servicing branches. You need to increase the revision version number (the last part) of 'VersionPrefix' in eng/Versions.props." +# } +# condition: startsWith(variables['System.PullRequest.TargetBranch'], 'vs') +# displayName: "Check if patch version is bumped up" - job: IfOnlyDocumentionChanged displayName: "Check whether Test Results need to be executed"