From d11afb0138227928ad3036c366d93744b07d08f2 Mon Sep 17 00:00:00 2001 From: AR-May <67507805+AR-May@users.noreply.github.com> Date: Wed, 18 Mar 2026 18:04:36 +0100 Subject: [PATCH 1/3] Fix thread safety issues in WorkerNodeTelemetryData --- .../RequestBuilder/RequestBuilder.cs | 27 +++++----- .../TelemetryInfra/ITelemetryForwarder.cs | 26 +++------- .../TelemetryForwarderProvider.cs | 49 ++++++++++++------- .../Telemetry/WorkerNodeTelemetryData.cs | 14 +++++- 4 files changed, 65 insertions(+), 51 deletions(-) diff --git a/src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs b/src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs index 409ee34f360..b12cbed63d8 100644 --- a/src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs +++ b/src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs @@ -19,6 +19,7 @@ using Microsoft.Build.Experimental.BuildCheck; using Microsoft.Build.Experimental.BuildCheck.Infrastructure; using Microsoft.Build.Framework; +using Microsoft.Build.Framework.Telemetry; using Microsoft.Build.Internal; using Microsoft.Build.Shared; using Microsoft.Build.Shared.Debugging; @@ -1285,6 +1286,9 @@ private void UpdateStatisticsPostBuild() return; } + // Accumulate all telemetry into a local instance, then merge into the shared singleton once. + WorkerNodeTelemetryData localData = new(); + foreach (var projectTargetInstance in _requestEntry.RequestConfiguration.Project.Targets) { bool wasExecuted = @@ -1315,20 +1319,16 @@ private void UpdateStatisticsPostBuild() (isFromNuget && FileClassifier.Shared.IsMicrosoftPackageInNugetCache(projectTargetInstance.Value.FullPath)); } - telemetryForwarder.AddTarget( - projectTargetInstance.Key, - // would we want to distinguish targets that were executed only during this execution - we'd need - // to remember target names from ResultsByTarget from before execution - wasExecuted, - isCustom, - isMetaprojTarget, - isFromNuget, - skipReason); + var key = TelemetryForwarderProvider.TelemetryForwarder.GetKey( + projectTargetInstance.Key, isCustom, isMetaprojTarget, isFromNuget); + localData.AddTarget(key, wasExecuted, skipReason); } TaskRegistry taskReg = _requestEntry.RequestConfiguration.Project.TaskRegistry; CollectTasksStats(taskReg); + telemetryForwarder.MergeWorkerData(localData); + void CollectTasksStats(TaskRegistry taskRegistry) { if (taskRegistry == null) @@ -1338,13 +1338,16 @@ void CollectTasksStats(TaskRegistry taskRegistry) foreach (TaskRegistry.RegisteredTaskRecord registeredTaskRecord in taskRegistry.TaskRegistrations.Values.SelectMany(record => record)) { - telemetryForwarder.AddTask( + var key = TelemetryForwarderProvider.TelemetryForwarder.GetKey( registeredTaskRecord.TaskIdentity.Name, + registeredTaskRecord.ComputeIfCustom(), + isMetaproj: false, + registeredTaskRecord.IsFromNugetCache); + localData.AddTask( + key, registeredTaskRecord.Statistics.ExecutedTime, registeredTaskRecord.Statistics.ExecutedCount, registeredTaskRecord.Statistics.TotalMemoryConsumption, - registeredTaskRecord.ComputeIfCustom(), - registeredTaskRecord.IsFromNugetCache, registeredTaskRecord.TaskFactoryAttributeName, registeredTaskRecord.TaskFactoryParameters.Runtime); diff --git a/src/Build/TelemetryInfra/ITelemetryForwarder.cs b/src/Build/TelemetryInfra/ITelemetryForwarder.cs index 916661a7aa2..18000c48280 100644 --- a/src/Build/TelemetryInfra/ITelemetryForwarder.cs +++ b/src/Build/TelemetryInfra/ITelemetryForwarder.cs @@ -1,9 +1,8 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -using System; using Microsoft.Build.BackEnd.Logging; -using Microsoft.Build.Framework; +using Microsoft.Build.Framework.Telemetry; namespace Microsoft.Build.TelemetryInfra; @@ -15,26 +14,13 @@ internal interface ITelemetryForwarder { bool IsTelemetryCollected { get; } - void AddTask( - string name, - TimeSpan cumulativeExecutionTime, - short executionsCount, - long totalMemoryConsumed, - bool isCustom, - bool isFromNugetCache, - string? taskFactoryName, - string? taskHostRuntime); - /// - /// Add info about target execution to the telemetry. + /// Merges a batch of telemetry data into this forwarder's accumulated state. /// - /// The target name. - /// Whether the target was executed (not skipped). - /// Whether this is a custom target. - /// Whether the target is from a meta project. - /// Whether the target is from a NuGet package. - /// The reason the target was skipped, if applicable. - void AddTarget(string name, bool wasExecuted, bool isCustom, bool isMetaproj, bool isFromNugetCache, TargetSkipReason skipReason = TargetSkipReason.None); + void MergeWorkerData(IWorkerNodeTelemetryData data); + /// + /// Sends accumulated telemetry and resets internal state. + /// void FinalizeProcessing(LoggingContext loggingContext); } diff --git a/src/Build/TelemetryInfra/TelemetryForwarderProvider.cs b/src/Build/TelemetryInfra/TelemetryForwarderProvider.cs index 92175ef4a71..cb62a0422f1 100644 --- a/src/Build/TelemetryInfra/TelemetryForwarderProvider.cs +++ b/src/Build/TelemetryInfra/TelemetryForwarderProvider.cs @@ -1,10 +1,8 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -using System; using Microsoft.Build.BackEnd; using Microsoft.Build.BackEnd.Logging; -using Microsoft.Build.Framework; using Microsoft.Build.Framework.Telemetry; using Microsoft.Build.Shared; @@ -49,32 +47,51 @@ public void ShutdownComponent() _instance = null; } + /// + /// Active telemetry forwarder that accumulates worker node telemetry. + /// + /// + /// Thread-safe: in /m /mt mode, multiple instances share a single + /// singleton, so and + /// may be called concurrently from different node threads. + /// public class TelemetryForwarder : ITelemetryForwarder { - private readonly WorkerNodeTelemetryData _workerNodeTelemetryData = new(); + private WorkerNodeTelemetryData _workerNodeTelemetryData = new(); + private readonly LockType _lock = new(); // in future, this might be per event type public bool IsTelemetryCollected => true; - public void AddTask(string name, TimeSpan cumulativeExecutionTime, short executionsCount, long totalMemoryConsumed, bool isCustom, bool isFromNugetCache, string? taskFactoryName, string? taskHostRuntime) + public void MergeWorkerData(IWorkerNodeTelemetryData data) { - var key = GetKey(name, isCustom, false, isFromNugetCache); - _workerNodeTelemetryData.AddTask(key, cumulativeExecutionTime, executionsCount, totalMemoryConsumed, taskFactoryName, taskHostRuntime); - } - - public void AddTarget(string name, bool wasExecuted, bool isCustom, bool isMetaproj, bool isFromNugetCache, TargetSkipReason skipReason = TargetSkipReason.None) - { - var key = GetKey(name, isCustom, isMetaproj, isFromNugetCache); - _workerNodeTelemetryData.AddTarget(key, wasExecuted, skipReason); + lock (_lock) + { + _workerNodeTelemetryData.Add(data); + } } - private static TaskOrTargetTelemetryKey GetKey(string name, bool isCustom, bool isMetaproj, + internal static TaskOrTargetTelemetryKey GetKey(string name, bool isCustom, bool isMetaproj, bool isFromNugetCache) => new TaskOrTargetTelemetryKey(name, isCustom, isFromNugetCache, isMetaproj); public void FinalizeProcessing(LoggingContext loggingContext) { - WorkerNodeTelemetryEventArgs telemetryArgs = new(_workerNodeTelemetryData) + WorkerNodeTelemetryData snapshot; + + lock (_lock) + { + // Nothing accumulated since the last call — skip sending. + if (_workerNodeTelemetryData.IsEmpty) + { + return; + } + + snapshot = _workerNodeTelemetryData; + _workerNodeTelemetryData = new(); + } + + WorkerNodeTelemetryEventArgs telemetryArgs = new(snapshot) { BuildEventContext = loggingContext.BuildEventContext }; loggingContext.LogBuildEvent(telemetryArgs); } @@ -84,9 +101,7 @@ public class NullTelemetryForwarder : ITelemetryForwarder { public bool IsTelemetryCollected => false; - public void AddTask(string name, TimeSpan cumulativeExecutionTime, short executionsCount, long totalMemoryConsumed, bool isCustom, bool isFromNugetCache, string? taskFactoryName, string? taskHostRuntime) { } - - public void AddTarget(string name, bool wasExecuted, bool isCustom, bool isMetaproj, bool isFromNugetCache, TargetSkipReason skipReason = TargetSkipReason.None) { } + public void MergeWorkerData(IWorkerNodeTelemetryData data) { } public void FinalizeProcessing(LoggingContext loggingContext) { } } diff --git a/src/Framework/Telemetry/WorkerNodeTelemetryData.cs b/src/Framework/Telemetry/WorkerNodeTelemetryData.cs index d127a280d54..4d1f50bfc6e 100644 --- a/src/Framework/Telemetry/WorkerNodeTelemetryData.cs +++ b/src/Framework/Telemetry/WorkerNodeTelemetryData.cs @@ -14,6 +14,9 @@ public WorkerNodeTelemetryData(Dictionary + /// Merges all data from another into this instance. + /// public void Add(IWorkerNodeTelemetryData other) { foreach (var task in other.TasksExecutionData) @@ -27,10 +30,12 @@ public void Add(IWorkerNodeTelemetryData other) } } + /// + /// Adds or aggregates task execution data. + /// public void AddTask(TaskOrTargetTelemetryKey task, TimeSpan cumulativeExecutionTime, int executionsCount, long totalMemoryConsumption, string? factoryName, string? taskHostRuntime) { - TaskExecutionStats? taskExecutionStats; - if (!TasksExecutionData.TryGetValue(task, out taskExecutionStats)) + if (!TasksExecutionData.TryGetValue(task, out TaskExecutionStats? taskExecutionStats)) { taskExecutionStats = new(cumulativeExecutionTime, executionsCount, totalMemoryConsumption, factoryName, taskHostRuntime); TasksExecutionData[task] = taskExecutionStats; @@ -45,6 +50,9 @@ public void AddTask(TaskOrTargetTelemetryKey task, TimeSpan cumulativeExecutionT } } + /// + /// Adds or updates target execution data. + /// public void AddTarget(TaskOrTargetTelemetryKey target, bool wasExecuted, TargetSkipReason skipReason = TargetSkipReason.None) { if (TargetsExecutionData.TryGetValue(target, out var existingStats)) @@ -71,6 +79,8 @@ public void AddTarget(TaskOrTargetTelemetryKey target, bool wasExecuted, TargetS public WorkerNodeTelemetryData() : this([], []) { } + public bool IsEmpty => TasksExecutionData.Count == 0 && TargetsExecutionData.Count == 0; + public Dictionary TasksExecutionData { get; } public Dictionary TargetsExecutionData { get; } From 1a19fa3edd84060bf595df091282b3499088119f Mon Sep 17 00:00:00 2001 From: AR-May <67507805+AR-May@users.noreply.github.com> Date: Thu, 19 Mar 2026 12:58:23 +0100 Subject: [PATCH 2/3] Add tests, small refactoring --- .../Telemetry/Telemetry_Tests.cs | 65 +++++++++++++++++++ .../RequestBuilder/RequestBuilder.cs | 18 ++--- .../TelemetryForwarderProvider.cs | 3 - .../Telemetry/TaskOrTargetTelemetryKey.cs | 6 ++ 4 files changed, 80 insertions(+), 12 deletions(-) diff --git a/src/Build.UnitTests/Telemetry/Telemetry_Tests.cs b/src/Build.UnitTests/Telemetry/Telemetry_Tests.cs index d81776f1d77..0e68990075a 100644 --- a/src/Build.UnitTests/Telemetry/Telemetry_Tests.cs +++ b/src/Build.UnitTests/Telemetry/Telemetry_Tests.cs @@ -6,11 +6,14 @@ using System.Diagnostics; using System.Linq; using System.Threading; +using System.Threading.Tasks; +using Microsoft.Build.BackEnd.Logging; using Microsoft.Build.Execution; using Microsoft.Build.Framework; using Microsoft.Build.Framework.Telemetry; using Microsoft.Build.TelemetryInfra; using Microsoft.Build.UnitTests; +using Microsoft.Build.UnitTests.BackEnd; using Shouldly; using Xunit; using Xunit.Abstractions; @@ -470,5 +473,67 @@ public void BuildIncrementalityInfo_NoTargets_ClassifiedAsUnknown() incrementality.TotalTargetsCount.ShouldBe(0); incrementality.IncrementalityRatio.ShouldBe(0.0); } + + [Fact] + public void IsEmpty_TrueForDefault_FalseAfterAdd() + { + var data = new WorkerNodeTelemetryData(); + data.IsEmpty.ShouldBeTrue(); + + var targetKey = TaskOrTargetTelemetryKey.Create("Target1", isCustom: false, isFromNugetCache: false, isMetaproj: false); + data.AddTarget(targetKey, wasExecuted: true); + data.IsEmpty.ShouldBeFalse(); + } + + [Fact] + public void FinalizeProcessing_AfterMerge_ResetsState() + { + var forwarder = new TelemetryForwarderProvider.TelemetryForwarder(); + var loggingService = new EventRecordingLoggingService(); + + var loggingContext = new MockLoggingContext( + loggingService, + new BuildEventContext(1, 2, BuildEventContext.InvalidProjectContextId, 4)); + + // Merge some data. + var localData = new WorkerNodeTelemetryData(); + var key = TaskOrTargetTelemetryKey.Create("TestTarget", isCustom: true, isFromNugetCache: false, isMetaproj: false); + localData.AddTarget(key, wasExecuted: true); + forwarder.MergeWorkerData(localData); + + // First FinalizeProcessing should emit a telemetry event. + forwarder.FinalizeProcessing(loggingContext); + var telemetryEvents = loggingService.RecordedEvents.OfType().ToList(); + telemetryEvents.Count.ShouldBe(1); + telemetryEvents[0].WorkerNodeTelemetryData.TargetsExecutionData.ShouldContainKey(key); + + // Second FinalizeProcessing on an empty forwarder should be a no-op (state was reset). + forwarder.FinalizeProcessing(loggingContext); + loggingService.RecordedEvents.OfType().Count().ShouldBe(1, "No new event should be emitted after reset"); + + // Merge new data after reset — forwarder should still work. + var localData2 = new WorkerNodeTelemetryData(); + var key2 = TaskOrTargetTelemetryKey.Create("TestTarget2", isCustom: false, isFromNugetCache: false, isMetaproj: false); + localData2.AddTarget(key2, wasExecuted: false, skipReason: TargetSkipReason.ConditionWasFalse); + forwarder.MergeWorkerData(localData2); + + // Third FinalizeProcessing should emit only the new data. + forwarder.FinalizeProcessing(loggingContext); + var allTelemetryEvents = loggingService.RecordedEvents.OfType().ToList(); + allTelemetryEvents.Count.ShouldBe(2); + allTelemetryEvents[1].WorkerNodeTelemetryData.TargetsExecutionData.ShouldContainKey(key2); + allTelemetryEvents[1].WorkerNodeTelemetryData.TargetsExecutionData.ShouldNotContainKey(key, "Old data should not appear after reset"); + } + + /// + /// that records all calls + /// so tests can inspect emitted build events. + /// + private sealed class EventRecordingLoggingService : MockLoggingService, ILoggingService + { + public List RecordedEvents { get; } = []; + + void ILoggingService.LogBuildEvent(BuildEventArgs buildEvent) => RecordedEvents.Add(buildEvent); + } } } diff --git a/src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs b/src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs index b12cbed63d8..241423c8873 100644 --- a/src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs +++ b/src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs @@ -1287,7 +1287,7 @@ private void UpdateStatisticsPostBuild() } // Accumulate all telemetry into a local instance, then merge into the shared singleton once. - WorkerNodeTelemetryData localData = new(); + WorkerNodeTelemetryData telemetryData = new(); foreach (var projectTargetInstance in _requestEntry.RequestConfiguration.Project.Targets) { @@ -1319,15 +1319,15 @@ private void UpdateStatisticsPostBuild() (isFromNuget && FileClassifier.Shared.IsMicrosoftPackageInNugetCache(projectTargetInstance.Value.FullPath)); } - var key = TelemetryForwarderProvider.TelemetryForwarder.GetKey( - projectTargetInstance.Key, isCustom, isMetaprojTarget, isFromNuget); - localData.AddTarget(key, wasExecuted, skipReason); + var key = TaskOrTargetTelemetryKey.Create( + projectTargetInstance.Key, isCustom, isFromNuget, isMetaprojTarget); + telemetryData.AddTarget(key, wasExecuted, skipReason); } TaskRegistry taskReg = _requestEntry.RequestConfiguration.Project.TaskRegistry; CollectTasksStats(taskReg); - telemetryForwarder.MergeWorkerData(localData); + telemetryForwarder.MergeWorkerData(telemetryData); void CollectTasksStats(TaskRegistry taskRegistry) { @@ -1338,12 +1338,12 @@ void CollectTasksStats(TaskRegistry taskRegistry) foreach (TaskRegistry.RegisteredTaskRecord registeredTaskRecord in taskRegistry.TaskRegistrations.Values.SelectMany(record => record)) { - var key = TelemetryForwarderProvider.TelemetryForwarder.GetKey( + var key = TaskOrTargetTelemetryKey.Create( registeredTaskRecord.TaskIdentity.Name, registeredTaskRecord.ComputeIfCustom(), - isMetaproj: false, - registeredTaskRecord.IsFromNugetCache); - localData.AddTask( + registeredTaskRecord.IsFromNugetCache, + isMetaproj: false); + telemetryData.AddTask( key, registeredTaskRecord.Statistics.ExecutedTime, registeredTaskRecord.Statistics.ExecutedCount, diff --git a/src/Build/TelemetryInfra/TelemetryForwarderProvider.cs b/src/Build/TelemetryInfra/TelemetryForwarderProvider.cs index cb62a0422f1..dd851779bd9 100644 --- a/src/Build/TelemetryInfra/TelemetryForwarderProvider.cs +++ b/src/Build/TelemetryInfra/TelemetryForwarderProvider.cs @@ -71,9 +71,6 @@ public void MergeWorkerData(IWorkerNodeTelemetryData data) } } - internal static TaskOrTargetTelemetryKey GetKey(string name, bool isCustom, bool isMetaproj, - bool isFromNugetCache) - => new TaskOrTargetTelemetryKey(name, isCustom, isFromNugetCache, isMetaproj); public void FinalizeProcessing(LoggingContext loggingContext) { diff --git a/src/Framework/Telemetry/TaskOrTargetTelemetryKey.cs b/src/Framework/Telemetry/TaskOrTargetTelemetryKey.cs index 5647f2fdadd..40e942b9512 100644 --- a/src/Framework/Telemetry/TaskOrTargetTelemetryKey.cs +++ b/src/Framework/Telemetry/TaskOrTargetTelemetryKey.cs @@ -55,6 +55,12 @@ public TaskOrTargetTelemetryKey(string name) : this(name, false, false, false) { /// A telemetry key with the given name. public static explicit operator TaskOrTargetTelemetryKey(string key) => new(key); + /// + /// Creates a with all properties. + /// + internal static TaskOrTargetTelemetryKey Create(string name, bool isCustom, bool isFromNugetCache, bool isMetaproj) + => new(name, isCustom, isFromNugetCache, isMetaproj); + /// /// Gets the name of the task or target. /// From bca8fca3b8b9af42a69a6ff81bc01a0707741be3 Mon Sep 17 00:00:00 2001 From: AR-May <67507805+AR-May@users.noreply.github.com> Date: Fri, 20 Mar 2026 14:06:12 +0100 Subject: [PATCH 3/3] Remove TaskOrTargetTelemetryKey.Create() --- src/Build.UnitTests/Telemetry/Telemetry_Tests.cs | 6 +++--- .../BackEnd/Components/RequestBuilder/RequestBuilder.cs | 6 +++--- src/Framework/Telemetry/TaskOrTargetTelemetryKey.cs | 6 ------ 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/src/Build.UnitTests/Telemetry/Telemetry_Tests.cs b/src/Build.UnitTests/Telemetry/Telemetry_Tests.cs index 0e68990075a..0361e99ca0d 100644 --- a/src/Build.UnitTests/Telemetry/Telemetry_Tests.cs +++ b/src/Build.UnitTests/Telemetry/Telemetry_Tests.cs @@ -480,7 +480,7 @@ public void IsEmpty_TrueForDefault_FalseAfterAdd() var data = new WorkerNodeTelemetryData(); data.IsEmpty.ShouldBeTrue(); - var targetKey = TaskOrTargetTelemetryKey.Create("Target1", isCustom: false, isFromNugetCache: false, isMetaproj: false); + var targetKey = new TaskOrTargetTelemetryKey("Target1", isCustom: false, isFromNugetCache: false, isFromMetaProject: false); data.AddTarget(targetKey, wasExecuted: true); data.IsEmpty.ShouldBeFalse(); } @@ -497,7 +497,7 @@ public void FinalizeProcessing_AfterMerge_ResetsState() // Merge some data. var localData = new WorkerNodeTelemetryData(); - var key = TaskOrTargetTelemetryKey.Create("TestTarget", isCustom: true, isFromNugetCache: false, isMetaproj: false); + var key = new TaskOrTargetTelemetryKey("TestTarget", isCustom: true, isFromNugetCache: false, isFromMetaProject: false); localData.AddTarget(key, wasExecuted: true); forwarder.MergeWorkerData(localData); @@ -513,7 +513,7 @@ public void FinalizeProcessing_AfterMerge_ResetsState() // Merge new data after reset — forwarder should still work. var localData2 = new WorkerNodeTelemetryData(); - var key2 = TaskOrTargetTelemetryKey.Create("TestTarget2", isCustom: false, isFromNugetCache: false, isMetaproj: false); + var key2 = new TaskOrTargetTelemetryKey("TestTarget2", isCustom: false, isFromNugetCache: false, isFromMetaProject: false); localData2.AddTarget(key2, wasExecuted: false, skipReason: TargetSkipReason.ConditionWasFalse); forwarder.MergeWorkerData(localData2); diff --git a/src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs b/src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs index 241423c8873..a6a76205768 100644 --- a/src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs +++ b/src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs @@ -1319,7 +1319,7 @@ private void UpdateStatisticsPostBuild() (isFromNuget && FileClassifier.Shared.IsMicrosoftPackageInNugetCache(projectTargetInstance.Value.FullPath)); } - var key = TaskOrTargetTelemetryKey.Create( + var key = new TaskOrTargetTelemetryKey( projectTargetInstance.Key, isCustom, isFromNuget, isMetaprojTarget); telemetryData.AddTarget(key, wasExecuted, skipReason); } @@ -1338,11 +1338,11 @@ void CollectTasksStats(TaskRegistry taskRegistry) foreach (TaskRegistry.RegisteredTaskRecord registeredTaskRecord in taskRegistry.TaskRegistrations.Values.SelectMany(record => record)) { - var key = TaskOrTargetTelemetryKey.Create( + var key = new TaskOrTargetTelemetryKey( registeredTaskRecord.TaskIdentity.Name, registeredTaskRecord.ComputeIfCustom(), registeredTaskRecord.IsFromNugetCache, - isMetaproj: false); + isFromMetaProject: false); telemetryData.AddTask( key, registeredTaskRecord.Statistics.ExecutedTime, diff --git a/src/Framework/Telemetry/TaskOrTargetTelemetryKey.cs b/src/Framework/Telemetry/TaskOrTargetTelemetryKey.cs index 40e942b9512..5647f2fdadd 100644 --- a/src/Framework/Telemetry/TaskOrTargetTelemetryKey.cs +++ b/src/Framework/Telemetry/TaskOrTargetTelemetryKey.cs @@ -55,12 +55,6 @@ public TaskOrTargetTelemetryKey(string name) : this(name, false, false, false) { /// A telemetry key with the given name. public static explicit operator TaskOrTargetTelemetryKey(string key) => new(key); - /// - /// Creates a with all properties. - /// - internal static TaskOrTargetTelemetryKey Create(string name, bool isCustom, bool isFromNugetCache, bool isMetaproj) - => new(name, isCustom, isFromNugetCache, isMetaproj); - /// /// Gets the name of the task or target. ///