diff --git a/dir.targets b/dir.targets index 8643a272855..1c60e26c4d2 100644 --- a/dir.targets +++ b/dir.targets @@ -37,7 +37,7 @@ diff --git a/src/Framework/BuildEventArgs.cs b/src/Framework/BuildEventArgs.cs index c72e5a19158..1797d5abe01 100644 --- a/src/Framework/BuildEventArgs.cs +++ b/src/Framework/BuildEventArgs.cs @@ -326,7 +326,7 @@ internal virtual void CreateFromStream(BinaryReader reader, int version) [OnDeserializing] private void SetBuildEventContextDefaultBeforeSerialization(StreamingContext sc) { - // Dont want to create a new one here as default all the time as that would be a lot of + // Don't want to create a new one here as default all the time as that would be a lot of // possibly useless allocations _buildEventContext = null; } @@ -351,4 +351,3 @@ private void SetBuildEventContextDefaultAfterSerialization(StreamingContext sc) #endregion } } - diff --git a/src/Framework/BuildEventContext.cs b/src/Framework/BuildEventContext.cs index 9862e88fa33..1396963a4bc 100644 --- a/src/Framework/BuildEventContext.cs +++ b/src/Framework/BuildEventContext.cs @@ -220,8 +220,8 @@ public override int GetHashCode() /// Compare a BuildEventContext with this BuildEventContext. /// A build event context is compared in the following way. /// - /// 1. If the obect references are the same the contexts are equivilant - /// 2. If the object type is the same and the Id values in the context are the same, the contexts are equivilant + /// 1. If the object references are the same the contexts are equivalent + /// 2. If the object type is the same and the Id values in the context are the same, the contexts are equivalent /// /// /// diff --git a/src/Framework/BuildFinishedEventArgs.cs b/src/Framework/BuildFinishedEventArgs.cs index 7f9e9a7a121..feebd6bf0cb 100644 --- a/src/Framework/BuildFinishedEventArgs.cs +++ b/src/Framework/BuildFinishedEventArgs.cs @@ -39,7 +39,7 @@ protected BuildFinishedEventArgs() } /// - /// Constructor to initialize all paramterers. + /// Constructor to initialize all parameters. /// Sender field cannot be set here and is assumed to be "MSBuild" /// /// text message diff --git a/src/Framework/BuildMessageEventArgs.cs b/src/Framework/BuildMessageEventArgs.cs index f662b21c56d..353f3948bf7 100644 --- a/src/Framework/BuildMessageEventArgs.cs +++ b/src/Framework/BuildMessageEventArgs.cs @@ -14,8 +14,6 @@ namespace Microsoft.Build.Framework /// /// This enumeration provides three levels of importance for messages. /// - /// - /// [Serializable] public enum MessageImportance { @@ -59,7 +57,7 @@ protected BuildMessageEventArgs() } /// - /// This constuctor allows all event data to be initialized + /// This constructor allows all event data to be initialized /// /// text message /// help keyword @@ -77,7 +75,7 @@ MessageImportance importance } /// - /// This constuctor allows a timestamp to be set + /// This constructor allows a timestamp to be set /// /// text message /// help keyword @@ -98,7 +96,7 @@ DateTime eventTimestamp } /// - /// This constuctor allows a timestamp to be set + /// This constructor allows a timestamp to be set /// /// text message /// help keyword diff --git a/src/Framework/IBuildEngine.cs b/src/Framework/IBuildEngine.cs index 1925f5927bc..1e762742acd 100644 --- a/src/Framework/IBuildEngine.cs +++ b/src/Framework/IBuildEngine.cs @@ -55,7 +55,7 @@ bool ContinueOnError } /// - /// Retrieves the line number of the task node withing the project file that called it. + /// Retrieves the line number of the task node within the project file that called it. /// int LineNumberOfTaskNode { @@ -63,7 +63,7 @@ int LineNumberOfTaskNode } /// - /// Retrieves the line number of the task node withing the project file that called it. + /// Retrieves the line number of the task node within the project file that called it. /// int ColumnNumberOfTaskNode { diff --git a/src/Framework/LazyFormattedBuildEventArgs.cs b/src/Framework/LazyFormattedBuildEventArgs.cs index b2eb15efe00..6d8b52f77c8 100644 --- a/src/Framework/LazyFormattedBuildEventArgs.cs +++ b/src/Framework/LazyFormattedBuildEventArgs.cs @@ -35,7 +35,7 @@ public class LazyFormattedBuildEventArgs : BuildEventArgs private Object _locker; /// - /// This constuctor allows all event data to be initialized. + /// This constructor allows all event data to be initialized. /// /// text message. /// help keyword. @@ -51,7 +51,7 @@ string senderName } /// - /// This constuctor that allows message arguments that are lazily formatted. + /// This constructor that allows message arguments that are lazily formatted. /// /// text message. /// help keyword. diff --git a/src/Framework/ProjectStartedEventArgs.cs b/src/Framework/ProjectStartedEventArgs.cs index d87c3aaf515..8954bd0ee65 100644 --- a/src/Framework/ProjectStartedEventArgs.cs +++ b/src/Framework/ProjectStartedEventArgs.cs @@ -527,7 +527,7 @@ internal override void CreateFromStream(BinaryReader reader, int version) private void SetDefaultsBeforeSerialization(StreamingContext sc) { _projectId = InvalidProjectId; - // Dont want to set the default before deserialization is completed to a new event context because + // Don't want to set the default before deserialization is completed to a new event context because // that would most likely be a lot of wasted allocations _parentProjectBuildEventContext = null; } diff --git a/src/Shared/CanonicalError.cs b/src/Shared/CanonicalError.cs index 18a948f830b..2215fb0a997 100644 --- a/src/Shared/CanonicalError.cs +++ b/src/Shared/CanonicalError.cs @@ -293,7 +293,7 @@ internal static Parts Parse(string message) // -------------- ------------ ------- ------ ---------------------------------------------- // Origin SubCategory Cat. Code Text // - // To accomodate absolute filenames in Origin, tolerate a colon in the second position + // To accommodate absolute filenames in Origin, tolerate a colon in the second position // as long as its preceded by a letter. // // Localization Note: diff --git a/src/Shared/FrameworkLocationHelper.cs b/src/Shared/FrameworkLocationHelper.cs index 75b69eed372..708b7a39f45 100644 --- a/src/Shared/FrameworkLocationHelper.cs +++ b/src/Shared/FrameworkLocationHelper.cs @@ -559,7 +559,7 @@ internal static string GetPathToDotNetFramework(Version version, DotNetFramework /// Check the registry key and value to see if the .net Framework is installed on the machine. /// /// Registry path to look for the value - /// Key to retreive the value from + /// Key to retrieve the value from /// True if the registry key is 1 false if it is not there. This method also return true if the complus enviornment variables are set. private static bool CheckForFrameworkInstallation(string registryEntryToCheckInstall, string registryValueToCheckInstall) { @@ -1386,7 +1386,7 @@ public virtual string GetPathToDotNetFrameworkReferenceAssemblies() { if (this.pathToDotNetFrameworkReferenceAssemblies == null) { - // when a user requests the 40 reference assembly path we dont need to read the redist list because we will not be chaining so we may as well just + // when a user requests the 40 reference assembly path we don't need to read the redist list because we will not be chaining so we may as well just // generate the path and save us some time. string referencePath = GenerateReferenceAssemblyPath(FrameworkLocationHelper.programFilesReferenceAssemblyLocation, this.FrameworkName); if (Directory.Exists(referencePath)) diff --git a/src/Shared/NodeEndpointOutOfProcBase.cs b/src/Shared/NodeEndpointOutOfProcBase.cs index ea546267911..bdc38a453e4 100644 --- a/src/Shared/NodeEndpointOutOfProcBase.cs +++ b/src/Shared/NodeEndpointOutOfProcBase.cs @@ -389,7 +389,7 @@ private void PacketPumpProc() catch (IOException e) { // We will get here when: - // 1. The host (OOP main node) connects to us, it immediately checks for user priviledges + // 1. The host (OOP main node) connects to us, it immediately checks for user privileges // and if they don't match it disconnects immediately leaving us still trying to read the blank handshake // 2. The host is too old sending us bits we automatically reject in the handshake CommunicationsUtilities.Trace("Client connection failed but we will wait for another connection. Exception: {0}", e.Message); diff --git a/src/Shared/TaskLoggingHelper.cs b/src/Shared/TaskLoggingHelper.cs index bb78646e085..575298f1a39 100644 --- a/src/Shared/TaskLoggingHelper.cs +++ b/src/Shared/TaskLoggingHelper.cs @@ -1373,7 +1373,7 @@ public override object InitializeLifetimeService() ILease lease = (ILease)base.InitializeLifetimeService(); // Set how long a lease should be initially. Once a lease expires - // the remote object will be disconnected and it will be marked as being availiable + // the remote object will be disconnected and it will be marked as being available // for garbage collection int initialLeaseTime = 1; @@ -1430,7 +1430,7 @@ public void MarkAsInactive() lock (_locker) { // Clear out the sponsor (who is responsible for keeping the TaskLoggingHelper remoting lease alive until the task is done) - // this will be null if the engineproxy was never sent across an appdomain boundry. + // this will be null if the engineproxy was never sent across an appdomain boundary. if (_sponsor != null) { ILease lease = (ILease)RemotingServices.GetLifetimeService(this); diff --git a/src/Shared/TypeLoader.cs b/src/Shared/TypeLoader.cs index 16ea874b64b..0ce638f6c3f 100644 --- a/src/Shared/TypeLoader.cs +++ b/src/Shared/TypeLoader.cs @@ -281,7 +281,7 @@ internal LoadedType GetLoadedTypeByTypeName(string typeName) { Type type = null; - // Maybe we've already cracked open this assembly before. Check to see if the typeName is in the list we dont look for partial matches here + // Maybe we've already cracked open this assembly before. Check to see if the typeName is in the list we don't look for partial matches here // this is an optimization. bool foundType = _typeNameToType.TryGetValue(typeName, out type); if (!foundType) diff --git a/src/Utilities/AppDomainIsolatedTask.cs b/src/Utilities/AppDomainIsolatedTask.cs index 4caf49da856..7a0a4b716a6 100644 --- a/src/Utilities/AppDomainIsolatedTask.cs +++ b/src/Utilities/AppDomainIsolatedTask.cs @@ -161,7 +161,7 @@ protected string HelpKeywordPrefix public abstract bool Execute(); /// - /// Overriden to give tasks deriving from this class infinite lease time. Otherwise we end up with a limited + /// Overridden to give tasks deriving from this class infinite lease time. Otherwise we end up with a limited /// lease (5 minutes I think) and task instances can expire if they take long time processing. /// [SecurityCritical] diff --git a/src/Utilities/MuxLogger.cs b/src/Utilities/MuxLogger.cs index 4013fb1ead2..e92e86cc235 100644 --- a/src/Utilities/MuxLogger.cs +++ b/src/Utilities/MuxLogger.cs @@ -43,8 +43,8 @@ namespace Microsoft.Build.Utilities /// A new event source will be created so that the logger passed in can be registered to that event source /// If the build started event has already been logged the MUX logger will create a new BuildStartedEvent and send that to the event source. /// - /// UnRegisterLogger: - /// When a build submission is completed the UnregisterLogger method will be called with the submission ID. + /// UnregisterLoggers: + /// When a build submission is completed the UnregisterLoggers method will be called with the submission ID. /// At this point we will look up the success state of the project finished event for the submission ID and log a build finished event to the logger. /// The event source will be cleaned up. This may be interesting because the unregister will come from a thread other than what is doing the logging. /// This may create a Synchronization issue, if unregister is called while events are being logged. diff --git a/src/Utilities/TaskItem.cs b/src/Utilities/TaskItem.cs index a168d8e59c7..bcd83973901 100644 --- a/src/Utilities/TaskItem.cs +++ b/src/Utilities/TaskItem.cs @@ -408,7 +408,7 @@ public override string ToString() } /// - /// Overriden to give this class infinite lease time. Otherwise we end up with a limited + /// Overridden to give this class infinite lease time. Otherwise we end up with a limited /// lease (5 minutes I think) and instances can expire if they take long time processing. /// [SecurityCritical] diff --git a/src/Utilities/ToolLocationHelper.cs b/src/Utilities/ToolLocationHelper.cs index 3d9aedd3431..5c97022a658 100644 --- a/src/Utilities/ToolLocationHelper.cs +++ b/src/Utilities/ToolLocationHelper.cs @@ -146,7 +146,7 @@ public static class ToolLocationHelper private static object s_locker = new Object(); /// - /// Cache the results of calling the GetPathToRefernceAssemblies so that we do not recaculate it everytime we call the method + /// Cache the results of calling the GetPathToRefernceAssemblies so that we do not recalculate it every time we call the method /// private static Dictionary> s_cachedReferenceAssemblyPaths; @@ -1569,7 +1569,7 @@ internal static string VersionToDotNetReferenceAssemblies(VersionToPath PathToDo /// /// Generate the list of reference assembly paths for well known .net framework versions /// - /// Target framework moniker class wich contains the targetframeworkVersion + /// Target framework moniker class which contains the targetframeworkVersion /// A collection of strings which list the chained reference assembly paths with the highest version being first internal static IList HandleLegacyDotNetFrameworkReferenceAssemblyPaths(VersionToPath PathToDotNetFramework, VersionToPath PathToReferenceAssemblies, FrameworkNameVersioning frameworkName) { @@ -1586,7 +1586,7 @@ internal static IList HandleLegacyDotNetFrameworkReferenceAssemblyPaths( return HandleLegacy35(PathToDotNetFramework, PathToReferenceAssemblies); } - // Dont know the framework send back an empty list because it does not exist + // Don't know the framework send back an empty list because it does not exist return new List(); } @@ -2457,11 +2457,11 @@ private static void GatherSDKListFromRegistry(string registryRoot, Dictionary - /// Get the disk locations to search for sdks under. This can be overidden by an environment variable + /// Get the disk locations to search for sdks under. This can be overridden by an environment variable /// private static void GetDefaultSDKDiskRoots(List diskRoots) { - // The order is important here becuase we want to look in the users location first before the non privileged location. + // The order is important here because we want to look in the users location first before the non privileged location. // We need this so that a user can also have an sdk installed in a non privileged location string userLocalAppData = Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData); diff --git a/src/Utilities/ToolTask.cs b/src/Utilities/ToolTask.cs index dc16313ddd5..85e14fc9af8 100644 --- a/src/Utilities/ToolTask.cs +++ b/src/Utilities/ToolTask.cs @@ -1083,7 +1083,7 @@ private void KillToolProcessOnTimeout(Process proc, bool isBeingCancelled) } // wait until the process finishes exiting/getting killed. - // We don't want to wait forever here because the task is already supposed to be dieing, we just want to give it long enought + // We don't want to wait forever here because the task is already supposed to be dieing, we just want to give it long enough // to try and flush what it can and stop. If it cannot do that in a reasonable time frame then we will just ignore it. int timeout = 5000; string timeoutFromEnvironment = Environment.GetEnvironmentVariable("MSBUILDTOOLTASKCANCELPROCESSWAITTIMEOUT"); @@ -1534,7 +1534,7 @@ public override bool Execute() } // Log the environment. We do this up here, - // rather than later where the enviroment is set, + // rather than later where the environment is set, // so that it appears before the command line is logged. bool alreadyLoggedEnvironmentHeader = false; diff --git a/src/dirs.proj b/src/dirs.proj index d79da41495a..3bcb30ff1e4 100644 --- a/src/dirs.proj +++ b/src/dirs.proj @@ -18,7 +18,7 @@ - + $(BaseOutputPathWithConfig)