diff --git a/eng/Common.globalconfig b/eng/Common.globalconfig index fd878420d57..7f906cd130f 100644 --- a/eng/Common.globalconfig +++ b/eng/Common.globalconfig @@ -411,7 +411,7 @@ dotnet_diagnostic.CA2234.severity = none dotnet_diagnostic.CA2235.severity = none # Provide correct arguments to formatting methods -dotnet_diagnostic.CA2241.severity = suggestion +dotnet_diagnostic.CA2241.severity = warning # Test for NaN correctly dotnet_diagnostic.CA2242.severity = warning diff --git a/src/Build.UnitTests/FileUtilitiesRegex_Tests.cs b/src/Build.UnitTests/FileUtilitiesRegex_Tests.cs index 6eb89d1cbf5..fcc4caf2009 100644 --- a/src/Build.UnitTests/FileUtilitiesRegex_Tests.cs +++ b/src/Build.UnitTests/FileUtilitiesRegex_Tests.cs @@ -525,66 +525,19 @@ public void MatchLengthStartWithUncPatternNoShare() } [Fact] - public void UncPatternEmptyString_LegacyRegex() + public void PatternEmptyString_LegacyRegex() { - string winDirectory = string.Format("", _directoryStart); - string unixDirectory = string.Format("", _altDirectoryStart); - - UncPattern.IsMatch(winDirectory).ShouldBe(false); - UncPattern.IsMatch(unixDirectory).ShouldBe(false); - } - - [Fact] - public void UncPatternEmptyString() - { - string winDirectory = string.Format("", _directoryStart); - string unixDirectory = string.Format("", _altDirectoryStart); - - FileUtilitiesRegex.IsUncPattern(winDirectory).ShouldBe(false); - FileUtilitiesRegex.IsUncPattern(unixDirectory).ShouldBe(false); + UncPattern.IsMatch(string.Empty).ShouldBeFalse(); + StartsWithUncPattern.IsMatch(string.Empty).ShouldBeFalse(); + StartsWithUncPattern.Match(string.Empty).Success.ShouldBeFalse(); } [Fact] - public void StartWithUncPatternEmptyString_LegacyRegex() + public void PatternEmptyString() { - string winDirectory = string.Format("", _directoryStart); - string unixDirectory = string.Format("", _altDirectoryStart); - - StartsWithUncPattern.IsMatch(winDirectory).ShouldBe(false); - StartsWithUncPattern.IsMatch(unixDirectory).ShouldBe(false); - } - - [Fact] - public void StartsWithUncPatternEmptyString() - { - string winDirectory = string.Format("", _directoryStart); - string unixDirectory = string.Format("", _altDirectoryStart); - - FileUtilitiesRegex.StartsWithUncPattern(winDirectory).ShouldBe(false); - FileUtilitiesRegex.StartsWithUncPattern(unixDirectory).ShouldBe(false); - } - - [Fact] - public void MatchLengthStartWithUncPatternEmptyString_LegacyRegex() - { - string winDirectory = string.Format("", _directoryStart); - string unixDirectory = string.Format("", _altDirectoryStart); - - var match = StartsWithUncPattern.Match(winDirectory); - match.Success.ShouldBeFalse(); - - match = StartsWithUncPattern.Match(unixDirectory); - match.Success.ShouldBeFalse(); - } - - [Fact] - public void MatchLengthStartWithUncPatternEmptyString() - { - string winDirectory = string.Format("", _directoryStart); - string unixDirectory = string.Format("", _altDirectoryStart); - - FileUtilitiesRegex.StartsWithUncPatternMatchLength(winDirectory).ShouldBe(-1); - FileUtilitiesRegex.StartsWithUncPatternMatchLength(unixDirectory).ShouldBe(-1); + FileUtilitiesRegex.IsUncPattern(string.Empty).ShouldBeFalse(); + FileUtilitiesRegex.StartsWithUncPattern(string.Empty).ShouldBeFalse(); + FileUtilitiesRegex.StartsWithUncPatternMatchLength(string.Empty).ShouldBe(-1); } } }