diff --git a/src/Build.OM.UnitTests/Construction/ProjectExtensionsElement_Tests.cs b/src/Build.OM.UnitTests/Construction/ProjectExtensionsElement_Tests.cs index d2333b11e5d..31dd3783930 100644 --- a/src/Build.OM.UnitTests/Construction/ProjectExtensionsElement_Tests.cs +++ b/src/Build.OM.UnitTests/Construction/ProjectExtensionsElement_Tests.cs @@ -14,8 +14,7 @@ namespace Microsoft.Build.UnitTests.OM.Construction { /// - // Tests for the ProjectExtensionsElement class. - /// Tests for the class + /// Tests for the class. /// public class ProjectExtensionsElement_Tests { diff --git a/src/Build.OM.UnitTests/ObjectModelRemoting/LinkedEvaluationModify_Tests.cs b/src/Build.OM.UnitTests/ObjectModelRemoting/LinkedEvaluationModify_Tests.cs index 1d403b81f7b..d0f1b2125c9 100644 --- a/src/Build.OM.UnitTests/ObjectModelRemoting/LinkedEvaluationModify_Tests.cs +++ b/src/Build.OM.UnitTests/ObjectModelRemoting/LinkedEvaluationModify_Tests.cs @@ -122,7 +122,7 @@ public void ProjectItemModify() new KeyValuePair("b", "bValue"), }; - /// test AddItems + // test AddItems // add a new files in the view, ensure it is added correctly and also the real object will immediately reflect that add as well Assert.Null(pair.GetSingleItemWithVerify(ObjectType.View, "foo.cpp")); var fooView = pair.AddSingleItemWithVerify(ObjectType.View, "cpp", "foo.cpp"); diff --git a/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectItemDefinitionLink.cs b/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectItemDefinitionLink.cs index 57a61cef3b5..ae0dcaa1d05 100644 --- a/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectItemDefinitionLink.cs +++ b/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectItemDefinitionLink.cs @@ -17,8 +17,7 @@ public override ProjectItemDefinition CreateLinkedObject(IImportHolder holder) return holder.Linker.LinkFactory.Create(link); } - - /// ProjectItemDefinitionLink remoting + // ProjectItemDefinitionLink remoting public MockProjectLinkRemoter Project => this.OwningCollection.Export(this.Source.Project); public string ItemType => this.Source.ItemType; public ICollection Metadata => this.OwningCollection.ExportCollection(this.Source.Metadata); diff --git a/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectItemLink.cs b/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectItemLink.cs index e17f305af80..d9fc77084ea 100644 --- a/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectItemLink.cs +++ b/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectItemLink.cs @@ -18,8 +18,7 @@ public override ProjectItem CreateLinkedObject(IImportHolder holder) return holder.Linker.LinkFactory.Create(link); } - - /// ProjectItemLink remoting + // ProjectItemLink remoting public MockProjectLinkRemoter Project => this.OwningCollection.Export(this.Source.Project); public MockProjectItemElementLinkRemoter Xml => (MockProjectItemElementLinkRemoter)this.OwningCollection.ExportElement(this.Source.Xml); public string EvaluatedInclude => this.Source.EvaluatedInclude; diff --git a/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectLink.cs b/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectLink.cs index 9b178dee6a3..2eaf1a6fa6f 100644 --- a/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectLink.cs +++ b/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectLink.cs @@ -24,8 +24,7 @@ public override Project CreateLinkedObject(IImportHolder holder) return holder.Linker.LinkFactory.Create(link); } - - /// ProjectLink remoting + // ProjectLink remoting public MockProjectElementLinkRemoter Xml => this.OwningCollection.ExportElement(this.Source.Xml); public bool ThrowInsteadOfSplittingItemElement { get => this.Source.ThrowInsteadOfSplittingItemElement; set => this.Source.ThrowInsteadOfSplittingItemElement = value; } diff --git a/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectMetadataLink.cs b/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectMetadataLink.cs index b662f3e277d..1399fb28746 100644 --- a/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectMetadataLink.cs +++ b/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectMetadataLink.cs @@ -17,8 +17,7 @@ public override ProjectMetadata CreateLinkedObject(IImportHolder holder) return holder.Linker.LinkFactory.Create(link); } - - /// ProjectMetadataLink remoting + // ProjectMetadataLink remoting public object Parent { get diff --git a/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectPropertyLink.cs b/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectPropertyLink.cs index e507f046aad..cea7656b893 100644 --- a/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectPropertyLink.cs +++ b/src/Build.OM.UnitTests/ObjectModelRemoting/RemoteProjectsProviderMock/EvaluationLinkMocks/MockProjectPropertyLink.cs @@ -17,8 +17,7 @@ public override ProjectProperty CreateLinkedObject(IImportHolder holder) return holder.Linker.LinkFactory.Create(link); } - - /// ProjectPropertyLink remoting + // ProjectPropertyLink remoting public MockProjectLinkRemoter Project => this.OwningCollection.Export(this.Source.Project); public MockProjectPropertyElementLinkRemoter Xml => (MockProjectPropertyElementLinkRemoter)this.ExportElement(this.Source.Xml); public string Name => this.Source.Name; diff --git a/src/Build.UnitTests/BackEnd/BuildManager_Tests.cs b/src/Build.UnitTests/BackEnd/BuildManager_Tests.cs index 5d06ef38401..eae0afe3751 100644 --- a/src/Build.UnitTests/BackEnd/BuildManager_Tests.cs +++ b/src/Build.UnitTests/BackEnd/BuildManager_Tests.cs @@ -3802,9 +3802,12 @@ public void OutOfProcFileBasedP2PBuildSucceeds() } } - /// When a ProjectInstance based BuildRequestData is built out of proc, the node should + /// + /// When a based is built out of proc, the node should /// not reload it from disk but instead fully utilize the entire translate project instance state - /// to do the build + /// to do the build. + /// + /// to serialize the entire project instance state; otherwise, . [Theory] [InlineData(false)] [InlineData(true)] diff --git a/src/Build/Construction/ProjectRootElement.cs b/src/Build/Construction/ProjectRootElement.cs index 7d183e2c759..3463e872980 100644 --- a/src/Build/Construction/ProjectRootElement.cs +++ b/src/Build/Construction/ProjectRootElement.cs @@ -45,7 +45,7 @@ namespace Microsoft.Build.Construction [DebuggerDisplay("{FullPath} #Children={Count} DefaultTargets={DefaultTargets} ToolsVersion={ToolsVersion} InitialTargets={InitialTargets} ExplicitlyLoaded={IsExplicitlyLoaded}")] public class ProjectRootElement : ProjectElementContainer { - /// Constants for default (empty) project file. + // Constants for default (empty) project file. private const string EmptyProjectFileContent = "{0}\r\n"; private const string EmptyProjectFileXmlDeclaration = "\r\n"; private const string EmptyProjectFileToolsVersion = " ToolsVersion=\"" + MSBuildConstants.CurrentToolsVersion + "\""; diff --git a/src/Build/Utilities/EngineFileUtilities.cs b/src/Build/Utilities/EngineFileUtilities.cs index 5ee535bc9b7..ca67dcbacfb 100644 --- a/src/Build/Utilities/EngineFileUtilities.cs +++ b/src/Build/Utilities/EngineFileUtilities.cs @@ -227,9 +227,14 @@ private static bool MatchesLazyWildcard(string fileSpec) return _regexMatchCache.Value.GetOrAdd(fileSpec, file => s_lazyWildCardExpansionRegexes.Any(regex => regex.IsMatch(fileSpec))); } - /// Returns a Func that will return true IFF its argument matches any of the specified filespecs - /// Assumes filespec may be escaped, so it unescapes it + /// + /// Returns a Func that will return true IFF its argument matches any of the specified filespecs. + /// Assumes filespec may be escaped, so it unescapes it. /// The returned function makes no escaping assumptions or escaping operations. Its callers should control escaping. + /// + /// + /// + /// A Func that will return true IFF its argument matches any of the specified filespecs. internal static Func GetFileSpecMatchTester(IList filespecsEscaped, string currentDirectory) { var matchers = filespecsEscaped diff --git a/src/Tasks.UnitTests/AssemblyDependency/FilePrimary.cs b/src/Tasks.UnitTests/AssemblyDependency/FilePrimary.cs index 203d24a251f..e7f155ac3b0 100644 --- a/src/Tasks.UnitTests/AssemblyDependency/FilePrimary.cs +++ b/src/Tasks.UnitTests/AssemblyDependency/FilePrimary.cs @@ -269,7 +269,7 @@ public void ExistsPromotedDependencyInTheBlackList() /// In this case, /// - A single primary file reference to assembly version 1.0.0.0 was passed in. /// - An app.config was passed in that promotes a *different* assembly version name from - // 1.0.0.0 to 2.0.0.0 + /// 1.0.0.0 to 2.0.0.0 /// - Version 1.0.0.0 of the file exists. /// - Version 2.0.0.0 of the file exists. /// Expected: diff --git a/src/Tasks.UnitTests/AssemblyDependency/NonSpecificVersionStrictPrimary.cs b/src/Tasks.UnitTests/AssemblyDependency/NonSpecificVersionStrictPrimary.cs index fcb3071ded9..f3eb199906b 100644 --- a/src/Tasks.UnitTests/AssemblyDependency/NonSpecificVersionStrictPrimary.cs +++ b/src/Tasks.UnitTests/AssemblyDependency/NonSpecificVersionStrictPrimary.cs @@ -87,7 +87,7 @@ public void Exists() /// In this case, /// - A single primary non-version-strict reference was passed in to assembly version 1.0.0.0 /// - An app.config was passed in that promotes a *different* assembly version name from - // 1.0.0.0 to 2.0.0.0 + /// 1.0.0.0 to 2.0.0.0 /// - Version 1.0.0.0 of the file exists. /// - Version 2.0.0.0 of the file exists. /// Expected: diff --git a/src/Tasks.UnitTests/AssemblyDependency/StronglyNamedDependencyAppConfig.cs b/src/Tasks.UnitTests/AssemblyDependency/StronglyNamedDependencyAppConfig.cs index 0ff90cdeec1..c4f78439042 100644 --- a/src/Tasks.UnitTests/AssemblyDependency/StronglyNamedDependencyAppConfig.cs +++ b/src/Tasks.UnitTests/AssemblyDependency/StronglyNamedDependencyAppConfig.cs @@ -169,7 +169,7 @@ public void ExistsPromotedDependencyInTheBlackList() /// - A single reference to DependsOnUnified was passed in. /// - This assembly depends on version 1.0.0.0 of UnifyMe. /// - An app.config was passed in that promotes a *different* assembly version name from - // 1.0.0.0 to 2.0.0.0 + /// 1.0.0.0 to 2.0.0.0 /// - Version 1.0.0.0 of the file exists. /// - Version 2.0.0.0 of the file exists. /// Expected: diff --git a/src/Tasks.UnitTests/AssignProjectConfiguration_Tests.cs b/src/Tasks.UnitTests/AssignProjectConfiguration_Tests.cs index 7cd55cfd289..a9535bfac91 100644 --- a/src/Tasks.UnitTests/AssignProjectConfiguration_Tests.cs +++ b/src/Tasks.UnitTests/AssignProjectConfiguration_Tests.cs @@ -355,7 +355,7 @@ public void VerifyDefaultValueDefaultToVcxPlatformMappings() AssignProjectConfiguration assignProjectConfiguration = new AssignProjectConfiguration(); - /// Test defaults with nothing set + // Test defaults with nothing set string actualDefaultToVcxPlatformMapping = assignProjectConfiguration.DefaultToVcxPlatformMapping; Assert.Equal(actualDefaultToVcxPlatformMapping, expectedDefaultToVcxPlatformMapping);