From 6481072e7f3071b0adee270727e829e118af4c75 Mon Sep 17 00:00:00 2001 From: elachlan <2433737+elachlan@users.noreply.github.com> Date: Sat, 8 Jan 2022 17:31:41 +1000 Subject: [PATCH 1/2] SA1014 Opening generic brackets should not be preceded by a space --- .../Construction/SolutionProjectGenerator_Tests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Build.UnitTests/Construction/SolutionProjectGenerator_Tests.cs b/src/Build.UnitTests/Construction/SolutionProjectGenerator_Tests.cs index 124fd26cc45..38332b135ae 100644 --- a/src/Build.UnitTests/Construction/SolutionProjectGenerator_Tests.cs +++ b/src/Build.UnitTests/Construction/SolutionProjectGenerator_Tests.cs @@ -2351,7 +2351,7 @@ public void BeforeTargetsFromImportCanHookDynamicTarget() projectInstance.Targets["MyTarget"].BeforeTargets.ShouldBe("DynamicTraversalTarget"); MockLogger mockLogger = new MockLogger(output); - projectInstance.Build(targetsToBuild, new List { mockLogger }) + projectInstance.Build(targetsToBuild, new List { mockLogger }) .ShouldBeFalse("The solution build should have failed due to a missing project"); mockLogger.AssertLogContains("Message from MyTarget"); } From fbbc152d5a3b58794b50eed288636d5ce7d70d30 Mon Sep 17 00:00:00 2001 From: elachlan <2433737+elachlan@users.noreply.github.com> Date: Sat, 8 Jan 2022 17:32:13 +1000 Subject: [PATCH 2/2] enable warning on SA1014 --- eng/Common.globalconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/Common.globalconfig b/eng/Common.globalconfig index fd878420d57..15360dcad0a 100644 --- a/eng/Common.globalconfig +++ b/eng/Common.globalconfig @@ -738,7 +738,7 @@ dotnet_diagnostic.SA1012.severity = suggestion dotnet_diagnostic.SA1013.severity = suggestion # Opening generic brackets should not be preceded by a space -dotnet_diagnostic.SA1014.severity = suggestion +dotnet_diagnostic.SA1014.severity = warning # Closing generic bracket should not be followed by a space dotnet_diagnostic.SA1015.severity = suggestion