Performance regressions on EF scenarios

[sebastienros]

Most probably due to threadpool/epoll changes on the same commit.

dotnet/aspnetcore#21593
dotnet/aspnetcore#21596
dotnet/aspnetcore#21634
dotnet/aspnetcore#21640
dotnet/aspnetcore#21650
dotnet/aspnetcore#21688

The lines that are up are either ADO.NET or Dapper. The ones that are down are EF.

/cc @adamsitnik @roji

[Pilchie]

Should we transfer this to the runtime repo?

[sebastienros]

@Pilchie that's probably where it should be. There is a chance that it gets closed since it's not regressing from the previous version. It's an unfortunate "local" regression. But I am sure some investigation will definitely be done to at least understand the reasons.

[Dotnet-GitSync-Bot]

I couldn't figure out the best area label to add to this issue. Please help me learn by adding exactly one area label.

[danmoseley]

@kouvel @adamsitnik

[davidfowl]

@sebastienros didn't you say it was from @adamsitnik 's change (single epoll thread?). We have diffs to show what changes affect the graph right?

[stephentoub]

EF looks like it went up for a day or two and then went back down to what it was. Were the few measurements showing a temporary increase legit? Just making sure.

Also, what is the magnitude of the regression? It's hard to tell from the screenshot, but it looks fairly small?

[sebastienros]

Here are the actual runtime versions that regressed, and links to commits. I can't be more precise than that as it's based on the available runtime builds.

Scenario: DbFortunesEF

5.0.0-preview.5.20253.4 154K RPS
5.0.0-preview.5.20253.5 170K RPS
82eff51...2d29378 (contains @kouvel 's changes)

5.0.0-preview.5.20253.7 166K RPS
5.0.0-preview.5.20257.11 151K RPS
8527a99...9334426 (contains @adamsitnik 's changes)

Command line:

dotnet run -- --server http://asp-citrine-lin:5001 --client http://asp-citrine-load:5002 
-j ..\Benchmarks\benchmarks.html.json -n DbFortunesEF --database PostgresQL 
--warmup 15 --duration 30 --self-contained 
--aspnetcoreversion 5.0.0-preview.5.20253.1 --runtimeversion 5.0.0-preview.5.20257.11 

Pinned ASP.NET version across runs.
To collect traces add --collect-trace.
Change the runtime version accordingly.

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

[mangod9]

Moving to sockets area, since this is related to epoll changes.