From dc49b807e1053bd34db277f8758d779f53ee8c63 Mon Sep 17 00:00:00 2001 From: Julie Lee Date: Mon, 26 Aug 2024 12:12:38 -0700 Subject: [PATCH] Code cleanup: Replace TODO with Note regarding using a precise range for IntegralRnage. --- src/coreclr/jit/assertionprop.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/coreclr/jit/assertionprop.cpp b/src/coreclr/jit/assertionprop.cpp index 3d61a698a08d5c..e41e66f598319c 100644 --- a/src/coreclr/jit/assertionprop.cpp +++ b/src/coreclr/jit/assertionprop.cpp @@ -291,7 +291,8 @@ bool IntegralRange::Contains(int64_t value) const case NI_LZCNT_X64_LeadingZeroCount: case NI_POPCNT_PopCount: case NI_POPCNT_X64_PopCount: - // TODO-Casts: specify more precise ranges once "IntegralRange" supports them. + // Note: No advantage in using a precise range for IntegralRange. + // Example: IntCns = 42 gives [0..127] with a non -precise range, [42,42] with a precise range. return {SymbolicIntegerValue::Zero, SymbolicIntegerValue::ByteMax}; #elif defined(TARGET_ARM64) case NI_Vector64_op_Equality: @@ -317,7 +318,8 @@ bool IntegralRange::Contains(int64_t value) const case NI_ArmBase_LeadingZeroCount: case NI_ArmBase_Arm64_LeadingZeroCount: case NI_ArmBase_Arm64_LeadingSignCount: - // TODO-Casts: specify more precise ranges once "IntegralRange" supports them. + // Note: No advantage in using a precise range for IntegralRange. + // Example: IntCns = 42 gives [0..127] with a non -precise range, [42,42] with a precise range. return {SymbolicIntegerValue::Zero, SymbolicIntegerValue::ByteMax}; #else #error Unsupported platform