From f6107fba8fd6a6f68c8b29944233fccd26527b82 Mon Sep 17 00:00:00 2001 From: Tarek Mahmoud Sayed Date: Thu, 24 Apr 2025 15:04:42 -0700 Subject: [PATCH 1/2] Fix Idn failing tests --- .../IdnMapping/Data/Factory.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs b/src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs index c2610eb092ced3..671c5800463885 100644 --- a/src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs +++ b/src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs @@ -28,7 +28,7 @@ private static Stream GetIdnaTestTxt() string fileName = null; if (PlatformDetection.ICUVersion >= new Version(76, 0)) fileName = "IdnaTest_16.txt"; - else if (PlatformDetection.ICUVersion >= new Version(74, 0)) + else if (PlatformDetection.ICUVersion >= new Version(72, 0)) fileName = "IdnaTest_15_1.txt"; else if (PlatformDetection.ICUVersion >= new Version(66, 0) || PlatformDetection.IsHybridGlobalizationOnApplePlatform) fileName = "IdnaTest_13.txt"; From aabdb6b76d801527013de402c905b2c356e9b733 Mon Sep 17 00:00:00 2001 From: Tarek Mahmoud Sayed <10833894+tarekgh@users.noreply.github.com> Date: Thu, 24 Apr 2025 17:29:00 -0700 Subject: [PATCH 2/2] Minor fix --- .../IdnMapping/Data/Factory.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs b/src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs index 671c5800463885..f1d96fc1c94097 100644 --- a/src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs +++ b/src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs @@ -67,7 +67,7 @@ private static IConformanceIdnaTest GetConformanceIdnaTest(string line, int line { if (PlatformDetection.ICUVersion >= new Version(76, 0)) return new Unicode_16_0_IdnaTest(line, lineCount); - else if (PlatformDetection.ICUVersion >= new Version(74, 0)) + else if (PlatformDetection.ICUVersion >= new Version(72, 0)) return new Unicode_15_1_IdnaTest(line, lineCount); else if (PlatformDetection.ICUVersion >= new Version(66, 0) || PlatformDetection.IsHybridGlobalizationOnApplePlatform) return new Unicode_13_0_IdnaTest(line, lineCount);