From 5e3aed416c09e50dace20d15643214efcee30977 Mon Sep 17 00:00:00 2001 From: Jeremy Koritzinsky Date: Wed, 16 Apr 2025 11:05:54 -0700 Subject: [PATCH 1/2] Disable the UTFStringConversionFailures test on CI runs as our Helix machines can't handle the load from allocating 2 2GB strings and the OOM killer was killing the process. --- .../LibraryImportGenerator.Tests/CollectionMarshallingFails.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/CollectionMarshallingFails.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/CollectionMarshallingFails.cs index e238ca51f24044..d418064467970f 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/CollectionMarshallingFails.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/CollectionMarshallingFails.cs @@ -110,6 +110,7 @@ public static partial void NegateBoolsRef2D_ClearMarshalling( public class CollectionMarshallingFails { [Fact] + [SkipOnCI("Allocates enough memory that the OOM killer can kill the process on our Helix machines.")] public void UTFStringConversionFailures() { bool threw = false; From ef32f7f0298bfaa073a92d1a2c153f48f01de927 Mon Sep 17 00:00:00 2001 From: Jeremy Koritzinsky Date: Wed, 16 Apr 2025 13:37:29 -0700 Subject: [PATCH 2/2] Rename test as well --- .../LibraryImportGenerator.Tests/CollectionMarshallingFails.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/CollectionMarshallingFails.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/CollectionMarshallingFails.cs index d418064467970f..dd2759297b3a20 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/CollectionMarshallingFails.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/CollectionMarshallingFails.cs @@ -111,7 +111,7 @@ public class CollectionMarshallingFails { [Fact] [SkipOnCI("Allocates enough memory that the OOM killer can kill the process on our Helix machines.")] - public void UTFStringConversionFailures() + public void BigUTFStringConversionFailures() { bool threw = false; try