From ad3eccf1d9094ad6e66222d52a35f2d6070a2c7d Mon Sep 17 00:00:00 2001 From: Matt Thalman Date: Thu, 24 Jul 2025 09:56:03 -0500 Subject: [PATCH 1/2] Platform dependency doc changes --- .github/CODEOWNERS | 1 - docs/coding-guidelines/interop-guidelines.md | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index f634bbfd00239b..e425cc58edb976 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,7 +1,6 @@ # Users referenced in this file will automatically be requested as reviewers for PRs that modify the given paths. # See https://help.github.com/articles/about-code-owners/ -/src/libraries/Common/src/Interop/ @dotnet/platform-deps-team /src/libraries/Common/src/System/Net/Http/aspnetcore/ @dotnet/http /src/libraries/Common/tests/Tests/System/Net/aspnetcore/ @dotnet/http diff --git a/docs/coding-guidelines/interop-guidelines.md b/docs/coding-guidelines/interop-guidelines.md index 8338f4c1d04e23..d05a580ef8affd 100644 --- a/docs/coding-guidelines/interop-guidelines.md +++ b/docs/coding-guidelines/interop-guidelines.md @@ -17,9 +17,7 @@ We have the following goals related to interop code being used in dotnet/runtime ## Submitting Changes -Interop code implicitly defines the native platform dependencies that .NET has. These dependencies are tracked and modeled according to the [Tracking Platform Dependencies design](https://github.com/dotnet/designs/blob/main/accepted/2021/platform-dependencies/platform-dependencies.md). Whenever a PR is submitted that changes interop code, it needs to be reviewed to determine whether a change to the platform dependencies model is required. - -By default, any change to `src/libraries/Common/src/Interop` folder will add @dotnet/platform-deps-team as a reviewer. If necessary, update the corresponding `https://github.com/dotnet/core/blob/main/release-notes//runtime-deps.json` file to reflect the dependency change. The scope of dependencies is at the file/package level, not individual functions, so interop changes rarely require an update to the model. +Interop code implicitly defines the native platform dependencies that .NET has. These dependencies are tracked and modeled according to the [`os-packages.json` file](https://github.com/dotnet/core/tree/main/release-notes/schemas#os-packages----os-packagesjson) for each version. Whenever a PR is submitted that changes interop code, it needs to be reviewed to determine whether a change to the `os-packages.json` file is required. ## Approach From 8f9bbb4c4df183facbe94f718a195b5b49991c3c Mon Sep 17 00:00:00 2001 From: Matt Thalman Date: Thu, 24 Jul 2025 10:51:28 -0500 Subject: [PATCH 2/2] Delete "Submitting Changes" section --- docs/coding-guidelines/interop-guidelines.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/coding-guidelines/interop-guidelines.md b/docs/coding-guidelines/interop-guidelines.md index d05a580ef8affd..8f3c9e931b508d 100644 --- a/docs/coding-guidelines/interop-guidelines.md +++ b/docs/coding-guidelines/interop-guidelines.md @@ -15,10 +15,6 @@ We have the following goals related to interop code being used in dotnet/runtime - Ensure maximal managed code reuse across different OS flavors which have the same API but not the same ABI. - This is the case for UNIX and addressing it is a work-in-progress (see issue #2137 and section on "shims" below.) -## Submitting Changes - -Interop code implicitly defines the native platform dependencies that .NET has. These dependencies are tracked and modeled according to the [`os-packages.json` file](https://github.com/dotnet/core/tree/main/release-notes/schemas#os-packages----os-packagesjson) for each version. Whenever a PR is submitted that changes interop code, it needs to be reviewed to determine whether a change to the `os-packages.json` file is required. - ## Approach ### Interop type