From e4fa2a0cbba41a6cc277711c270529cbe288d7cd Mon Sep 17 00:00:00 2001 From: Max Charlamb <44248479+max-charlamb@users.noreply.github.com> Date: Fri, 5 Sep 2025 12:02:37 -0400 Subject: [PATCH 1/2] properly return internal_root_array --- src/coreclr/debug/daccess/request.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/debug/daccess/request.cpp b/src/coreclr/debug/daccess/request.cpp index 9f567d48809b39..5c4f30d687a26e 100644 --- a/src/coreclr/debug/daccess/request.cpp +++ b/src/coreclr/debug/daccess/request.cpp @@ -3249,7 +3249,7 @@ ClrDataAccess::GetHeapAnalyzeStaticData(struct DacpGcHeapAnalyzeData *analyzeDat SOSDacEnter(); - analyzeData->internal_root_array = dac_cast(g_gcDacGlobals->internal_root_array); + analyzeData->internal_root_array = dac_cast(*g_gcDacGlobals->internal_root_array); analyzeData->internal_root_array_index = *g_gcDacGlobals->internal_root_array_index; analyzeData->heap_analyze_success = *g_gcDacGlobals->heap_analyze_success; From c6d0f5c2940ad481fb475abb25eeb6b5fb562f20 Mon Sep 17 00:00:00 2001 From: Max Charlamb <44248479+max-charlamb@users.noreply.github.com> Date: Mon, 8 Sep 2025 16:32:40 -0400 Subject: [PATCH 2/2] fix dereference --- src/coreclr/debug/daccess/request.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/debug/daccess/request.cpp b/src/coreclr/debug/daccess/request.cpp index 5c4f30d687a26e..462846d6027fe5 100644 --- a/src/coreclr/debug/daccess/request.cpp +++ b/src/coreclr/debug/daccess/request.cpp @@ -3249,7 +3249,7 @@ ClrDataAccess::GetHeapAnalyzeStaticData(struct DacpGcHeapAnalyzeData *analyzeDat SOSDacEnter(); - analyzeData->internal_root_array = dac_cast(*g_gcDacGlobals->internal_root_array); + analyzeData->internal_root_array = TO_CDADDR((TADDR)(*g_gcDacGlobals->internal_root_array)); analyzeData->internal_root_array_index = *g_gcDacGlobals->internal_root_array_index; analyzeData->heap_analyze_success = *g_gcDacGlobals->heap_analyze_success;