From f1e4b465bfa4cc10adbcc7352ab39e94b785621a Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 15 Jan 2026 21:36:04 +0000 Subject: [PATCH 1/2] Initial plan From cf4dc96892d62d8d040615ac5d3440fa9d09098a Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 15 Jan 2026 22:05:54 +0000 Subject: [PATCH 2/2] Remove DisablePackageBaselineValidation from project files Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com> --- docs/coding-guidelines/project-guidelines.md | 2 +- .../System.IO.Ports/pkg/runtime.native.System.IO.Ports.props | 2 -- .../src/System.Linq.AsyncEnumerable.csproj | 5 ----- .../Microsoft.NET.Runtime.WebAssembly.Templates.csproj | 2 +- src/tools/illink/src/linker/Mono.Linker.csproj | 4 ---- 5 files changed, 2 insertions(+), 13 deletions(-) diff --git a/docs/coding-guidelines/project-guidelines.md b/docs/coding-guidelines/project-guidelines.md index ca72ec4e2c1ce4..5ec42d75c9c0d0 100644 --- a/docs/coding-guidelines/project-guidelines.md +++ b/docs/coding-guidelines/project-guidelines.md @@ -78,7 +78,7 @@ By default, packable project (mostly source projects) have APICompat package val This also includes _package baseline validation_ which automatically restores a previously produced package version (from the NuGet feeds) of the project and compares the public API to guard against breaking changes. When adding a brand new library, package baseline validation needs to be disabled temporarily as there's no previously produced package available yet. This should be done -by setting the `DisablePackageBaselineValidation` property to true: https://github.com/dotnet/runtime/blob/634641c806b129bd6892e071aece3f4916ea519d/src/libraries/System.Linq.AsyncEnumerable/src/System.Linq.AsyncEnumerable.csproj#L14-L17 +by setting the `DisablePackageBaselineValidation` property to true. ## TargetFramework conditions `TargetFramework` conditions should be avoided in the first PropertyGroup as that causes DesignTimeBuild issues: https://github.com/dotnet/project-system/issues/6143 diff --git a/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props b/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props index c0b3f6bac390dd..deee46a1e4c120 100644 --- a/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props +++ b/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props @@ -12,8 +12,6 @@ true $(NoWarn);NU5128 - - true $(MSBuildThisFileDirectory)../src/PACKAGE.md diff --git a/src/libraries/System.Linq.AsyncEnumerable/src/System.Linq.AsyncEnumerable.csproj b/src/libraries/System.Linq.AsyncEnumerable/src/System.Linq.AsyncEnumerable.csproj index 62dda55139c872..bcca9244ad0be6 100644 --- a/src/libraries/System.Linq.AsyncEnumerable/src/System.Linq.AsyncEnumerable.csproj +++ b/src/libraries/System.Linq.AsyncEnumerable/src/System.Linq.AsyncEnumerable.csproj @@ -10,11 +10,6 @@ $(NoWarn);CA2007 - - - true diff --git a/src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj b/src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj index b1bae872a5ba21..8ac9749e9e9c5c 100644 --- a/src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj +++ b/src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj @@ -2,6 +2,7 @@ $(NetCoreAppToolCurrent) + false Template @@ -17,7 +18,6 @@ $(NoWarn);NU5128 true false - true false diff --git a/src/tools/illink/src/linker/Mono.Linker.csproj b/src/tools/illink/src/linker/Mono.Linker.csproj index 35293cd7078a82..23b0c616a11b0c 100644 --- a/src/tools/illink/src/linker/Mono.Linker.csproj +++ b/src/tools/illink/src/linker/Mono.Linker.csproj @@ -9,10 +9,6 @@ true false Microsoft.NET.ILLink - - true false $(NoWarn);CS8524