From 70cc0c0e3ee6decf4f4c4096202519f38017dd12 Mon Sep 17 00:00:00 2001 From: Vlad Brezae Date: Mon, 16 Feb 2026 20:02:19 +0200 Subject: [PATCH] Add default value when FeatureDynamicCodeCompiled is undefined This property is normally passed to msbuild when building runtime.proj, with a true or false value. An exception happens when building from vs, with `./build.cmd -vs coreclr.slnx`. Feature defines need to have a default value for this scenario. Rather than adding a default in clrfeatures.cmake, which would require duplicating target os logic from the build scripts, this commit handles the default at a higher level in runtime.proj. --- src/coreclr/runtime.proj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/runtime.proj b/src/coreclr/runtime.proj index 2c42bc9e1f9ad5..1d3ec82608a69e 100644 --- a/src/coreclr/runtime.proj +++ b/src/coreclr/runtime.proj @@ -54,7 +54,7 @@ <_CoreClrBuildArg Condition="'$(HasCdacBuildTool)' == 'true'" Include="-cmakeargs "-DCDAC_BUILD_TOOL_BINARY_PATH=$(RuntimeBinDir)cdac-build-tool\cdac-build-tool.dll"" /> <_CoreClrBuildArg Condition="'$(FeatureXplatEventSource)' == 'false'" Include="-cmakeargs "-DFEATURE_EVENTSOURCE_XPLAT=0"" /> <_CoreClrBuildArg Condition="'$(FeatureInterpreter)' == 'true'" Include="-cmakeargs "-DFEATURE_INTERPRETER=1"" /> - <_CoreClrBuildArg Condition="'$(FeatureDynamicCodeCompiled)' == 'true'" Include="-cmakeargs "-DFEATURE_DYNAMIC_CODE_COMPILED=1"" /> + <_CoreClrBuildArg Condition="'$(FeatureDynamicCodeCompiled)' == 'true' or '$(FeatureDynamicCodeCompiled)' == ''" Include="-cmakeargs "-DFEATURE_DYNAMIC_CODE_COMPILED=1"" />