Skip to content

Comments

[RuntimeAsync] Remove [RequiresPreviewFeatures] on runtime async API#124488

Merged
VSadov merged 6 commits intodotnet:mainfrom
VSadov:noPreview
Feb 17, 2026
Merged

[RuntimeAsync] Remove [RequiresPreviewFeatures] on runtime async API#124488
VSadov merged 6 commits intodotnet:mainfrom
VSadov:noPreview

Conversation

@VSadov
Copy link
Member

@VSadov VSadov commented Feb 16, 2026

The purpose of this attribute is to ship preview features in non-preview releases.

Also removes SYSLIB5007 suppressions as not needed. The API is not marked experimental for some time now.

@VSadov VSadov requested a review from sbomer as a code owner February 16, 2026 23:20
Copilot AI review requested due to automatic review settings February 16, 2026 23:20
@VSadov VSadov requested a review from agocke February 16, 2026 23:20
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Feb 16, 2026
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes preview-feature annotations from the Runtime Async helper APIs and cleans up test/project warning suppressions that were only needed due to RequiresPreviewFeatures.

Changes:

  • Removed [RequiresPreviewFeatures] from System.Runtime.CompilerServices.AsyncHelpers APIs (ref + implementation).
  • Dropped SYSLIB5007 suppressions from runtime-async related test builds.
  • Updated linker test compile arguments to no longer suppress SYSLIB5007.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/RuntimeAsyncMethods.cs Removes SYSLIB5007 suppression from linker test compilation.
src/tests/async/Directory.Build.props Removes SYSLIB5007 from global NoWarn for async tests.
src/tests/Interop/COM/RuntimeAsync/RuntimeAsync.csproj Removes SYSLIB5007 suppression (but leaves a redundant NoWarn property).
src/libraries/System.Runtime/ref/System.Runtime.cs Removes [RequiresPreviewFeatures] from AsyncHelpers public reference surface.
src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.cs Removes [RequiresPreviewFeatures] from the library implementation (and stubs).
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs Removes [RequiresPreviewFeatures] from CoreCLR implementation helper (TransparentAwait).

Copilot AI review requested due to automatic review settings February 16, 2026 23:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings February 17, 2026 00:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@VSadov
Copy link
Member Author

VSadov commented Feb 17, 2026

/ba-g mono interpreter failures is #100800

@VSadov VSadov merged commit 7f0095f into dotnet:main Feb 17, 2026
168 of 170 checks passed
@VSadov
Copy link
Member Author

VSadov commented Feb 17, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-VM-coreclr linkable-framework Issues associated with delivering a linker friendly framework runtime-async

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants