From c6a8f1c517ebace42ae0f7e6c6dc4bf363f56692 Mon Sep 17 00:00:00 2001 From: egorbot Date: Thu, 19 Feb 2026 17:38:15 +0100 Subject: [PATCH 1/5] Fix abandoned tests --- .github/skills/jit-regression-test/SKILL.md | 7 ++++--- src/tests/JIT/Regression/Regression_ro_2.csproj | 7 ++++++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/skills/jit-regression-test/SKILL.md b/.github/skills/jit-regression-test/SKILL.md index 6f86920dea902d..fe0ebc0a072321 100644 --- a/.github/skills/jit-regression-test/SKILL.md +++ b/.github/skills/jit-regression-test/SKILL.md @@ -86,13 +86,14 @@ public class Runtime_99391 } ``` -## [Optional] Step 4: Create a .csproj File (Only When Needed) +## Step 4: Create a .csproj File A custom `.csproj` file is **only required** when: - Environment variables are needed to reproduce the bug (such as `DOTNET_JitStressModeNames`) - Special compilation settings are required +Otherwise, register the test file in the existing `src/tests/JIT/Regression/Regression_ro_2.csproj` file and skip creating a new .csproj. -It should be located next to the test source file with the following name: `Runtime_.csproj`. Example: +If a custom .csproj file is needed, it should be located next to the test source file with the following name: `Runtime_.csproj`. Example: ```xml @@ -112,7 +113,7 @@ It should be located next to the test source file with the following name: `Runt ## Important Notes -- **No .csproj needed for simple tests**: Most tests only need the `.cs` file. The test infrastructure uses default settings that work for most cases. +- **No .csproj needed for simple tests**: Most tests only need the `.cs` file in a separate `src/tests/JIT/Regression/JitBlue/Runtime_*/` folder and being registered in `Regression_ro_2.csproj`. - **Look at recent tests**: When in doubt, examine recent tests under `src/tests/JIT/Regression/JitBlue/Runtime_*` for the latest conventions. - **Use `[MethodImpl(MethodImplOptions.NoInlining)]`**: When you need to prevent inlining to reproduce a JIT bug. - **Minimize the reproduction**: Strip down the test code to the minimal case that reproduces the issue. diff --git a/src/tests/JIT/Regression/Regression_ro_2.csproj b/src/tests/JIT/Regression/Regression_ro_2.csproj index 9723f0d3b6f83f..e59c73f4b5ed2f 100644 --- a/src/tests/JIT/Regression/Regression_ro_2.csproj +++ b/src/tests/JIT/Regression/Regression_ro_2.csproj @@ -83,6 +83,11 @@ + + + + + - \ No newline at end of file + From a1b0ef8eeb705395eb82a68fcf879d8ccabd96ce Mon Sep 17 00:00:00 2001 From: Egor Bogatov Date: Thu, 19 Feb 2026 17:47:44 +0100 Subject: [PATCH 2/5] Update SKILL.md --- .github/skills/jit-regression-test/SKILL.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/skills/jit-regression-test/SKILL.md b/.github/skills/jit-regression-test/SKILL.md index fe0ebc0a072321..55532c863fd281 100644 --- a/.github/skills/jit-regression-test/SKILL.md +++ b/.github/skills/jit-regression-test/SKILL.md @@ -86,7 +86,7 @@ public class Runtime_99391 } ``` -## Step 4: Create a .csproj File +## Step 4: Create a .csproj File or add to Regression_ro_2.csproj A custom `.csproj` file is **only required** when: - Environment variables are needed to reproduce the bug (such as `DOTNET_JitStressModeNames`) From 5e05680333c4bbf631b6e53c42e4c192d160c0c8 Mon Sep 17 00:00:00 2001 From: Egor Bogatov Date: Thu, 19 Feb 2026 17:48:39 +0100 Subject: [PATCH 3/5] Update instructions for .csproj file creation --- .github/skills/jit-regression-test/SKILL.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/skills/jit-regression-test/SKILL.md b/.github/skills/jit-regression-test/SKILL.md index 55532c863fd281..0d361b74b5b139 100644 --- a/.github/skills/jit-regression-test/SKILL.md +++ b/.github/skills/jit-regression-test/SKILL.md @@ -86,12 +86,12 @@ public class Runtime_99391 } ``` -## Step 4: Create a .csproj File or add to Regression_ro_2.csproj +## Step 4: Create a .csproj File or add to the existing Regression_*.csproj A custom `.csproj` file is **only required** when: - Environment variables are needed to reproduce the bug (such as `DOTNET_JitStressModeNames`) - Special compilation settings are required -Otherwise, register the test file in the existing `src/tests/JIT/Regression/Regression_ro_2.csproj` file and skip creating a new .csproj. +Otherwise, register the test file in the existing `src/tests/JIT/Regression/Regression_*.csproj` (`Regression_ro_2.csproj` is a good default) file and skip creating a new .csproj. If a custom .csproj file is needed, it should be located next to the test source file with the following name: `Runtime_.csproj`. Example: From b5a912c58d57ec4e008b7c319ceb0872ce59ca8e Mon Sep 17 00:00:00 2001 From: egorbot Date: Thu, 19 Feb 2026 22:24:20 +0100 Subject: [PATCH 4/5] dummy change --- src/coreclr/jit/fgopt.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/jit/fgopt.cpp b/src/coreclr/jit/fgopt.cpp index 547688a959c4da..1d66308309ce32 100644 --- a/src/coreclr/jit/fgopt.cpp +++ b/src/coreclr/jit/fgopt.cpp @@ -9,7 +9,7 @@ #include "lower.h" // for LowerRange() -// Flowgraph Optimization +// Flowgraph Optimizatio //------------------------------------------------------------------------ // fgComputeReturnBlocks: Compute the set of BBJ_RETURN blocks. From 1b4f8568700fa8786c89ad70074722598ec80295 Mon Sep 17 00:00:00 2001 From: Egor Bogatov Date: Fri, 20 Feb 2026 16:48:29 +0100 Subject: [PATCH 5/5] Update fgopt.cpp --- src/coreclr/jit/fgopt.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/jit/fgopt.cpp b/src/coreclr/jit/fgopt.cpp index 1d66308309ce32..547688a959c4da 100644 --- a/src/coreclr/jit/fgopt.cpp +++ b/src/coreclr/jit/fgopt.cpp @@ -9,7 +9,7 @@ #include "lower.h" // for LowerRange() -// Flowgraph Optimizatio +// Flowgraph Optimization //------------------------------------------------------------------------ // fgComputeReturnBlocks: Compute the set of BBJ_RETURN blocks.