From 6fac02845816d17da6951224a64d858d2e90578c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BD=C5=AFrek?= <188900745+mrek-msft@users.noreply.github.com> Date: Tue, 3 Mar 2026 14:32:13 +0100 Subject: [PATCH 1/4] try remove test exclusions --- .../tests/ConfigurationExtensionTest.cs | 1 - .../tests/FunctionalTests/ArrayTests.cs | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs b/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs index e92a875b34ef22..93c6dd6f4a42bc 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs +++ b/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs @@ -52,7 +52,6 @@ private void SetSecret(string id, string key, string value) } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)] public void AddUserSecrets_FindsAssemblyAttribute() { var randValue = Guid.NewGuid().ToString(); diff --git a/src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ArrayTests.cs b/src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ArrayTests.cs index c4ee3d0e231f27..080a5ccf499318 100644 --- a/src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ArrayTests.cs +++ b/src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ArrayTests.cs @@ -47,7 +47,6 @@ public class ArrayTests : IDisposable "; [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)] public void DifferentConfigSources_Merged_KeysAreSorted() { var config = BuildConfig(); @@ -76,7 +75,6 @@ public void DifferentConfigSources_Merged_KeysAreSorted() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)] public void DifferentConfigSources_Merged_WithOverwrites() { var config = BuildConfig(); From 1ce98a6ce8cb130e2e24f930ece0791319e4adca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BD=C5=AFrek?= <188900745+mrek-msft@users.noreply.github.com> Date: Mon, 9 Mar 2026 15:11:05 +0100 Subject: [PATCH 2/4] try broke test --- .../tests/ConfigurationExtensionTest.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs b/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs index 93c6dd6f4a42bc..e61da913b46b3e 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs +++ b/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs @@ -54,6 +54,7 @@ private void SetSecret(string id, string key, string value) [Fact] public void AddUserSecrets_FindsAssemblyAttribute() { + throw new Exception("test foo bar"); var randValue = Guid.NewGuid().ToString(); var configKey = "MyDummySetting"; From 5e921d6646c05b203fa6e9a030f5a7d480205d7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BD=C5=AFrek?= <188900745+mrek-msft@users.noreply.github.com> Date: Tue, 10 Mar 2026 13:45:33 +0100 Subject: [PATCH 3/4] comment out temporary dead code --- .../tests/ConfigurationExtensionTest.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs b/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs index e61da913b46b3e..078438bff7937a 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs +++ b/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs @@ -55,6 +55,7 @@ private void SetSecret(string id, string key, string value) public void AddUserSecrets_FindsAssemblyAttribute() { throw new Exception("test foo bar"); + /* var randValue = Guid.NewGuid().ToString(); var configKey = "MyDummySetting"; @@ -64,6 +65,7 @@ public void AddUserSecrets_FindsAssemblyAttribute() .Build(); Assert.Equal(randValue, config[configKey]); + */ } [Fact] From e3c3ed33eb44c4b8282c2d3bd4182b7f6a9ff40d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BD=C5=AFrek?= <188900745+mrek-msft@users.noreply.github.com> Date: Wed, 11 Mar 2026 13:54:39 +0100 Subject: [PATCH 4/4] Remove experimental code and remove remaining ActiveIssues --- .../tests/ConfigurationExtensionTest.cs | 5 ----- .../tests/FunctionalTests/ConfigurationTests.cs | 2 -- .../tests/CompilationLibraryTests.cs | 1 - 3 files changed, 8 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs b/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs index 078438bff7937a..72f8f4b31be19f 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs +++ b/src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs @@ -54,8 +54,6 @@ private void SetSecret(string id, string key, string value) [Fact] public void AddUserSecrets_FindsAssemblyAttribute() { - throw new Exception("test foo bar"); - /* var randValue = Guid.NewGuid().ToString(); var configKey = "MyDummySetting"; @@ -65,11 +63,9 @@ public void AddUserSecrets_FindsAssemblyAttribute() .Build(); Assert.Equal(randValue, config[configKey]); - */ } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)] public void AddUserSecrets_FindsAssemblyAttributeFromType() { var randValue = Guid.NewGuid().ToString(); @@ -123,7 +119,6 @@ public void AddUserSecrets_DoesThrowsIfNotOptionalAndSecretDoesNotExist() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)] public void AddUserSecrets_With_SecretsId_Passed_Explicitly() { var userSecretsId = Guid.NewGuid().ToString(); diff --git a/src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs b/src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs index f6bbb5adc056e5..3653cb40d3530a 100644 --- a/src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs +++ b/src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs @@ -358,7 +358,6 @@ public IConfigurationProvider Build(IConfigurationBuilder builder) } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)] public void OnLoadErrorWillBeCalledOnJsonParseError() { _fileSystem.WriteFile(Path.Combine(_basePath, "error.json"), @"{""JsonKey1"": ", absolute: true); @@ -863,7 +862,6 @@ public void SetBasePathCalledMultipleTimesForEachSourceLastOneWins() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)] public void GetDefaultBasePathForSources() { var builder = new ConfigurationBuilder(); diff --git a/src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs b/src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs index a5ee77da175fce..335e5590e5ac0f 100644 --- a/src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs +++ b/src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs @@ -51,7 +51,6 @@ public void ResolveReferencePathsAcceptsCustomResolvers() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)] public void ResolveReferencePathsAcceptsNullCustomResolvers() { var library = TestLibraryFactory.Create();